qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Kunkun Jiang <jiangkunkun@huawei.com>
Cc: "Juan Quintela" <quintela@redhat.com>,
	"David Edmondson" <dme@dme.org>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Alexey Romko" <nevilad@yahoo.com>,
	"Zenghui Yu" <yuzenghui@huawei.com>,
	wanghaibin.wang@huawei.com, "Keqian Zhu" <zhukeqian1@huawei.com>,
	"Andrey Gruzdev" <andrey.gruzdev@virtuozzo.com>
Subject: Re: [PATCH v4 2/2] migration/ram: Optimize ram_save_host_page()
Date: Tue, 16 Mar 2021 17:39:37 -0400	[thread overview]
Message-ID: <20210316213937.GG395976@xz-x1> (raw)
In-Reply-To: <20210316125716.1243-3-jiangkunkun@huawei.com>

On Tue, Mar 16, 2021 at 08:57:16PM +0800, Kunkun Jiang wrote:
> Starting from pss->page, ram_save_host_page() will check every page
> and send the dirty pages up to the end of the current host page or
> the boundary of used_length of the block. If the host page size is
> a huge page, the step "check" will take a lot of time.
> 
> It will improve performance to use migration_bitmap_find_dirty().
> 
> Tested on Kunpeng 920; VM parameters: 1U 4G (page size 1G)
> The time of ram_save_host_page() in the last round of ram saving:
> before optimize: 9250us		after optimize: 34us
> 
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks,

-- 
Peter Xu



  reply	other threads:[~2021-03-16 21:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 12:57 [PATCH v4 0/2] Some modification about ram_save_host_page() Kunkun Jiang
2021-03-16 12:57 ` [PATCH v4 1/2] migration/ram: Reduce unnecessary rate limiting Kunkun Jiang
2021-03-16 21:39   ` Peter Xu
2021-03-17  1:37     ` Kunkun Jiang
2021-03-17 10:43       ` David Edmondson
2021-03-17 12:05       ` Dr. David Alan Gilbert
2021-03-16 12:57 ` [PATCH v4 2/2] migration/ram: Optimize ram_save_host_page() Kunkun Jiang
2021-03-16 21:39   ` Peter Xu [this message]
2021-04-06 13:19 ` [PATCH v4 0/2] Some modification about ram_save_host_page() Kunkun Jiang
2021-04-06 17:14   ` Dr. David Alan Gilbert
2021-04-07  9:32     ` Kunkun Jiang
2021-05-11  9:17 ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210316213937.GG395976@xz-x1 \
    --to=peterx@redhat.com \
    --cc=andrey.gruzdev@virtuozzo.com \
    --cc=clg@kaod.org \
    --cc=dgilbert@redhat.com \
    --cc=dme@dme.org \
    --cc=jiangkunkun@huawei.com \
    --cc=nevilad@yahoo.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=wanghaibin.wang@huawei.com \
    --cc=yuzenghui@huawei.com \
    --cc=zhukeqian1@huawei.com \
    --subject='Re: [PATCH v4 2/2] migration/ram: Optimize ram_save_host_page()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).