From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C8D6C433E0 for ; Thu, 18 Mar 2021 00:13:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BA8564F24 for ; Thu, 18 Mar 2021 00:13:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BA8564F24 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bu.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMgI3-0008CI-0Z for qemu-devel@archiver.kernel.org; Wed, 17 Mar 2021 20:13:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMgH0-0007eP-T8 for qemu-devel@nongnu.org; Wed, 17 Mar 2021 20:12:22 -0400 Received: from relay64.bu.edu ([128.197.228.104]:48288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMgGy-0003MH-Vm for qemu-devel@nongnu.org; Wed, 17 Mar 2021 20:12:22 -0400 X-Envelope-From: alxndr@bu.edu X-BU-AUTH: mozz.bu.edu [128.197.127.33] Received: from BU-AUTH (localhost.localdomain [127.0.0.1]) (authenticated bits=0) by relay64.bu.edu (8.14.3/8.14.3) with ESMTP id 12I0Aku3002527 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Wed, 17 Mar 2021 20:10:49 -0400 Date: Wed, 17 Mar 2021 20:10:46 -0400 From: Alexander Bulekov To: Mark Cave-Ayland Subject: Re: [PATCH v2 3/6] esp: ensure cmdfifo is not empty and current_dev is non-NULL\ Message-ID: <20210318001046.saj4s7fzzjuarprc@mozz.bu.edu> References: <20210317230223.24854-1-mark.cave-ayland@ilande.co.uk> <20210317230223.24854-4-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317230223.24854-4-mark.cave-ayland@ilande.co.uk> Received-SPF: pass client-ip=128.197.228.104; envelope-from=alxndr@bu.edu; helo=relay64.bu.edu X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 210317 2302, Mark Cave-Ayland wrote: > When about to execute a SCSI command, ensure that cmdfifo is not empty and > current_dev is non-NULL. This can happen if the guest tries to execute a TI > (Transfer Information) command without issuing one of the select commands > first. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1910723 > Buglink: https://bugs.launchpad.net/qemu/+bug/1909247 > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 3 +++ > 1 file changed, 3 insertions(+) > Tested-by: Alexander Bulekov > diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c > index bbcbfa4a91..ae362c9dfb 100644 > --- a/hw/scsi/esp.c > +++ b/hw/scsi/esp.c > @@ -286,6 +286,9 @@ static void do_busid_cmd(ESPState *s, uint8_t busid) > trace_esp_do_busid_cmd(busid); > lun = busid & 7; > cmdlen = fifo8_num_used(&s->cmdfifo); > + if (!cmdlen || !s->current_dev) { > + return; > + } > buf = (uint8_t *)fifo8_pop_buf(&s->cmdfifo, cmdlen, &n); > > current_lun = scsi_device_find(&s->bus, 0, s->current_dev->id, lun); > -- > 2.20.1 >