From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2B8C433DB for ; Thu, 18 Mar 2021 04:19:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D51964F18 for ; Thu, 18 Mar 2021 04:19:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D51964F18 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMk88-0003Np-6T for qemu-devel@archiver.kernel.org; Thu, 18 Mar 2021 00:19:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMk6V-00026h-T4 for qemu-devel@nongnu.org; Thu, 18 Mar 2021 00:17:47 -0400 Received: from mga02.intel.com ([134.134.136.20]:25454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMk6R-0004IZ-6w for qemu-devel@nongnu.org; Thu, 18 Mar 2021 00:17:47 -0400 IronPort-SDR: Wcb3lCWlnrqpP659pj35/hNWWBwIStq1zWFT36bqs0fJTP4X8YZxd6WQpDCLMmFtFy3nkxqQm5 N5dxw5UTlLaA== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="176727957" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="176727957" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 21:17:36 -0700 IronPort-SDR: la7LS0444kkEDVmEKBxOPJY1gqOPyJslEFPWOHsxy+Ja0Bj3ZXoOsdjaKwNcXasFMLh1JK0ilj QwcynIRDmNwA== X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="412913963" Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 21:17:35 -0700 From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PULL 1/2] net/colo-compare.c: Fix memory leak for non-tcp packet Date: Thu, 18 Mar 2021 12:11:51 +0800 Message-Id: <20210318041152.59367-2-chen.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210318041152.59367-1-chen.zhang@intel.com> References: <20210318041152.59367-1-chen.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=134.134.136.20; envelope-from=chen.zhang@intel.com; helo=mga02.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Lukas Straub , Zhang Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Lukas Straub Additional to removing the packet from the secondary queue, we also need to free it. Signed-off-by: Lukas Straub Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen --- net/colo-compare.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 84db4978ac..2e819ffedb 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -690,6 +690,7 @@ static void colo_compare_packet(CompareState *s, Connection *conn, if (result) { colo_release_primary_pkt(s, pkt); + packet_destroy(result->data, NULL); g_queue_remove(&conn->secondary_list, result->data); } else { /* -- 2.25.1