From: Cornelia Huck <cohuck@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 2/4] iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
Date: Fri, 19 Mar 2021 12:43:39 +0100 [thread overview]
Message-ID: <20210319124339.6acd05d8.cohuck@redhat.com> (raw)
In-Reply-To: <20210318223907.1344870-3-laurent@vivier.eu>
On Thu, 18 Mar 2021 23:39:05 +0100
Laurent Vivier <laurent@vivier.eu> wrote:
> Commit f1d5516ab583 introduces a test in some iotests to check if
> the machine is a s390-ssw-virtio and to select virtio-*-ccw rather
s/ssw/ccw/
> than virtio-*-pci.
>
> We don't need that because QEMU already provides aliases to use the correct
> virtio interface according to the machine type.
Maybe add a comment that this also enables virtio-mmio?
>
> This patch removes all virtio-*-pci and virtio-*-ccw to use virtio-*
> instead.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> cc: Cornelia Huck <cohuck@redhat.com>
> ---
> blockdev.c | 6 +-----
Hm, that also tweaks how -drive behaves, IIUC. Intended, I think; but
worth a note as well?
> tests/qemu-iotests/040 | 2 +-
> tests/qemu-iotests/051 | 12 +-----------
> tests/qemu-iotests/068 | 4 +---
> tests/qemu-iotests/093 | 3 +--
> tests/qemu-iotests/139 | 9 ++-------
> tests/qemu-iotests/182 | 13 ++-----------
> tests/qemu-iotests/238 | 4 +---
> tests/qemu-iotests/240 | 10 +++++-----
> tests/qemu-iotests/257 | 4 ++--
> tests/qemu-iotests/307 | 4 +---
> tests/qemu-iotests/iotests.py | 5 -----
> 12 files changed, 18 insertions(+), 58 deletions(-)
next prev parent reply other threads:[~2021-03-19 11:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 22:39 [PATCH 0/4] iotests: fix failures with non-PCI machines Laurent Vivier
2021-03-18 22:39 ` [PATCH 1/4] m68k: add the virtio devices aliases Laurent Vivier
2021-03-18 22:51 ` Philippe Mathieu-Daudé
2021-03-19 6:47 ` Thomas Huth
2021-03-19 11:36 ` Cornelia Huck
2021-03-19 12:07 ` Laurent Vivier
2021-03-18 22:39 ` [PATCH 2/4] iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182" Laurent Vivier
2021-03-19 10:39 ` Philippe Mathieu-Daudé
2021-03-19 11:43 ` Cornelia Huck [this message]
2021-03-19 12:09 ` Laurent Vivier
2021-03-18 22:39 ` [PATCH 3/4] iotests: test m68k with the virt machine Laurent Vivier
2021-03-18 22:46 ` Philippe Mathieu-Daudé
2021-03-18 22:39 ` [PATCH 4/4] iotests: iothreads need ioeventfd Laurent Vivier
2021-03-19 11:06 ` Paolo Bonzini
2021-03-19 11:27 ` Cornelia Huck
2021-03-19 11:28 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319124339.6acd05d8.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).