From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: lvivier@redhat.com, thuth@redhat.com, alxndr@bu.edu,
bsd@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd
Date: Fri, 19 Mar 2021 14:20:08 +0100 [thread overview]
Message-ID: <20210319132008.1830950-1-armbru@redhat.com> (raw)
qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 uses -drive=sd where it
should use -drive if=none instead. This prints a deprecation warning:
$ ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3 -runs=1 -seed=1
[ASan warnings snipped...]
--> i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive: warning: bogus if=sd is deprecated, use if=none
INFO: Seed: 1
[More normal output snipped...]
Support for this usage will be gone soon. Adjust the test.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/qtest/fuzz/generic_fuzz_configs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
index 8b8c7ac553..004c701915 100644
--- a/tests/qtest/fuzz/generic_fuzz_configs.h
+++ b/tests/qtest/fuzz/generic_fuzz_configs.h
@@ -182,7 +182,7 @@ const generic_fuzz_config predefined_configs[] = {
.name = "sdhci-v3",
.args = "-nodefaults -device sdhci-pci,sd-spec-version=3 "
"-device sd-card,drive=mydrive "
- "-drive if=sd,index=0,file=null-co://,format=raw,id=mydrive -nographic",
+ "-drive if=none,index=0,file=null-co://,format=raw,id=mydrive -nographic",
.objects = "sd*"
},{
.name = "ehci",
--
2.26.3
next reply other threads:[~2021-03-19 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 13:20 Markus Armbruster [this message]
2021-03-19 14:08 ` [PATCH] fuzz: Avoid deprecated misuse of -drive if=sd Philippe Mathieu-Daudé
2021-03-19 14:40 ` Alexander Bulekov
2021-03-22 14:20 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319132008.1830950-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).