From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: david.edmondson@oracle.com,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
stefanha@redhat.com
Subject: [PATCH v6 3/6] coroutine-lock: Store the coroutine in the CoWaitRecord only once
Date: Thu, 25 Mar 2021 12:29:38 +0100 [thread overview]
Message-ID: <20210325112941.365238-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20210325112941.365238-1-pbonzini@redhat.com>
From: David Edmondson <david.edmondson@oracle.com>
When taking the slow path for mutex acquisition, set the coroutine
value in the CoWaitRecord in push_waiter(), rather than both there and
in the caller.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Message-Id: <20210309144015.557477-4-david.edmondson@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/qemu-coroutine-lock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/qemu-coroutine-lock.c b/util/qemu-coroutine-lock.c
index 5816bf8900..eb73cf11dc 100644
--- a/util/qemu-coroutine-lock.c
+++ b/util/qemu-coroutine-lock.c
@@ -204,7 +204,6 @@ static void coroutine_fn qemu_co_mutex_lock_slowpath(AioContext *ctx,
unsigned old_handoff;
trace_qemu_co_mutex_lock_entry(mutex, self);
- w.co = self;
push_waiter(mutex, &w);
/* This is the "Responsibility Hand-Off" protocol; a lock() picks from
--
2.29.2
next prev parent reply other threads:[~2021-03-25 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 11:29 [PATCH v6 0/6] coroutine rwlock downgrade fix, minor VDI changes Paolo Bonzini
2021-03-25 11:29 ` [PATCH v6 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer Paolo Bonzini
2021-03-30 15:28 ` Stefan Hajnoczi
2021-03-25 11:29 ` [PATCH v6 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader Paolo Bonzini
2021-03-30 15:29 ` Stefan Hajnoczi
2021-03-25 11:29 ` Paolo Bonzini [this message]
2021-03-30 15:29 ` [PATCH v6 3/6] coroutine-lock: Store the coroutine in the CoWaitRecord only once Stefan Hajnoczi
2021-03-25 11:29 ` [PATCH v6 4/6] coroutine-lock: Reimplement CoRwlock to fix downgrade bug Paolo Bonzini
2021-03-30 16:55 ` Stefan Hajnoczi
2021-03-25 11:29 ` [PATCH v6 5/6] test-coroutine: Add rwlock upgrade test Paolo Bonzini
2021-03-25 11:29 ` [PATCH v6 6/6] test-coroutine: Add rwlock downgrade test Paolo Bonzini
2021-03-30 17:50 ` [PATCH v6 0/6] coroutine rwlock downgrade fix, minor VDI changes Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325112941.365238-4-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).