Re: [PATCH for-6.0 1/7] hw/block/nvme: fix pi constraint check

From: Gollu Appalanaidu <anaidu.gollu@samsung.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
	qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH for-6.0 1/7] hw/block/nvme: fix pi constraint check
Date: Mon, 29 Mar 2021 19:52:58 +0530	[thread overview]
Message-ID: <20210329142258.GA23272@2030045822> (raw)
In-Reply-To: <20210324200907.408996-2-its@irrelevant.dk>

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

On Wed, Mar 24, 2021 at 09:09:01PM +0100, Klaus Jensen wrote:
>From: Klaus Jensen <k.jensen@samsung.com>
>
>Protection Information can only be enabled if there is at least 8 bytes
>of metadata.
>
>Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
>---
> hw/block/nvme-ns.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c
>index 7f8d139a8663..ca04ee1bacfb 100644
>--- a/hw/block/nvme-ns.c
>+++ b/hw/block/nvme-ns.c
>@@ -394,7 +394,7 @@ static int nvme_ns_check_constraints(NvmeNamespace *ns, Error **errp)
>         return -1;
>     }
>
>-    if (ns->params.pi && !ns->params.ms) {
>+    if (ns->params.pi && ns->params.ms < 8) {
and also it is good check that "metadata size" is power of 2 or not?

>         error_setg(errp, "at least 8 bytes of metadata required to enable "
>                    "protection information");
>         return -1;
>-- 
>2.31.0
>
>

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]