qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes
@ 2021-04-01 13:12 Thomas Huth
  2021-04-01 13:12 ` [PULL 01/13] MAINTAINERS: Fix tests/migration maintainers Thomas Huth
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell

 Hi Peter,

the following changes since commit 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5:

  Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.0-20210331' into staging (2021-03-31 13:14:18 +0100)

are available in the Git repository at:

  https://gitlab.com/thuth/qemu.git tags/pull-request-2021-04-01

for you to fetch changes up to ca89d15f8e42f2e5eac5bd200af38fdbfb32e875:

  device-crash-test: Ignore errors about a bus not being available (2021-04-01 14:28:39 +0200)

----------------------------------------------------------------
* Updates for the MAINTAINERS file
* Some small documentation updates
* Some small misc fixes
----------------------------------------------------------------

Connor Kuehl (1):
      MAINTAINERS: add virtio-fs mailing list

Dongjiu Geng (1):
      MAINTAINERS: replace Huawei's email to personal one

Hyman Huang(黄勇) (1):
      MAINTAINERS: Fix tests/migration maintainers

Mahmoud Mandour (1):
      util/compatfd.c: Fixed style issues

Markus Armbruster (1):
      qom: Fix default values in help

Matthew Rosato (1):
      MAINTAINERS: add/replace backups for some s390 areas

Philippe Mathieu-Daudé (2):
      MAINTAINERS: Mark RX hardware emulation orphan
      MAINTAINERS: Mark SH-4 hardware emulation orphan

Thomas Huth (5):
      MAINTAINERS: Drop the lines with Sarah Harris
      MAINTAINERS: Drop the line with Xiang Zheng
      docs: Remove obsolete paragraph about config-target.mak
      docs: Fix typo in the default name of the qemu-system-x86_64 binary
      device-crash-test: Ignore errors about a bus not being available

 MAINTAINERS                 | 35 +++++++++++++++++------------------
 docs/defs.rst.inc           |  2 +-
 docs/devel/build-system.rst |  8 --------
 qom/object_interfaces.c     |  2 +-
 scripts/device-crash-test   |  1 +
 util/compatfd.c             |  6 +++---
 6 files changed, 23 insertions(+), 31 deletions(-)



^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PULL 01/13] MAINTAINERS: Fix tests/migration maintainers
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 02/13] MAINTAINERS: add/replace backups for some s390 areas Thomas Huth
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell
  Cc: Philippe Mathieu-Daudé, Hyman Huang(黄勇)

From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>

when executing the following scripts, it throw error message:
$ ./scripts/get_maintainer.pl -f tests/migration/guestperf.py
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.

add the tests/migration to the "Migration" section of MAINTAINERS

Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <91d5978357fb8709ef61d2030984f7142847037d.1616141556.git.huangy81@chinatelecom.cn>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 554be84b32..670132f7fe 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2727,6 +2727,7 @@ F: tests/vmstate-static-checker-data/
 F: tests/qtest/migration-test.c
 F: docs/devel/migration.rst
 F: qapi/migration.json
+F: tests/migration/
 
 D-Bus
 M: Marc-André Lureau <marcandre.lureau@redhat.com>
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 02/13] MAINTAINERS: add/replace backups for some s390 areas
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
  2021-04-01 13:12 ` [PULL 01/13] MAINTAINERS: Fix tests/migration maintainers Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 03/13] MAINTAINERS: Drop the lines with Sarah Harris Thomas Huth
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell
  Cc: Jason J . Herne, Eric Farman, Matthew Rosato, Pierre Morel,
	Halil Pasic, Christian Borntraeger

From: Matthew Rosato <mjrosato@linux.ibm.com>

S390 PCI currently has no backup, add one.  Add an additional backup
for vfio-ccw and refresh the backup for vfio-ap.

Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Acked-by: Jason J. Herne <jjherne@linux.ibm.com>
Acked-by: Eric Farman <farman@linux.ibm.com>
Acked-by: Pierre Morel <pmorel@linux.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Message-Id: <1616680509-8339-1-git-send-email-mjrosato@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 670132f7fe..fcd8da53ae 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1516,6 +1516,7 @@ L: qemu-s390x@nongnu.org
 
 S390 PCI
 M: Matthew Rosato <mjrosato@linux.ibm.com>
+M: Eric Farman <farman@linux.ibm.com>
 S: Supported
 F: hw/s390x/s390-pci*
 F: include/hw/s390x/s390-pci*
@@ -1830,6 +1831,7 @@ F: docs/igd-assign.txt
 vfio-ccw
 M: Cornelia Huck <cohuck@redhat.com>
 M: Eric Farman <farman@linux.ibm.com>
+M: Matthew Rosato <mjrosato@linux.ibm.com>
 S: Supported
 F: hw/vfio/ccw.c
 F: hw/s390x/s390-ccw.c
@@ -1839,10 +1841,9 @@ T: git https://gitlab.com/cohuck/qemu.git s390-next
 L: qemu-s390x@nongnu.org
 
 vfio-ap
-M: Christian Borntraeger <borntraeger@de.ibm.com>
 M: Tony Krowiak <akrowiak@linux.ibm.com>
 M: Halil Pasic <pasic@linux.ibm.com>
-M: Pierre Morel <pmorel@linux.ibm.com>
+M: Jason Herne <jjherne@linux.ibm.com>
 S: Supported
 F: hw/s390x/ap-device.c
 F: hw/s390x/ap-bridge.c
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 03/13] MAINTAINERS: Drop the lines with Sarah Harris
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
  2021-04-01 13:12 ` [PULL 01/13] MAINTAINERS: Fix tests/migration maintainers Thomas Huth
  2021-04-01 13:12 ` [PULL 02/13] MAINTAINERS: add/replace backups for some s390 areas Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 04/13] MAINTAINERS: replace Huawei's email to personal one Thomas Huth
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell; +Cc: Sarah Harris

In a mail to the qemu-devel mailing list, Sarah wrote:

"I was added as a reviewer (in MAINTAINERS) for the AVR target for the
 duration of my research work using it.
 The funding for my project expires in the middle of April, so I will not be
 able to provide time for reviewing patches from that point."

Thus let's remove the corresponding lines in the MAINTAINERS file.

Message-Id: <20210401062426.3192118-1-thuth@redhat.com>
Reviewed-by: Sarah Harris <S.E.Harris@kent.ac.uk>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fcd8da53ae..0abe6182e5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -174,7 +174,6 @@ F: include/hw/arm/smmu*
 
 AVR TCG CPUs
 M: Michael Rolnik <mrolnik@gmail.com>
-R: Sarah Harris <S.E.Harris@kent.ac.uk>
 S: Maintained
 F: docs/system/target-avr.rst
 F: gdb-xml/avr-cpu.xml
@@ -1045,7 +1044,6 @@ AVR Machines
 
 AVR MCUs
 M: Michael Rolnik <mrolnik@gmail.com>
-R: Sarah Harris <S.E.Harris@kent.ac.uk>
 S: Maintained
 F: default-configs/*/avr-softmmu.mak
 F: hw/avr/
@@ -1058,7 +1056,6 @@ F: hw/misc/avr_power.c
 
 Arduino
 M: Philippe Mathieu-Daudé <f4bug@amsat.org>
-R: Sarah Harris <S.E.Harris@kent.ac.uk>
 S: Maintained
 F: hw/avr/arduino.c
 
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 04/13] MAINTAINERS: replace Huawei's email to personal one
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (2 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 03/13] MAINTAINERS: Drop the lines with Sarah Harris Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 05/13] MAINTAINERS: Drop the line with Xiang Zheng Thomas Huth
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell; +Cc: Dongjiu Geng

From: Dongjiu Geng <gengdongjiu1@gmail.com>

In order to conveniently receive email, replace the Huawei
email address with my personal one.

Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
Message-Id: <1615462144-10864-1-git-send-email-gengdongjiu1@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0abe6182e5..4dab272320 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1725,7 +1725,7 @@ F: tests/qtest/acpi-utils.[hc]
 F: tests/data/acpi/
 
 ACPI/HEST/GHES
-R: Dongjiu Geng <gengdongjiu@huawei.com>
+R: Dongjiu Geng <gengdongjiu1@gmail.com>
 R: Xiang Zheng <zhengxiang9@huawei.com>
 L: qemu-arm@nongnu.org
 S: Maintained
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 05/13] MAINTAINERS: Drop the line with Xiang Zheng
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (3 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 04/13] MAINTAINERS: replace Huawei's email to personal one Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 06/13] MAINTAINERS: add virtio-fs mailing list Thomas Huth
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell

When sending a mail with CC: to zhengxiang9@huawei.com I got a mail
back saying:

 Your message couldn't be delivered

 The message you sent to zhengxiang9@huawei.com couldn't be delivered due to:
 Recipient email address is possibly incorrect.

 Further information

 5.1.1 <zhengxiang9@huawei.com>: Recipient address rejected: Failed recipient
 validation check.: host 127.0.0.1[127.0.0.1] said: 554 5.7.1 recipient verify
 from ldap failed (in reply to RCPT TO command)

Looks like this address does not exist anymore, thus drop it from the
MAINTAINERS file.

Message-Id: <20210401065343.3197791-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4dab272320..f237ea313d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1726,7 +1726,6 @@ F: tests/data/acpi/
 
 ACPI/HEST/GHES
 R: Dongjiu Geng <gengdongjiu1@gmail.com>
-R: Xiang Zheng <zhengxiang9@huawei.com>
 L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/acpi/ghes.c
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 06/13] MAINTAINERS: add virtio-fs mailing list
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (4 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 05/13] MAINTAINERS: Drop the line with Xiang Zheng Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 07/13] MAINTAINERS: Mark RX hardware emulation orphan Thomas Huth
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell
  Cc: Connor Kuehl, Dr . David Alan Gilbert, Stefan Hajnoczi, Vivek Goyal

From: Connor Kuehl <ckuehl@redhat.com>

General discussion and patch reviews take place on this list for both
virtiofsd (tools/virtiofsd/*) and the guest kernel module.

Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20210318154157.1357224-1-ckuehl@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f237ea313d..155c7995d4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1916,6 +1916,7 @@ F: tools/virtiofsd/*
 F: hw/virtio/vhost-user-fs*
 F: include/hw/virtio/vhost-user-fs.h
 F: docs/tools/virtiofsd.rst
+L: virtio-fs@redhat.com
 
 virtio-input
 M: Gerd Hoffmann <kraxel@redhat.com>
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 07/13] MAINTAINERS: Mark RX hardware emulation orphan
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (5 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 06/13] MAINTAINERS: add virtio-fs mailing list Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 08/13] MAINTAINERS: Mark SH-4 " Thomas Huth
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell
  Cc: Richard Henderson, Philippe Mathieu-Daudé, Yoshinori Sato

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Yoshinori Sato doesn't have time to manage QEMU reviews.

The code is in good shape and hasn't started to bitrot,
so mark the RX target and hardware as orphan to give the
possibility to any contributor to step in and fill the gap.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20210312155513.1849109-2-f4bug@amsat.org>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 155c7995d4..0a857f6b18 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -307,8 +307,8 @@ F: linux-user/host/riscv32/
 F: linux-user/host/riscv64/
 
 RENESAS RX CPUs
-M: Yoshinori Sato <ysato@users.sourceforge.jp>
-S: Odd Fixes
+R: Yoshinori Sato <ysato@users.sourceforge.jp>
+S: Orphan
 F: target/rx/
 
 S390 TCG CPUs
@@ -1405,8 +1405,8 @@ F: include/hw/*/*sifive*.h
 RX Machines
 -----------
 rx-gdbsim
-M: Yoshinori Sato <ysato@users.sourceforge.jp>
-S: Odd Fixes
+R: Yoshinori Sato <ysato@users.sourceforge.jp>
+S: Orphan
 F: docs/system/target-rx.rst
 F: hw/rx/rx-gdbsim.c
 F: tests/acceptance/machine_rx_gdbsim.py
@@ -2193,8 +2193,8 @@ F: include/hw/sh4/sh.h
 F: include/hw/timer/renesas_*.h
 
 Renesas RX peripherals
-M: Yoshinori Sato <ysato@users.sourceforge.jp>
-S: Odd Fixes
+R: Yoshinori Sato <ysato@users.sourceforge.jp>
+S: Orphan
 F: hw/intc/rx_icu.c
 F: hw/rx/
 F: include/hw/intc/rx_icu.h
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 08/13] MAINTAINERS: Mark SH-4 hardware emulation orphan
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (6 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 07/13] MAINTAINERS: Mark RX hardware emulation orphan Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 09/13] qom: Fix default values in help Thomas Huth
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell
  Cc: Richard Henderson, Magnus Damm, Philippe Mathieu-Daudé,
	Aurelien Jarno, Yoshinori Sato

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Yoshinori Sato doesn't have time to manage QEMU reviews.

The code is in good shape and hasn't started to bitrot,
so mark the SH-4 hardware as orphan to give the possibility
to any contributor to step in and fill the gap.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
CC: Magnus Damm <magnus.damm@gmail.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20210312155513.1849109-3-f4bug@amsat.org>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0a857f6b18..d73a92c992 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -322,8 +322,8 @@ F: tests/tcg/s390x/
 L: qemu-s390x@nongnu.org
 
 SH4 TCG CPUs
-M: Yoshinori Sato <ysato@users.sourceforge.jp>
-S: Odd Fixes
+R: Yoshinori Sato <ysato@users.sourceforge.jp>
+S: Orphan
 F: target/sh4/
 F: hw/sh4/
 F: disas/sh4.c
@@ -1414,7 +1414,7 @@ F: tests/acceptance/machine_rx_gdbsim.py
 SH4 Machines
 ------------
 R2D
-M: Yoshinori Sato <ysato@users.sourceforge.jp>
+R: Yoshinori Sato <ysato@users.sourceforge.jp>
 R: Magnus Damm <magnus.damm@gmail.com>
 S: Odd Fixes
 F: hw/char/sh_serial.c
@@ -1425,7 +1425,7 @@ F: hw/timer/sh_timer.c
 F: include/hw/sh4/sh_intc.h
 
 Shix
-M: Yoshinori Sato <ysato@users.sourceforge.jp>
+R: Yoshinori Sato <ysato@users.sourceforge.jp>
 R: Magnus Damm <magnus.damm@gmail.com>
 S: Odd Fixes
 F: hw/block/tc58128.c
@@ -2181,7 +2181,7 @@ F: include/hw/*/*xive*
 F: docs/*/*xive*
 
 Renesas peripherals
-M: Yoshinori Sato <ysato@users.sourceforge.jp>
+R: Yoshinori Sato <ysato@users.sourceforge.jp>
 R: Magnus Damm <magnus.damm@gmail.com>
 S: Odd Fixes
 F: hw/char/renesas_sci.c
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 09/13] qom: Fix default values in help
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (7 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 08/13] MAINTAINERS: Mark SH-4 " Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 10/13] util/compatfd.c: Fixed style issues Thomas Huth
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell; +Cc: Marc-André Lureau, Markus Armbruster

From: Markus Armbruster <armbru@redhat.com>

Output of default values in device help is broken:

    $ ./qemu-system-x86_64 -S -display none -monitor stdio
    QEMU 5.2.50 monitor - type 'help' for more information
    (qemu) device_add pvpanic,help
    pvpanic options:
      events=<uint8>         -  (default: (null))
      ioport=<uint16>        -  (default: (null))
      pvpanic[0]=<child<qemu:memory-region>>

The "(null)" is glibc printing a null pointer.  Other systems crash
instead.  Having a help request crash a running VM can really spoil
your day.

Root cause is a botched replacement of qstring_free() by
g_string_free(): to get the string back, we need to pass true to the
former, but false to the latter.  Fix the argument.

Fixes: eab3a4678b07267c39e7290a6e9e7690b1d2a521
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210324084130.3986072-1-armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qom/object_interfaces.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index c3324b0f86..bd8a947a63 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -159,7 +159,7 @@ char *object_property_help(const char *name, const char *type,
     }
     if (defval) {
         g_autofree char *def_json = g_string_free(qobject_to_json(defval),
-                                                  true);
+                                                  false);
         g_string_append_printf(str, " (default: %s)", def_json);
     }
 
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 10/13] util/compatfd.c: Fixed style issues
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (8 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 09/13] qom: Fix default values in help Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 11/13] docs: Remove obsolete paragraph about config-target.mak Thomas Huth
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell; +Cc: Mahmoud Mandour

From: Mahmoud Mandour <ma.mandourr@gmail.com>

Fixed two styling issues that caused checkpatch.pl errors.

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210315105814.5188-2-ma.mandourr@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 util/compatfd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/util/compatfd.c b/util/compatfd.c
index ee47dd8089..174f394533 100644
--- a/util/compatfd.c
+++ b/util/compatfd.c
@@ -20,8 +20,7 @@
 #include <sys/syscall.h>
 #endif
 
-struct sigfd_compat_info
-{
+struct sigfd_compat_info {
     sigset_t mask;
     int fd;
 };
@@ -53,8 +52,9 @@ static void *sigwait_compat(void *opaque)
 
                 len = write(info->fd, (char *)&buffer + offset,
                             sizeof(buffer) - offset);
-                if (len == -1 && errno == EINTR)
+                if (len == -1 && errno == EINTR) {
                     continue;
+                }
 
                 if (len <= 0) {
                     return NULL;
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 11/13] docs: Remove obsolete paragraph about config-target.mak
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (9 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 10/13] util/compatfd.c: Fixed style issues Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 12/13] docs: Fix typo in the default name of the qemu-system-x86_64 binary Thomas Huth
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell

$TARGET-NAME/config-target.mak has been removed a while ago.
Remove it now from the documentation, too.

Fixes: fdb75aeff7 ("configure: remove target configuration")
Message-Id: <20210316124208.455456-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 docs/devel/build-system.rst | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
index 69ce3087e3..7ef36f42d0 100644
--- a/docs/devel/build-system.rst
+++ b/docs/devel/build-system.rst
@@ -426,14 +426,6 @@ Built by configure:
   build outputs. Variables which are potentially different for each
   emulator target are defined by the next file...
 
-`$TARGET-NAME/config-target.mak`
-  TARGET-NAME is the name of a system or userspace emulator, for example,
-  x86_64-softmmu denotes the system emulator for the x86_64 architecture.
-  This file contains the variables which need to vary on a per-target
-  basis. For example, it will indicate whether KVM or Xen are enabled for
-  the target and any other potential custom libraries needed for linking
-  the target.
-
 
 Built by Meson:
 
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 12/13] docs: Fix typo in the default name of the qemu-system-x86_64 binary
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (10 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 11/13] docs: Remove obsolete paragraph about config-target.mak Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-01 13:12 ` [PULL 13/13] device-crash-test: Ignore errors about a bus not being available Thomas Huth
  2021-04-02 10:52 ` [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Peter Maydell
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell; +Cc: Philippe Mathieu-Daudé

It's a '-' between 'qemu' and 'system', not a '_'.

Fixes: 324b2298fe ("docs/system: convert Texinfo documentation to rST")
Message-Id: <20210401051829.3169438-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 docs/defs.rst.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/defs.rst.inc b/docs/defs.rst.inc
index 48d05aaf33..52d6454b93 100644
--- a/docs/defs.rst.inc
+++ b/docs/defs.rst.inc
@@ -10,6 +10,6 @@
    incorrectly in boldface.
 
 .. |qemu_system| replace:: qemu-system-x86_64
-.. |qemu_system_x86| replace:: qemu_system-x86_64
+.. |qemu_system_x86| replace:: qemu-system-x86_64
 .. |I2C| replace:: I\ :sup:`2`\ C
 .. |I2S| replace:: I\ :sup:`2`\ S
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PULL 13/13] device-crash-test: Ignore errors about a bus not being available
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (11 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 12/13] docs: Fix typo in the default name of the qemu-system-x86_64 binary Thomas Huth
@ 2021-04-01 13:12 ` Thomas Huth
  2021-04-02 10:52 ` [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Peter Maydell
  13 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2021-04-01 13:12 UTC (permalink / raw)
  To: qemu-devel, Peter Maydell; +Cc: John Snow

Recent QEMU versions now sometimes exit cleanly with an error message
that a bus is not available for a specified device. Don't flag those
as an error in the device-crash-test script.

Message-Id: <20210323164718.1393792-1-thuth@redhat.com>
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 scripts/device-crash-test | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index 6d809ac711..8331c057b8 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -175,6 +175,7 @@ ERROR_RULE_LIST = [
     {'log':r"Multiple VT220 operator consoles are not supported"},
     {'log':r"core 0 already populated"},
     {'log':r"could not find stage1 bootloader"},
+    {'log':r"No '.*' bus found for device"},
 
     # other exitcode=1 failures not listed above will just generate INFO messages:
     {'exitcode':1, 'loglevel':logging.INFO},
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes
  2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
                   ` (12 preceding siblings ...)
  2021-04-01 13:12 ` [PULL 13/13] device-crash-test: Ignore errors about a bus not being available Thomas Huth
@ 2021-04-02 10:52 ` Peter Maydell
  13 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2021-04-02 10:52 UTC (permalink / raw)
  To: Thomas Huth; +Cc: QEMU Developers

On Thu, 1 Apr 2021 at 14:12, Thomas Huth <thuth@redhat.com> wrote:
>
>  Hi Peter,
>
> the following changes since commit 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5:
>
>   Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.0-20210331' into staging (2021-03-31 13:14:18 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/thuth/qemu.git tags/pull-request-2021-04-01
>
> for you to fetch changes up to ca89d15f8e42f2e5eac5bd200af38fdbfb32e875:
>
>   device-crash-test: Ignore errors about a bus not being available (2021-04-01 14:28:39 +0200)
>
> ----------------------------------------------------------------
> * Updates for the MAINTAINERS file
> * Some small documentation updates
> * Some small misc fixes


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-04-02 10:54 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 13:12 [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Thomas Huth
2021-04-01 13:12 ` [PULL 01/13] MAINTAINERS: Fix tests/migration maintainers Thomas Huth
2021-04-01 13:12 ` [PULL 02/13] MAINTAINERS: add/replace backups for some s390 areas Thomas Huth
2021-04-01 13:12 ` [PULL 03/13] MAINTAINERS: Drop the lines with Sarah Harris Thomas Huth
2021-04-01 13:12 ` [PULL 04/13] MAINTAINERS: replace Huawei's email to personal one Thomas Huth
2021-04-01 13:12 ` [PULL 05/13] MAINTAINERS: Drop the line with Xiang Zheng Thomas Huth
2021-04-01 13:12 ` [PULL 06/13] MAINTAINERS: add virtio-fs mailing list Thomas Huth
2021-04-01 13:12 ` [PULL 07/13] MAINTAINERS: Mark RX hardware emulation orphan Thomas Huth
2021-04-01 13:12 ` [PULL 08/13] MAINTAINERS: Mark SH-4 " Thomas Huth
2021-04-01 13:12 ` [PULL 09/13] qom: Fix default values in help Thomas Huth
2021-04-01 13:12 ` [PULL 10/13] util/compatfd.c: Fixed style issues Thomas Huth
2021-04-01 13:12 ` [PULL 11/13] docs: Remove obsolete paragraph about config-target.mak Thomas Huth
2021-04-01 13:12 ` [PULL 12/13] docs: Fix typo in the default name of the qemu-system-x86_64 binary Thomas Huth
2021-04-01 13:12 ` [PULL 13/13] device-crash-test: Ignore errors about a bus not being available Thomas Huth
2021-04-02 10:52 ` [PULL 00/13] Updates to MAINTAINERS, docs, and some small fixes Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).