qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, lekiravi@yandex-team.ru
Cc: Jason Wang <jasowang@redhat.com>
Subject: [PATCH 0/5] Revert query-netdev command for 6.0
Date: Fri,  2 Apr 2021 16:15:14 +0800	[thread overview]
Message-ID: <20210402081519.78878-1-jasowang@redhat.com> (raw)

Hi All:

Several issues has been reported for query-netdev command:

- coverity warnings of memory leak and cut-and-paste issue
- lacking of documentation for future new netdev development

Consider it's late in the rc, I would like to revert this series and
let's retry for 6.1.

Thanks

Jason Wang (5):
  Revert "net: Do not fill legacy info_str for backends"
  Revert "hmp: Use QAPI NetdevInfo in hmp_info_network"
  Revert "net: Move NetClientState.info_str to dynamic allocations"
  Revert "tests: Add tests for query-netdev command"
  Revert "qapi: net: Add query-netdev command"

 hw/net/xen_nic.c                  |   5 +-
 include/net/net.h                 |   5 +-
 include/qapi/hmp-output-visitor.h |  30 -----
 net/l2tpv3.c                      |   8 +-
 net/net.c                         |  73 ++---------
 net/netmap.c                      |   7 --
 net/slirp.c                       | 124 +------------------
 net/socket.c                      |  92 ++++----------
 net/tap-win32.c                   |  10 +-
 net/tap.c                         | 107 ++---------------
 net/vde.c                         |  25 +---
 net/vhost-user.c                  |  20 +---
 net/vhost-vdpa.c                  |  15 +--
 qapi/hmp-output-visitor.c         | 193 ------------------------------
 qapi/meson.build                  |   1 -
 qapi/net.json                     |  80 -------------
 tests/qtest/meson.build           |   3 -
 tests/qtest/test-query-netdev.c   | 120 -------------------
 18 files changed, 62 insertions(+), 856 deletions(-)
 delete mode 100644 include/qapi/hmp-output-visitor.h
 delete mode 100644 qapi/hmp-output-visitor.c
 delete mode 100644 tests/qtest/test-query-netdev.c

-- 
2.24.3 (Apple Git-128)



             reply	other threads:[~2021-04-02  8:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  8:15 Jason Wang [this message]
2021-04-02  8:15 ` [PATCH 1/5] Revert "net: Do not fill legacy info_str for backends" Jason Wang
2021-04-02  8:15 ` [PATCH 2/5] Revert "hmp: Use QAPI NetdevInfo in hmp_info_network" Jason Wang
2021-04-02  8:15 ` [PATCH 3/5] Revert "net: Move NetClientState.info_str to dynamic allocations" Jason Wang
2021-04-02  9:00   ` Jason Wang
2021-04-02  8:15 ` [PATCH 4/5] Revert "tests: Add tests for query-netdev command" Jason Wang
2021-04-02  8:15 ` [PATCH 5/5] Revert "qapi: net: Add " Jason Wang
2021-04-06  4:05 ` [PATCH 0/5] Revert query-netdev command for 6.0 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210402081519.78878-1-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=lekiravi@yandex-team.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).