From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A1BEC433ED for ; Tue, 6 Apr 2021 14:41:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67A99613BC for ; Tue, 6 Apr 2021 14:41:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67A99613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bu.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTmtm-0000mw-DE for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 10:41:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmsV-0008U3-W4 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 10:40:28 -0400 Received: from relay64.bu.edu ([128.197.228.104]:38894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmsU-0001R6-AC for qemu-devel@nongnu.org; Tue, 06 Apr 2021 10:40:27 -0400 X-Envelope-From: alxndr@bu.edu X-BU-AUTH: mozz.bu.edu [128.197.127.33] Received: from BU-AUTH (localhost.localdomain [127.0.0.1]) (authenticated bits=0) by relay64.bu.edu (8.14.3/8.14.3) with ESMTP id 136EdnPb015559 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Tue, 6 Apr 2021 10:39:53 -0400 Date: Tue, 6 Apr 2021 10:39:49 -0400 From: Alexander Bulekov To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH-for-6.0] hw/mem/meson: Fix linking sparse-mem device with fuzzer Message-ID: <20210406143928.shfhgsdupbjqgohc@mozz.bu.edu> References: <20210406133944.4193691-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210406133944.4193691-1-philmd@redhat.com> Received-SPF: pass client-ip=128.197.228.104; envelope-from=alxndr@bu.edu; helo=relay64.bu.edu X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Darren Kenny , Paolo Bonzini , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 210406 1539, Philippe Mathieu-Daudé wrote: > sparse-mem.c is added to the 'mem_ss' source set, which itself > is conditionally added to softmmu_ss if CONFIG_MEM_DEVICE is > selected. > But if CONFIG_MEM_DEVICE isn't selected, we get a link failure > even if CONFIG_FUZZ is selected: > > /usr/bin/ld: tests_qtest_fuzz_generic_fuzz.c.o: in function `generic_pre_fuzz': > tests/qtest/fuzz/generic_fuzz.c:826: undefined reference to `sparse_mem_init' > clang-10: error: linker command failed with exit code 1 (use -v to see invocation) > > Fix by adding sparse-mem.c directly to the softmmu_ss set. > > Fixes: 230376d285b ("memory: add a sparse memory device for fuzzing") > Signed-off-by: Philippe Mathieu-Daudé Oops.. Reviewed-by: Alexander Bulekov > --- > hw/mem/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/mem/meson.build b/hw/mem/meson.build > index ef79e046787..3c8fdef9f9e 100644 > --- a/hw/mem/meson.build > +++ b/hw/mem/meson.build > @@ -1,8 +1,9 @@ > mem_ss = ss.source_set() > mem_ss.add(files('memory-device.c')) > -mem_ss.add(when: 'CONFIG_FUZZ', if_true: files('sparse-mem.c')) > mem_ss.add(when: 'CONFIG_DIMM', if_true: files('pc-dimm.c')) > mem_ss.add(when: 'CONFIG_NPCM7XX', if_true: files('npcm7xx_mc.c')) > mem_ss.add(when: 'CONFIG_NVDIMM', if_true: files('nvdimm.c')) > > softmmu_ss.add_all(when: 'CONFIG_MEM_DEVICE', if_true: mem_ss) > + > +softmmu_ss.add(when: 'CONFIG_FUZZ', if_true: files('sparse-mem.c')) > -- > 2.26.3 > >