From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8540BC433B4 for ; Tue, 6 Apr 2021 15:13:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DB43611C1 for ; Tue, 6 Apr 2021 15:13:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DB43611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTnOX-0003Bf-0C for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 11:13:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTnCZ-0006hY-C4 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 11:01:11 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:51731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTnCX-0005Hi-J2 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 11:01:11 -0400 Received: by mail-wm1-x333.google.com with SMTP id p19so7540311wmq.1 for ; Tue, 06 Apr 2021 08:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1ZWLMlQokbn+ytm36tLs/g7l/rfbZT4dElLqTmVGEvY=; b=t5CMIakZ15gFy9GFcx/hZRKyfa6ytzlvJUCeJJXCU+idYrAJIODyCKWGz96fSxQ9hO YZK4FXJ+SWbdKthuqWlT70vV7oONCu3TZorR/hUSv7Ezgkb6l4VwcyZ29i6KaXkYvMtR K0nYG+EudOYRpd2NTUF5wlFBqA8QZEStcKvtCxRL7I1SaJyGgFw3zfiwwQclUrfNFsp4 jaPLWrvll+nRdqwEZh83JtEH8pGRox0jpk5AkM5A+pPk2PevZWHrGPzDnMDH5dWxe1+k 5zEyFP9TWF1zWbf7VbjRWaSL/mZhtr5RBmwV9hpQ5m6CznEuQAq07Dc2vrPgKjIzup1O v5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1ZWLMlQokbn+ytm36tLs/g7l/rfbZT4dElLqTmVGEvY=; b=mpSolGfqyn+s5mC2rwXRjxHB81r5o1eOZmbVm2KM8NwOk1GMJdoQ8b68y3BmaSe30d J83ZnHYX+71ezYSvnwhsW/1Smikjs97Txs1XZuY8RqigwcB4x7mJEDj7rnaZqeoNlLdz zYERF7V6JhX1d8uT10mj3zwdrdz23w2VpTILoGjwATksli0M/2uajV3yIr2jQ0uZnY5+ xCbf08ov1icud2iDEvQfkxosaDUTarWSIzmgCw6MZRnhlcRitot+YpKMaeQqgaKoUXcG ouvAwculmocnOk6CteAWqWV74mkU3wQTr6gH5AJUqWBoIbEThpRaX4K+q4D4/ddzQa2Q vxDw== X-Gm-Message-State: AOAM533UmJfAP+nui2kDrVzegnvVG69zwBVIrx/aXhI/imfwYEcwEySG XMN0gYuAI5Xa/7U9FdQaMf+uxA== X-Google-Smtp-Source: ABdhPJykDIc3xJZ/X3i0Isch2L+uNgTDcl+NOBXGCXBmKy3LI7sqcaOsM8FHB/m0wkBOkdZFEJdyPw== X-Received: by 2002:a7b:c188:: with SMTP id y8mr4507569wmi.76.1617721268174; Tue, 06 Apr 2021 08:01:08 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u19sm3028804wml.28.2021.04.06.08.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 08:00:50 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A98F11FF93; Tue, 6 Apr 2021 16:00:42 +0100 (BST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 07/11] tests/tcg: relax the next step precision of the gdb sha1 test Date: Tue, 6 Apr 2021 16:00:37 +0100 Message-Id: <20210406150041.28753-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210406150041.28753-1-alex.bennee@linaro.org> References: <20210406150041.28753-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Depending on the version of gdb we may not execute the first line of SHA1Init when executing the first "next" command - instead just stepping over the preamble. As we don't actually care about the position of the PC after the steps and want to be sure the context->state[] has been loaded before we inspect it do a double next at the start. Signed-off-by: Alex Bennée Tested-by: Richard Henderson Message-Id: <20210401102530.12030-8-alex.bennee@linaro.org> diff --git a/tests/tcg/multiarch/gdbstub/sha1.py b/tests/tcg/multiarch/gdbstub/sha1.py index 2bfde49633..423b720e6d 100644 --- a/tests/tcg/multiarch/gdbstub/sha1.py +++ b/tests/tcg/multiarch/gdbstub/sha1.py @@ -40,7 +40,10 @@ def run_test(): check_break("SHA1Init") - # check step and inspect values + # Check step and inspect values. We do a double next after the + # breakpoint as depending on the version of gdb we may step the + # preamble and not the first actual line of source. + gdb.execute("next") gdb.execute("next") val_ctx = gdb.parse_and_eval("context->state[0]") exp_ctx = 0x67452301 -- 2.20.1