From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE91EC433ED for ; Tue, 6 Apr 2021 18:36:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43FA8613BE for ; Tue, 6 Apr 2021 18:36:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43FA8613BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTqZI-0007m2-D9 for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 14:36:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTqYb-00077v-8f; Tue, 06 Apr 2021 14:36:09 -0400 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:35371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTqYY-00039w-7Z; Tue, 06 Apr 2021 14:36:08 -0400 Received: by mail-oi1-x230.google.com with SMTP id x2so16141526oiv.2; Tue, 06 Apr 2021 11:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=3IS0GqaJSzAj4m16iIli26RhfNK+rV7qKAAnWkRlDcg=; b=XKIKaiWSQaD1P3OVmCV5wYhk11BvrURT62OMWW4tCFc6dE9VIJexBF/Lqq3ZSdEYs/ Tzuo2OcAfBri6eREkjiCn1T2MovDpTHO/DhTDlbLBIskHAygtJhk978jt1bgVqo/6CSJ E8dEDj3nYd49E7KRyohCQeZULsbtrCGZQOAS8yeMHwDNZ3QQ7wZzpaF5SJyqhO/v1aNG l6IsdSRyMZI68C5wcGca78XCz0xonRpcBKtZb61iW+hrHcTfTbLxrbiTbJjblb2mt/6a o7u592B0OkcVUncpMZfacsbWOvIKMF+hb42yYFC2d4U2DMNj4cCvvsWmyUO07QF7UcY9 wkjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=3IS0GqaJSzAj4m16iIli26RhfNK+rV7qKAAnWkRlDcg=; b=kKndriqicYjeG8TLaS+1DLLobkgnti270mwjrd8BxHS+BjaZgiLTabD5hR6B/Lm+Os p+WdcbeHZiNL7mwm2MGrB3rdolUR4sdSwUAV53ZiCJliexuPIYGg+/rbIWP9ScPYebJ9 arWPupF8u7M2K87XxkWNxZHqtSIkNk5aKcFBfOy3VFzxAaz8NPx9TzkVJmapJFxZlyzl piWgBcoqoV82pEUDfvSO+esrh1hoPCb9baDy+u918JfZ+vl8K0/MUtStIRv/iQsuQzU2 3zK1E2JcwW9tujWqwD0AL7TVvdnbu6frKARslYOc+MOrU1SNNfzq9fS7bnjAL/28d7Ei 7I+g== X-Gm-Message-State: AOAM530lLTLvNo9n0VdfTg3oQTDaesdJogvXXml8kbWG9SOuhIxQ+jOw UyCClIvNjC8izKh3fxoT7Q== X-Google-Smtp-Source: ABdhPJx/jSWmbMfCu0DuWtHtDtMZutA0BAHXp/mQAKEvL8Q9unOPAqYI7inVJTNqACDaT3uskiZH+g== X-Received: by 2002:aca:1a19:: with SMTP id a25mr4249475oia.167.1617734164307; Tue, 06 Apr 2021 11:36:04 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id a128sm3845275oib.7.2021.04.06.11.36.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 11:36:03 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:f584:ff80:e7e9:e850]) by serve.minyard.net (Postfix) with ESMTPSA id D00FE180052; Tue, 6 Apr 2021 18:36:02 +0000 (UTC) Date: Tue, 6 Apr 2021 13:36:01 -0500 From: Corey Minyard To: Patrick Venture Subject: Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device Message-ID: <20210406183601.GB7166@minyard.net> References: <20210403222810.3481372-1-venture@google.com> <20210405195834.GF7167@minyard.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=tcminyard@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: Hao Wu , cminyard@mvista.com, qemu-arm@nongnu.org, Havard Skinnemoen , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Apr 06, 2021 at 08:55:14AM -0700, Patrick Venture wrote: > On Tue, Apr 6, 2021 at 8:41 AM Patrick Venture wrote: > > > > On Mon, Apr 5, 2021 at 12:58 PM Corey Minyard wrote: > > > > > > On Sat, Apr 03, 2021 at 03:28:08PM -0700, Patrick Venture wrote: > > > > The i2c mux device pca954x implements two devices: > > > > - the pca9546 and pca9548. > > > > > > > > Patrick Venture (2): > > > > hw/i2c/core: add reachable state boolean > > > > hw/i2c: add pca954x i2c-mux switch > > > > > > Looking this over, the code looks good, but I have a few general > > > questions: > > > > > > * Can you register the same slave address on different channels? That's > > > something you could do with real hardware and might be required at > > > some time. It looks like to me that you can't with this patch set, > > > but maybe I'm missing something. > > > > If I understand the hardware's implementation properly you can have > > collisions, and this allows for collisions. I'm not sure what you > > mean by having both accessible. For instance, on hardware you can > > have a switch with N channels, and on two of the channels there is an > > eeprom at 50. But you're unable to talk to both eeproms at the same > > time, because the addresses collide -- so how would the hardware know > > which you're talking to? My understanding of the behavior in this > > collision case is that it just talks to the first one that responds > > and can lead to unexpected things. > > > > There is a board, the quanta-q71l where we had to set the > > idle-disconnect because there were two muxes on the same bus, with > > conflicting addresses, and so we had to use idle disconnect explicitly > > to make the software happy talking to the hardware -- not ideal as > > having two devices behind different channels, but ultimately it's the > > same idea because the devices are conflicting. > > > > > > > > * Can you add devices to the secondary I2C busses on the mux using the > > > standard QEMU device model, or is the function call required? > > > > I added the function call because I didn't see a clean way to bridge > > the issue as well as, the quasi-arbitrary bus numbering used by the > > kernel isn't how the hardware truly behaves, and my goal was to > > implement closer to the hardware. I thought about adding an I2cBus to > > the device and then you'd be able to access it, but wasn't sure of a > > nice clean way to plumb that through -- I considered adding/removing > > devices from the parent i2c bus instead of the boolean reachable, but > > that seemed way less clean - although do-able. > > > > > > > > I ask because I did a pca9540 and pca9541 device, but I've never > > > submitted it because I didn't think it would ever be needed. It takes a > > > different tack on the problem; it creates the secondary busses as > > > standard QEMU I2C busses and bridges them. You can see it at > > > > > > github.com:cminyard/qemu.git master-i2c-rebase > > > > > > > I'll have to take a look at your approach, but the idea that it > > wouldn't be needed sounds bizarre to me as nearly all BMC-based qemu > > boards leverage i2c muxes to handle their PCIe slot i2c routing. > > > > > If you design can do the things I ask, then it's better. If not, then > > > I'm not sure. > > Corey, > > looking at your design, I should be able to do something similar with > a small tweak. > > I think my design follows the hardware where there can be conflicts, > etc, but what I didn't know how to do was add the faux I2cBuses in a > useful way -- but if I add the I2cBuses to the device, and then on > add/remove it registers the device on the parent bus -- i can still > use the reachable boolean to control whether it's present. The faux > I2cBuses would be a simplification for adding/removing i2c devices -- > and would act as the device list in my object. So then setting the > channels would change to walking the devices held by the bus that > corresponds with the bit -- but _still_ using the reachable boolean. > > If you'd like, I can update my patchset to use an i2cbus for the > purpose above, then it would satisfy the requirement of leveraging the > normal device process and no longer require the special function call. That sounds reasonable. Your implementation is quite a bit simpler than mine, which is a bonus. -corey > > Patrick > > > > > > > -corey > > > > > > > > > > > MAINTAINERS | 6 + > > > > hw/i2c/Kconfig | 4 + > > > > hw/i2c/core.c | 6 + > > > > hw/i2c/i2c_mux_pca954x.c | 182 +++++++++++++++++++++++++++++++ > > > > hw/i2c/meson.build | 1 + > > > > hw/i2c/trace-events | 5 + > > > > include/hw/i2c/i2c.h | 3 + > > > > include/hw/i2c/i2c_mux_pca954x.h | 60 ++++++++++ > > > > 8 files changed, 267 insertions(+) > > > > create mode 100644 hw/i2c/i2c_mux_pca954x.c > > > > create mode 100644 include/hw/i2c/i2c_mux_pca954x.h > > > > > > > > -- > > > > 2.31.0.208.g409f899ff0-goog > > > > >