From: Stefano Garzarella <sgarzare@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Florian Florensa <fflorensa@online.net>,
Jason Dillaman <dillaman@redhat.com>
Subject: Re: [PATCH 1/2] block/rbd: fix memory leak in qemu_rbd_connect()
Date: Thu, 8 Apr 2021 09:49:46 +0200 [thread overview]
Message-ID: <20210408074946.kllbenurvccvy67z@steredhat> (raw)
In-Reply-To: <87im4zddq1.fsf@dusky.pond.sub.org>
On Tue, Apr 06, 2021 at 10:22:30AM +0200, Markus Armbruster wrote:
>Stefano Garzarella <sgarzare@redhat.com> writes:
>
>> In qemu_rbd_connect(), 'mon_host' is allocated by qemu_rbd_mon_host()
>> using g_strjoinv(), but it's only freed in the error path, leaking
>> memory in the success path as reported by valgrind:
>>
>> 80 bytes in 4 blocks are definitely lost in loss record 5,028 of 6,516
>> at 0x4839809: malloc (vg_replace_malloc.c:307)
>> by 0x5315BB8: g_malloc (in /usr/lib64/libglib-2.0.so.0.6600.8)
>> by 0x532B6FF: g_strjoinv (in /usr/lib64/libglib-2.0.so.0.6600.8)
>> by 0x87D07E: qemu_rbd_mon_host (rbd.c:538)
>> by 0x87D07E: qemu_rbd_connect (rbd.c:562)
>> by 0x87E1CE: qemu_rbd_open (rbd.c:740)
>> by 0x840EB1: bdrv_open_driver (block.c:1528)
>> by 0x8453A9: bdrv_open_common (block.c:1802)
>> by 0x8453A9: bdrv_open_inherit (block.c:3444)
>> by 0x8464C2: bdrv_open (block.c:3537)
>> by 0x8108CD: qmp_blockdev_add (blockdev.c:3569)
>> by 0x8EA61B: qmp_marshal_blockdev_add (qapi-commands-block-core.c:1086)
>> by 0x90B528: do_qmp_dispatch_bh (qmp-dispatch.c:131)
>> by 0x907EA4: aio_bh_poll (async.c:164)
>>
>> Fix freeing 'mon_host' also when qemu_rbd_connect() ends correctly.
>>
>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>
>I believe this
>Fixes: 0a55679b4a5061f4d74bdb1a0e81611ba3390b00
Yep :-)
>
>Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
Thanks,
Stefano
next prev parent reply other threads:[~2021-04-08 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 15:01 [PATCH 0/2] block/rbd: fix memory leaks Stefano Garzarella
2021-03-29 15:01 ` [PATCH 1/2] block/rbd: fix memory leak in qemu_rbd_connect() Stefano Garzarella
2021-04-06 8:22 ` Markus Armbruster
2021-04-08 7:49 ` Stefano Garzarella [this message]
2021-03-29 15:01 ` [PATCH 2/2] block/rbd: fix memory leak in qemu_rbd_co_create_opts() Stefano Garzarella
2021-04-06 8:23 ` Markus Armbruster
2021-04-06 17:06 ` [PATCH 0/2] block/rbd: fix memory leaks Max Reitz
2021-04-07 9:38 ` Markus Armbruster
2021-04-08 7:54 ` Stefano Garzarella
2021-04-07 13:31 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408074946.kllbenurvccvy67z@steredhat \
--to=sgarzare@redhat.com \
--cc=armbru@redhat.com \
--cc=dillaman@redhat.com \
--cc=fflorensa@online.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).