From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0E7C433B4 for ; Fri, 9 Apr 2021 09:12:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83A94610D0 for ; Fri, 9 Apr 2021 09:12:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83A94610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUnCA-0006Vk-Jf for qemu-devel@archiver.kernel.org; Fri, 09 Apr 2021 05:12:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUn9w-00049D-AQ for qemu-devel@nongnu.org; Fri, 09 Apr 2021 05:10:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUn9u-0002pz-PT for qemu-devel@nongnu.org; Fri, 09 Apr 2021 05:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617959433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NkZ9H95RYjrI1dMGeKVkrC7byv2jvAg6O4OLlkJVpFQ=; b=hE4MkOGwYn+IpdQrFIPPyfLSLuSccUIAxTeGs2kp0mNqQvdv5hB4o2mASJTcwY3BEdad+H VUs7nxUkDb3T3lOznxLG1sqQc1EV7h57WDQgKo3TfKin95e3RXjFhZ/khLQHpUZlaF31/k eVN4zDQLUrHHCbLKN4ji6c9HCq5jiXI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-119-imwdUcpgNoi_95GvNQcZSQ-1; Fri, 09 Apr 2021 05:10:28 -0400 X-MC-Unique: imwdUcpgNoi_95GvNQcZSQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4592F107ACF3 for ; Fri, 9 Apr 2021 09:10:27 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-165.ams2.redhat.com [10.36.114.165]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E0A460BE5; Fri, 9 Apr 2021 09:10:27 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9A624180039C; Fri, 9 Apr 2021 11:10:25 +0200 (CEST) Date: Fri, 9 Apr 2021 11:10:25 +0200 From: Gerd Hoffmann To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH v3 0/8] [RfC] fix tracing for modules Message-ID: <20210409091025.sht464kryv22cf3h@sirius.home.kraxel.org> References: <20210121125028.3247190-1-kraxel@redhat.com> <20210203163202.GF241524@stefanha-x1.localdomain> <20210222151332.vea6cszd4pwtkeno@sirius.home.kraxel.org> <20210326124700.taujcpo2xqbn2pzj@sirius.home.kraxel.org> <20210329094818.q4xtejd6labmb5gr@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" , Markus Armbruster , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > > semantic error: unresolved function pid: identifier 'pid' at /home/kraxel/qemu-install/share/systemtap/tapset/qemu-system-x86_64-log.stp:5451:41 > > source: printf("%d@%d qxl_soft_reset %d\n", pid(), gettimeofday_ns(), qid) > Hmm, strange, makes me think we have a bug causing it to not pull in > global functions. Yep. qemu-trace-stap sets SYSTEMTAP_TAPSET to /home/kraxel/qemu-install/share/systemtap/tapset. Which makes stap use that exclusively and ignore /usr/share/systemtap/tapset. Which in turn makes pid() disappear because that apparently is defined somewhere in those tapsets. IOW: It's broken for any $prefix != "/usr". Using stap -I /home/kraxel/qemu-install/share/systemtap/tapset seems to work fine, I guess qemu-trace-stap should use that instead ... take care, Gerd