From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 893AAC433ED for ; Fri, 9 Apr 2021 13:13:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4262561003 for ; Fri, 9 Apr 2021 13:13:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4262561003 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUqxB-0002li-FJ for qemu-devel@archiver.kernel.org; Fri, 09 Apr 2021 09:13:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUqwW-0001wK-98 for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:13:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUqwT-0004MQ-8Q for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:12:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617973975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sTB+aKIjoISjW12F4ZnN7v6ZTfFmS6KAJIEs19imlXA=; b=iA8uCl2MkA/xWN/ZbwjGFYVZRnB6mHXyoHXx/ZFkUmOvUljNwfXSWOtBfw3OzbTGXQCgzb AvGHvLwFthA5RYcfKjOqRhaDPV7VSrriGSZ6FTjJKPe2qLkK7R4MXxVO7RXoDrOanH+yqx Z103oOlACGrcmFl2wac6ZJwh0ENTJf8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-1yLTSmFUNwqREzozM_3L3Q-1; Fri, 09 Apr 2021 09:12:53 -0400 X-MC-Unique: 1yLTSmFUNwqREzozM_3L3Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3BBDB193578E for ; Fri, 9 Apr 2021 13:12:53 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-165.ams2.redhat.com [10.36.114.165]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D71519703; Fri, 9 Apr 2021 13:12:47 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EC75618000AB; Fri, 9 Apr 2021 15:12:45 +0200 (CEST) Date: Fri, 9 Apr 2021 15:12:45 +0200 From: Gerd Hoffmann To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH v3 0/8] [RfC] fix tracing for modules Message-ID: <20210409131245.oqeu4ooueazqfcir@sirius.home.kraxel.org> References: <20210121125028.3247190-1-kraxel@redhat.com> <20210203163202.GF241524@stefanha-x1.localdomain> <20210222151332.vea6cszd4pwtkeno@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Stefan Hajnoczi , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > eg a trace point "dma_map_wait" gets mapped to probes in many > .stp files, once per target, because we need to match based on > the executable path: > > probe qemu.system.x86_64.dma_map_wait = process("/usr/libexec/qemu-system-x86_64").mark("dma_map_wait") So, that changes with modules, we need the module name now, i.e. probe qemu.system.x86_64.qxl_soft_reset = \ process("/home/kraxel/qemu-install/lib/qemu/hw-display-qxl.so").mark("qxl_soft_reset") We could repeat that in every qemu-system-$arch.stp file. We could also have one stp file per module, with probes like this: probe qemu.modules.qxl_soft_reset = \ process("/home/kraxel/qemu-install/lib/qemu/hw-display-qxl.so").mark("qxl_soft_reset") The later looks like a better fit to me, but has the drawback that the tracepoints have different names in modular and non-modular builds ... take care, Gerd