From: Yanan Wang <wangyanan55@huawei.com>
To: <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>
Cc: Barry Song <song.bao.hua@hisilicon.com>,
Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
wanghaibin.wang@huawei.com, yangyicong@huawei.com,
Yanan Wang <wangyanan55@huawei.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
prime.zeng@hisilicon.com, Paolo Bonzini <pbonzini@redhat.com>,
yuzenghui@huawei.com, Igor Mammedov <imammedo@redhat.com>,
zhukeqian1@huawei.com, Jiajie Li <lijiajie11@huawei.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [RFC PATCH v2 3/4] hw/arm/virt-acpi-build: Add cluster level for PPTT table
Date: Tue, 13 Apr 2021 16:31:46 +0800 [thread overview]
Message-ID: <20210413083147.34236-4-wangyanan55@huawei.com> (raw)
In-Reply-To: <20210413083147.34236-1-wangyanan55@huawei.com>
Add a Processor Hierarchy Node of cluster level between core level
and package level for ARM PPTT table.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
---
hw/arm/virt-acpi-build.c | 55 ++++++++++++++++++++++++----------------
1 file changed, 33 insertions(+), 22 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 03fd812d5a..2b745711d1 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -443,6 +443,7 @@ build_pptt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
int pptt_start = table_data->len;
int uid = 0, cpus = 0, socket = 0;
MachineState *ms = MACHINE(vms);
+ unsigned int smp_clusters = vms->smp_clusters;
unsigned int smp_cores = ms->smp.cores;
unsigned int smp_threads = ms->smp.threads;
@@ -450,42 +451,52 @@ build_pptt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
for (socket = 0; cpus < ms->possible_cpus->len; socket++) {
uint32_t socket_offset = table_data->len - pptt_start;
- int core;
+ int cluster;
build_processor_hierarchy_node(
table_data, 1, /* Physical package */
0, socket, /* No parent */
NULL, 0); /* No private resources */
- for (core = 0; core < smp_cores; core++) {
- uint32_t core_offset = table_data->len - pptt_start;
- int thread;
-
- if (smp_threads <= 1) {
- build_processor_hierarchy_node(
- table_data,
- (1 << 1) | /* ACPI Processor ID valid */
- (1 << 3), /* ACPI 6.3 - Node is a Leaf */
- socket_offset, uid++, /* Parent is a Socket */
- NULL, 0); /* No private resources */
- } else {
- build_processor_hierarchy_node(
- table_data, 0,
- socket_offset, core, /* Parent is a Socket */
- NULL, 0); /* No private resources */
-
- for (thread = 0; thread < smp_threads; thread++) {
+ for (cluster = 0; cluster < smp_clusters; cluster++) {
+ uint32_t cluster_offset = table_data->len - pptt_start;
+ int core;
+
+ build_processor_hierarchy_node(
+ table_data, 0,
+ socket_offset, cluster, /* Parent is a Socket */
+ NULL, 0); /* No private resources */
+
+ for (core = 0; core < smp_cores; core++) {
+ uint32_t core_offset = table_data->len - pptt_start;
+ int thread;
+
+ if (smp_threads <= 1) {
build_processor_hierarchy_node(
table_data,
(1 << 1) | /* ACPI Processor ID valid */
- (1 << 2) | /* ACPI 6.3 - Processor is a Thread */
(1 << 3), /* ACPI 6.3 - Node is a Leaf */
- core_offset, uid++, /* Parent is a Core */
+ cluster_offset, uid++, /* Parent is a Cluster */
NULL, 0); /* No private resources */
+ } else {
+ build_processor_hierarchy_node(
+ table_data, 0,
+ cluster_offset, core, /* Parent is a Cluster */
+ NULL, 0); /* No private resources */
+
+ for (thread = 0; thread < smp_threads; thread++) {
+ build_processor_hierarchy_node(
+ table_data,
+ (1 << 1) | /* ACPI Processor ID valid */
+ (1 << 2) | /* ACPI 6.3 - Processor is a Thread */
+ (1 << 3), /* ACPI 6.3 - Node is a Leaf */
+ core_offset, uid++, /* Parent is a Core */
+ NULL, 0); /* No private resources */
+ }
}
}
}
- cpus += smp_cores * smp_threads;
+ cpus += smp_clusters * smp_cores * smp_threads;
}
build_header(linker, table_data,
--
2.19.1
next prev parent reply other threads:[~2021-04-13 8:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 8:31 [RFC PATCH v2 0/4] hw/arm/virt: Introduce cluster cpu topology support Yanan Wang
2021-04-13 8:31 ` [RFC PATCH v2 1/4] vl.c: Add -smp, clusters=* command line support for ARM cpu Yanan Wang
2021-04-28 10:23 ` Andrew Jones
2021-04-29 1:22 ` wangyanan (Y)
2021-04-13 8:31 ` [RFC PATCH v2 2/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse Yanan Wang
2021-04-28 10:31 ` Andrew Jones
2021-04-29 2:14 ` wangyanan (Y)
2021-04-29 7:16 ` Andrew Jones
2021-04-29 8:56 ` wangyanan (Y)
2021-04-29 11:02 ` Andrew Jones
2021-04-30 5:09 ` wangyanan (Y)
2021-04-30 6:41 ` Andrew Jones
2021-04-30 7:01 ` Andrew Jones
2021-04-30 9:33 ` wangyanan (Y)
2021-04-30 10:49 ` Andrew Jones
2021-05-06 7:04 ` wangyanan (Y)
2021-04-30 8:59 ` wangyanan (Y)
2021-04-30 10:48 ` Andrew Jones
2021-04-13 8:31 ` Yanan Wang [this message]
2021-04-28 10:41 ` [RFC PATCH v2 3/4] hw/arm/virt-acpi-build: Add cluster level for PPTT table Andrew Jones
2021-04-13 8:31 ` [RFC PATCH v2 4/4] hw/arm/virt: Add cluster level for device tree Yanan Wang
2021-04-28 10:46 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413083147.34236-4-wangyanan55@huawei.com \
--to=wangyanan55@huawei.com \
--cc=alistair.francis@wdc.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=imammedo@redhat.com \
--cc=lijiajie11@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=prime.zeng@hisilicon.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=song.bao.hua@hisilicon.com \
--cc=wanghaibin.wang@huawei.com \
--cc=yangyicong@huawei.com \
--cc=yuzenghui@huawei.com \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).