qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>
Subject: [PULL v2 3/3] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code
Date: Tue, 13 Apr 2021 18:08:50 +0200	[thread overview]
Message-ID: <20210413160850.240064-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20210413160850.240064-1-pbonzini@redhat.com>

From: Thomas Huth <thuth@redhat.com>

The ObjectType enum and ObjectOptions are included from qapi-types-qom.h
into common code. We should not use target-specific config switches like
CONFIG_VIRTIO_CRYPTO here, since this is not defined in common code and
thus the enum will look differently between common and target specific
code. For this case, it's hopefully enough to check for CONFIG_VHOST_CRYPTO
only (which is a host specific config switch, i.e. it's the same on all
targets).

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210412160710.639800-1-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qapi/qom.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/qom.json b/qapi/qom.json
index db5ac419b1..cd0e76d564 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -752,7 +752,7 @@
     'cryptodev-backend',
     'cryptodev-backend-builtin',
     { 'name': 'cryptodev-vhost-user',
-      'if': 'defined(CONFIG_VIRTIO_CRYPTO) && defined(CONFIG_VHOST_CRYPTO)' },
+      'if': 'defined(CONFIG_VHOST_CRYPTO)' },
     'dbus-vmstate',
     'filter-buffer',
     'filter-dump',
@@ -809,7 +809,7 @@
       'cryptodev-backend':          'CryptodevBackendProperties',
       'cryptodev-backend-builtin':  'CryptodevBackendProperties',
       'cryptodev-vhost-user':       { 'type': 'CryptodevVhostUserProperties',
-                                      'if': 'defined(CONFIG_VIRTIO_CRYPTO) && defined(CONFIG_VHOST_CRYPTO)' },
+                                      'if': 'defined(CONFIG_VHOST_CRYPTO)' },
       'dbus-vmstate':               'DBusVMStateProperties',
       'filter-buffer':              'FilterBufferProperties',
       'filter-dump':                'FilterDumpProperties',
-- 
2.30.1



  parent reply	other threads:[~2021-04-13 16:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 16:08 [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3 Paolo Bonzini
2021-04-13 16:08 ` [PULL v2 1/3] osdep: include glib-compat.h before other QEMU headers Paolo Bonzini
2021-04-14 16:51   ` Philippe Mathieu-Daudé
2021-04-14 17:00   ` Daniel P. Berrangé
2021-04-13 16:08 ` [PULL v2 2/3] osdep: protect qemu/osdep.h with extern "C" Paolo Bonzini
2021-04-14 17:07   ` Daniel P. Berrangé
2021-04-14 18:39     ` Peter Maydell
2021-04-14 18:50     ` Peter Maydell
2021-04-15  9:20       ` Daniel P. Berrangé
2021-04-13 16:08 ` Paolo Bonzini [this message]
2021-04-13 17:05 ` [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3 no-reply
2021-04-13 20:15 ` Peter Maydell
2021-04-14 12:10   ` Peter Maydell
2021-04-14 18:22 ` Peter Maydell
2021-04-15  5:57   ` Markus Armbruster
2021-04-15 10:48     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210413160850.240064-4-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).