From: Eduardo Habkost <ehabkost@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
David Edmondson <dme@dme.org>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] i386: Make 'hv-reenlightenment' require explicit 'tsc-frequency' setting
Date: Wed, 14 Apr 2021 09:26:31 -0400 [thread overview]
Message-ID: <20210414132631.ilnasigkxcjoi2px@habkost.net> (raw)
In-Reply-To: <20210331113948.333461-1-vkuznets@redhat.com>
My apologies, this was lost under the noise in my mail inbox.
(I promise I'm trying to improve)
On Wed, Mar 31, 2021 at 01:39:48PM +0200, Vitaly Kuznetsov wrote:
> Commit 561dbb41b1d7 "i386: Make migration fail when Hyper-V reenlightenment
> was enabled but 'user_tsc_khz' is unset" forbade migrations with when guest
> has opted for reenlightenment notifications but 'tsc-frequency' wasn't set
> explicitly on the command line. This works but the migration fails late and
> this may come as an unpleasant surprise. To make things more explicit,
> require 'tsc-frequency=' on the command line when 'hv-reenlightenment' was
> enabled. Make the change affect 6.0+ machine types only to preserve
> previously-valid configurations.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Even if the 6.0 release gets delayed, I wouldn't be comfortable
including this in a -rc4.
What if the user does not plan to live migrate the machine at
all? Why is this case different from the ~25
migrate_add_blocker() calls in QEMU, where we block migration but
still let the VM run?
--
Eduardo
next prev parent reply other threads:[~2021-04-14 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 11:39 [PATCH v2] i386: Make 'hv-reenlightenment' require explicit 'tsc-frequency' setting Vitaly Kuznetsov
2021-04-14 13:26 ` Eduardo Habkost [this message]
2021-04-14 13:51 ` Vitaly Kuznetsov
2021-04-14 14:39 ` Eduardo Habkost
2021-04-15 9:31 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414132631.ilnasigkxcjoi2px@habkost.net \
--to=ehabkost@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dme@dme.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).