From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0339C433B4 for ; Mon, 19 Apr 2021 16:32:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 389B060698 for ; Mon, 19 Apr 2021 16:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 389B060698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYWpO-00023a-Bb for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 12:32:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYWo4-00015H-B2 for qemu-devel@nongnu.org; Mon, 19 Apr 2021 12:31:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYWo2-0005n5-VR for qemu-devel@nongnu.org; Mon, 19 Apr 2021 12:31:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618849885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bZpf3aH+mZqiIcvFS1dZal1Y1sNB+SL5LZ8jmGXn3eM=; b=V8yP/AXdDnDUBFGQbzA7nkQuYoqHqk5dR9QKfmMnYM4Nq0F8qB3bbdg14ucoU5WEuZ64Md otteilQ0Z8u5F9gJ3S6fHbjQkj3Cfn7HV1h1ptA+Py+VPjSqLJxz6gU1lKDhrB4EqtMcpT tRWMocpPdwc3HcJfQZr5rAqOSO499Pw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-Y20qRyfLOTiy8a6_b5gkng-1; Mon, 19 Apr 2021 12:31:20 -0400 X-MC-Unique: Y20qRyfLOTiy8a6_b5gkng-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2999810074C9; Mon, 19 Apr 2021 16:30:52 +0000 (UTC) Received: from gondolin.fritz.box (ovpn-113-200.ams2.redhat.com [10.36.113.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3CCEA10013D7; Mon, 19 Apr 2021 16:30:50 +0000 (UTC) Date: Mon, 19 Apr 2021 18:30:47 +0200 From: Cornelia Huck To: Claudio Fontana Subject: Re: [RFC v1 1/5] hw/s390x: only build qemu-tod from the CONFIG_TCG build Message-ID: <20210419183047.4b0d36ba.cohuck@redhat.com> In-Reply-To: References: <20210322191551.25752-1-cfontana@suse.de> <20210322191551.25752-2-cfontana@suse.de> <20210331130756.20971c8a.cohuck@redhat.com> <4eaf4c51-b940-66df-7ef7-61782b0cf31d@suse.de> <0eecb78f-c521-f217-1ea5-e570dc080a15@suse.de> <20210419182023.3b44e114.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Richard Henderson , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 19 Apr 2021 18:24:34 +0200 Claudio Fontana wrote: > On 4/19/21 6:20 PM, Cornelia Huck wrote: > > On Mon, 19 Apr 2021 18:12:48 +0200 > > Claudio Fontana wrote: > > > >> On 4/19/21 11:11 AM, Claudio Fontana wrote: > >>> Hi Cornelia, > >>> > >>> On 3/31/21 1:07 PM, Cornelia Huck wrote: > >>>> On Mon, 22 Mar 2021 20:15:47 +0100 > >>>> Claudio Fontana wrote: > > > >>>>> @@ -25,6 +24,10 @@ s390x_ss.add(when: 'CONFIG_KVM', if_true: files( > >>>>> 's390-stattrib-kvm.c', > >>>>> 'pv.c', > >>>>> )) > >>>>> +s390x_ss.add(when: 'CONFIG_TCG', if_true: files( > >>>>> + 'tod-qemu.c', > >>>> > >>>> Should we rename this to tod-tcg.c? > >>> > >>> I think so. > >> > >> Here we are a bit limited though by the fact that the object is currently called: > >> > >> include/hw/s390x/tod.h:26:#define TYPE_QEMU_S390_TOD TYPE_S390_TOD "-qemu" > >> > >> So there might be a compatibility issue in trying to make this consistent, which would mean to replace this with: > >> > >> #define TYPE_TCG_S390_TOD TYPE_S390_TOD "-tcg" > >> > >> What do you think? > > > > How visible is this? I don't think the TOD objects are instantiable by > > the user. > > > > I just remember we were very conservative with the object hierarchy on x86, personally I am fine with the change. > I will add this change then, I'd ask for people with concerns about this to speak up: > > (Paolo?) > > Ciao, > > CLaudio > It was more an argument against changing it, because most people won't see it anyway :)