From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E6B7C433B4 for ; Tue, 20 Apr 2021 15:28:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6566613AE for ; Tue, 20 Apr 2021 15:28:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6566613AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYsIU-0003kP-SR for qemu-devel@archiver.kernel.org; Tue, 20 Apr 2021 11:28:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYsCh-0005ko-Mp for qemu-devel@nongnu.org; Tue, 20 Apr 2021 11:22:20 -0400 Received: from mga05.intel.com ([192.55.52.43]:37580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYsCb-0004eD-2p for qemu-devel@nongnu.org; Tue, 20 Apr 2021 11:22:19 -0400 IronPort-SDR: ptioplYskxzkeWG+fIyUAVh0o4W66OKDHnwpf/gP6lgmDX0UQYXC659WwwERLBgWsgq1oFBzMH hfC3+Clutf0Q== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="280854248" X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="280854248" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 08:22:11 -0700 IronPort-SDR: k8OF5vJ5zPnD8ok00oIOmxpMmxNIigYmv56hI5pVp1A3TqaoaxW5mSODPv+8jVHMGfYcTAKjRP VIK2DRl3bXlg== X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="523846771" Received: from unknown (HELO tkid-nvme.lan) ([10.239.13.19]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 08:22:08 -0700 From: Zhang Chen To: Jason Wang , qemu-dev , Eric Blake , "Dr. David Alan Gilbert" , Markus Armbruster , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Gerd Hoffmann , Li Zhijian Subject: [PATCH V6 6/6] net/net.c: Add handler for COLO passthrough connection Date: Tue, 20 Apr 2021 23:15:37 +0800 Message-Id: <20210420151537.64360-7-chen.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210420151537.64360-1-chen.zhang@intel.com> References: <20210420151537.64360-1-chen.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=192.55.52.43; envelope-from=chen.zhang@intel.com; helo=mga05.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Lukas Straub , Zhang Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Use connection protocol,src port,dst port,src ip,dst ip as the key to bypass certain network traffic in COLO compare. Signed-off-by: Zhang Chen --- net/net.c | 160 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 158 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net/net.c index 2a6e5f3886..9b0de0f332 100644 --- a/net/net.c +++ b/net/net.c @@ -56,6 +56,8 @@ #include "sysemu/sysemu.h" #include "net/filter.h" #include "qapi/string-output-visitor.h" +#include "net/colo-compare.h" +#include "qom/object_interfaces.h" /* Net bridge is currently not supported for W32. */ #if !defined(_WIN32) @@ -1196,14 +1198,168 @@ void qmp_netdev_del(const char *id, Error **errp) } } +static CompareState *colo_passthrough_check(IPFlowSpec *spec, Error **errp) +{ + Object *container; + Object *obj; + CompareState *s; + + if (!spec->object_name) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "object-name", + "Need input colo-compare object name"); + return NULL; + } + + container = object_get_objects_root(); + obj = object_resolve_path_component(container, spec->object_name); + if (!obj) { + error_setg(errp, "colo-compare '%s' not found", spec->object_name); + return NULL; + } + + s = COLO_COMPARE(obj); + + if (!getprotobyname(spec->protocol)) { + error_setg(errp, "COLO pass through get wrong protocol"); + return NULL; + } + + if ((spec->source->host && !qemu_isdigit(spec->source->host[0])) || + (spec->destination->host && + !qemu_isdigit(spec->destination->host[0]))) { + error_setg(errp, "COLO pass through get wrong IP"); + return NULL; + } + + if (atoi(spec->source->port) > 65536 || atoi(spec->source->port) < 0 || + atoi(spec->destination->port) > 65536 || + atoi(spec->destination->port) < 0) { + error_setg(errp, "COLO pass through get wrong port"); + return NULL; + } + + return s; +} + +static void compare_passthrough_add(CompareState *s, + IPFlowSpec *spec, + Error **errp) +{ + COLOPassthroughEntry *pass = NULL, *next = NULL, *origin = NULL; + + pass = g_new0(COLOPassthroughEntry, 1); + + pass->l4_protocol = getprotobyname(spec->protocol); + pass->src_port = atoi(spec->source->port); + pass->dst_port = atoi(spec->destination->port); + + if (!inet_aton(spec->source->host, &pass->src_ip)) { + pass->src_ip.s_addr = 0; + } + + if (!inet_aton(spec->destination->host, &pass->dst_ip)) { + pass->dst_ip.s_addr = 0; + } + + qemu_mutex_lock(&s->passthroughlist_mutex); + if (!QLIST_EMPTY(&s->passthroughlist)) { + QLIST_FOREACH_SAFE(origin, &s->passthroughlist, node, next) { + if ((pass->l4_protocol->p_proto == origin->l4_protocol->p_proto) && + (pass->src_port == origin->src_port) && + (pass->dst_port == origin->dst_port) && + (pass->src_ip.s_addr == origin->src_ip.s_addr) && + (pass->dst_ip.s_addr == origin->dst_ip.s_addr)) { + error_setg(errp, "The pass through connection already exists"); + g_free(pass); + qemu_mutex_unlock(&s->passthroughlist_mutex); + return; + } + } + } + + QLIST_INSERT_HEAD(&s->passthroughlist, pass, node); + qemu_mutex_unlock(&s->passthroughlist_mutex); +} + +static void compare_passthrough_del(CompareState *s, + IPFlowSpec *spec, + Error **errp) +{ + COLOPassthroughEntry *pass = NULL, *next = NULL, *origin = NULL; + + pass = g_new0(COLOPassthroughEntry, 1); + + pass->l4_protocol = getprotobyname(spec->protocol); + pass->src_port = atoi(spec->source->port); + pass->dst_port = atoi(spec->destination->port); + + if (!inet_aton(spec->source->host, &pass->src_ip)) { + pass->src_ip.s_addr = 0; + } + + if (!inet_aton(spec->destination->host, &pass->dst_ip)) { + pass->dst_ip.s_addr = 0; + } + + qemu_mutex_lock(&s->passthroughlist_mutex); + if (!QLIST_EMPTY(&s->passthroughlist)) { + QLIST_FOREACH_SAFE(origin, &s->passthroughlist, node, next) { + if ((pass->l4_protocol->p_proto == origin->l4_protocol->p_proto) && + (pass->src_port == origin->src_port) && + (pass->dst_port == origin->dst_port) && + (pass->src_ip.s_addr == origin->src_ip.s_addr) && + (pass->dst_ip.s_addr == origin->dst_ip.s_addr)) { + QLIST_REMOVE(origin, node); + g_free(origin); + g_free(pass); + qemu_mutex_unlock(&s->passthroughlist_mutex); + return; + } + } + error_setg(errp, "The pass through list can't find the connection"); + } else { + error_setg(errp, "The pass through connection list is empty"); + } + + g_free(pass); + qemu_mutex_unlock(&s->passthroughlist_mutex); +} + + void qmp_colo_passthrough_add(IPFlowSpec *spec, Error **errp) { - /* TODO implement setup passthrough rule */ + CompareState *s; + Error *err = NULL; + + s = colo_passthrough_check(spec, &err); + if (err) { + error_propagate(errp, err); + return; + } + + compare_passthrough_add(s, spec, &err); + if (err) { + error_propagate(errp, err); + return; + } } void qmp_colo_passthrough_del(IPFlowSpec *spec, Error **errp) { - /* TODO implement delete passthrough rule */ + CompareState *s; + Error *err = NULL; + + s = colo_passthrough_check(spec, &err); + if (err) { + error_propagate(errp, err); + return; + } + + compare_passthrough_del(s, spec, &err); + if (err) { + error_propagate(errp, err); + return; + } } static void netfilter_print_info(Monitor *mon, NetFilterState *nf) -- 2.25.1