From: Eduardo Habkost <ehabkost@redhat.com>
To: Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Denis Lunev <den@openvz.org>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v6] qapi: introduce 'query-cpu-model-cpuid' action
Date: Tue, 20 Apr 2021 13:09:00 -0400 [thread overview]
Message-ID: <20210420170900.utg4qzqkefdc642c@habkost.net> (raw)
In-Reply-To: <20210420161940.24306-1-valeriy.vdovin@virtuozzo.com>
On Tue, Apr 20, 2021 at 07:19:40PM +0300, Valeriy Vdovin wrote:
[...]
> +##
> +# @query-cpu-model-cpuid:
> +#
> +# Returns description of a virtual CPU model, created by QEMU after cpu
> +# initialization routines. The resulting information is a reflection of a parsed
> +# '-cpu' command line option, filtered by available host cpu features.
> +#
> +# Returns: @CpuModelCpuidDescription
> +#
> +# Example:
> +#
> +# -> { "execute": "query-cpu-model-cpuid" }
> +# <- { "return": 'CpuModelCpuidDescription' }
> +#
> +# Since: 6.1
> +##
> +{ 'command': 'query-cpu-model-cpuid',
> + 'returns': 'CpuModelCpuidDescription',
> + 'if': 'defined(TARGET_I386)' }
I was assuming the command was going to get a CPU model name as
argument.
If you are only going to return info on the current CPUs, the
interface could be simplified a lot.
What about a simple `query-cpuid` command that only takes:
{ 'qom-path': 'str', # qom-path is returned by query-cpus-fast
'eax': 'uint32',
'*ecx': 'uint32' }
as argument, and returns
{ 'present': 'bool',
'max_eax': 'uint32', # max value of EAX for this range
'*max_ecx': 'uint32', # max value of ECX if there are subleaves
'eax': 'uint32',
'ebx': 'uint32',
'ecx': 'uint32',
'edx': 'uint32' }
?
--
Eduardo
next prev parent reply other threads:[~2021-04-20 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 16:19 [PATCH v6] qapi: introduce 'query-cpu-model-cpuid' action Valeriy Vdovin
2021-04-20 16:42 ` no-reply
2021-04-20 17:00 ` Vladimir Sementsov-Ogievskiy
2021-04-20 17:09 ` Eduardo Habkost [this message]
2021-04-21 17:39 ` Valeriy Vdovin
2021-04-21 20:17 ` Eduardo Habkost
2021-04-22 9:02 ` Valeriy Vdovin
2021-04-23 20:32 ` Eduardo Habkost
2021-04-22 9:41 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420170900.utg4qzqkefdc642c@habkost.net \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=valeriy.vdovin@virtuozzo.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).