From: Claudio Fontana <cfontana@suse.de>
To: Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Claudio Fontana <cfontana@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [RFC v3 08/13] target/s390x: make helper.c sysemu-only
Date: Thu, 22 Apr 2021 13:54:25 +0200 [thread overview]
Message-ID: <20210422115430.15078-9-cfontana@suse.de> (raw)
In-Reply-To: <20210422115430.15078-1-cfontana@suse.de>
Now that we have moved cpu-dump functionality out of helper.c,
we can make the module sysemu-only.
Signed-off-by: Claudio Fontana <cfontana@suse.de>
---
target/s390x/helper.c | 4 ----
target/s390x/meson.build | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/s390x/helper.c b/target/s390x/helper.c
index 41ccc83d11..f246bec353 100644
--- a/target/s390x/helper.c
+++ b/target/s390x/helper.c
@@ -27,11 +27,8 @@
#include "hw/s390x/pv.h"
#include "sysemu/hw_accel.h"
#include "sysemu/runstate.h"
-#ifndef CONFIG_USER_ONLY
#include "sysemu/tcg.h"
-#endif
-#ifndef CONFIG_USER_ONLY
void s390x_tod_timer(void *opaque)
{
cpu_inject_clock_comparator((S390CPU *) opaque);
@@ -322,4 +319,3 @@ int s390_store_adtl_status(S390CPU *cpu, hwaddr addr, hwaddr len)
cpu_physical_memory_unmap(sa, len, 1, len);
return 0;
}
-#endif /* CONFIG_USER_ONLY */
diff --git a/target/s390x/meson.build b/target/s390x/meson.build
index 6e1aa3b0cd..bbcaede384 100644
--- a/target/s390x/meson.build
+++ b/target/s390x/meson.build
@@ -4,7 +4,6 @@ s390x_ss.add(files(
'cpu_features.c',
'cpu_models.c',
'gdbstub.c',
- 'helper.c',
'interrupt.c',
'cpu-dump.c',
))
@@ -23,6 +22,7 @@ s390x_ss.add(gen_features_h)
s390x_softmmu_ss = ss.source_set()
s390x_softmmu_ss.add(files(
+ 'helper.c',
'arch_dump.c',
'diag.c',
'ioinst.c',
--
2.26.2
next prev parent reply other threads:[~2021-04-22 11:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 11:54 [RFC v3 00/13] s390x cleanup Claudio Fontana
2021-04-22 11:54 ` [RFC v3 01/13] hw/s390x: rename tod-qemu.c to tod-tcg.c Claudio Fontana
2021-04-27 14:09 ` Cornelia Huck
2021-04-28 10:07 ` David Hildenbrand
2021-04-22 11:54 ` [RFC v3 02/13] hw/s390x: only build tod-tcg from the CONFIG_TCG build Claudio Fontana
2021-04-27 14:11 ` Cornelia Huck
2021-04-28 10:07 ` David Hildenbrand
2021-04-22 11:54 ` [RFC v3 03/13] hw/s390x: tod: make explicit checks for accelerators when initializing Claudio Fontana
2021-04-27 14:13 ` Cornelia Huck
2021-04-28 10:08 ` David Hildenbrand
2021-04-22 11:54 ` [RFC v3 04/13] target/s390x: remove tcg-stub.c Claudio Fontana
2021-04-27 14:55 ` Cornelia Huck
2021-04-22 11:54 ` [RFC v3 05/13] target/s390x: start moving TCG-only code to tcg/ Claudio Fontana
2021-04-28 10:08 ` David Hildenbrand
2021-04-22 11:54 ` [RFC v3 06/13] target/s390x: move sysemu-only code out to cpu-sysemu.c Claudio Fontana
2021-04-22 11:54 ` [RFC v3 07/13] target/s390x: split cpu-dump from helper.c Claudio Fontana
2021-04-22 11:54 ` Claudio Fontana [this message]
2021-04-22 11:54 ` [RFC v3 09/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m Claudio Fontana
2021-04-22 11:54 ` [RFC v3 10/13] target/s390x: remove kvm-stub.c Claudio Fontana
2021-04-22 11:54 ` [RFC v3 11/13] target/s390x: move kvm files into kvm/ Claudio Fontana
2021-04-22 11:54 ` [RFC v3 12/13] target/s390x: split sysemu part of cpu models Claudio Fontana
2021-04-22 11:54 ` [RFC v3 13/13] MAINTAINERS: update s390x directories Claudio Fontana
2021-04-27 15:00 ` Cornelia Huck
2021-04-28 10:30 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422115430.15078-9-cfontana@suse.de \
--to=cfontana@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).