qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Konstantin Nazarov <mail@knazarov.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 7/8] edid: allow arbitrary-length checksums
Date: Tue, 27 Apr 2021 17:08:23 +0200	[thread overview]
Message-ID: <20210427150824.638359-8-kraxel@redhat.com> (raw)
In-Reply-To: <20210427150824.638359-1-kraxel@redhat.com>

From: Konstantin Nazarov <mail@knazarov.com>

Some of the EDID extensions like DisplayID do checksums of their
subsections. Currently checksums can be only applied to the whole
extension blocks which are 128 bytes.

This patch allows to checksum arbitrary parts of EDID, and not only
whole extension blocks.

Based-on: <20210303152948.59943-2-akihiko.odaki@gmail.com>
Signed-off-by: Konstantin Nazarov <mail@knazarov.com>
Message-Id: <20210315114639.91953-2-mail@knazarov.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/edid-generate.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c
index b70ab1557e50..bdd01571fc9b 100644
--- a/hw/display/edid-generate.c
+++ b/hw/display/edid-generate.c
@@ -159,17 +159,17 @@ static void edid_fill_modes(uint8_t *edid, uint8_t *xtra3, uint8_t *dta,
     }
 }
 
-static void edid_checksum(uint8_t *edid)
+static void edid_checksum(uint8_t *edid, size_t len)
 {
     uint32_t sum = 0;
     int i;
 
-    for (i = 0; i < 127; i++) {
+    for (i = 0; i < len; i++) {
         sum += edid[i];
     }
     sum &= 0xff;
     if (sum) {
-        edid[127] = 0x100 - sum;
+        edid[len] = 0x100 - sum;
     }
 }
 
@@ -474,9 +474,9 @@ void qemu_edid_generate(uint8_t *edid, size_t size,
 
     /* =============== finish up =============== */
 
-    edid_checksum(edid);
+    edid_checksum(edid, 127);
     if (dta) {
-        edid_checksum(dta);
+        edid_checksum(dta, 127);
     }
 }
 
-- 
2.30.2



  parent reply	other threads:[~2021-04-27 15:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 15:08 [PATCH v2 0/8] edid: windows fixes Gerd Hoffmann
2021-04-27 15:08 ` [PATCH v2 1/8] qemu-edid: use qemu_edid_size() Gerd Hoffmann
2021-04-27 15:53   ` Marc-André Lureau
2021-04-27 15:08 ` [PATCH v2 2/8] edid: edid_desc_next Gerd Hoffmann
2021-04-27 15:53   ` Marc-André Lureau
2021-04-27 15:08 ` [PATCH v2 3/8] edid: move xtra3 descriptor Gerd Hoffmann
2021-04-27 15:54   ` Marc-André Lureau
2021-04-27 15:08 ` [PATCH v2 4/8] edid: use dta extension block descriptors Gerd Hoffmann
2021-04-27 15:59   ` Marc-André Lureau
2021-04-27 15:08 ` [PATCH v2 5/8] edid: Make refresh rate configurable Gerd Hoffmann
2021-04-27 15:08 ` [PATCH v2 6/8] edid: move timing generation into a separate function Gerd Hoffmann
2021-04-27 15:08 ` Gerd Hoffmann [this message]
2021-04-27 15:08 ` [PATCH v2 8/8] edid: add support for DisplayID extension (5k resolution) Gerd Hoffmann
2021-04-27 15:27 ` [PATCH v2 0/8] edid: windows fixes no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427150824.638359-8-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=mail@knazarov.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).