From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, fam@euphon.net, stefanha@redhat.com,
mreitz@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com,
eesposit@redhat.com, pbonzini@redhat.com
Subject: [PATCH v2 6/9] test-write-threshold: drop extra tests
Date: Tue, 4 May 2021 11:25:50 +0300 [thread overview]
Message-ID: <20210504082553.20377-7-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210504082553.20377-1-vsementsov@virtuozzo.com>
Testing set/get of one 64bit variable doesn't seem necessary. We have a
lot of such variables. Also remaining tests do test set/get anyway.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/unit/test-write-threshold.c | 43 -------------------------------
1 file changed, 43 deletions(-)
diff --git a/tests/unit/test-write-threshold.c b/tests/unit/test-write-threshold.c
index bb5c1a5217..9e9986aefc 100644
--- a/tests/unit/test-write-threshold.c
+++ b/tests/unit/test-write-threshold.c
@@ -12,43 +12,6 @@
#include "block/write-threshold.h"
-static void test_threshold_not_set_on_init(void)
-{
- uint64_t res;
- BlockDriverState bs;
- memset(&bs, 0, sizeof(bs));
-
- res = bdrv_write_threshold_get(&bs);
- g_assert_cmpint(res, ==, 0);
-}
-
-static void test_threshold_set_get(void)
-{
- uint64_t threshold = 4 * 1024 * 1024;
- uint64_t res;
- BlockDriverState bs;
- memset(&bs, 0, sizeof(bs));
-
- bdrv_write_threshold_set(&bs, threshold);
-
- res = bdrv_write_threshold_get(&bs);
- g_assert_cmpint(res, ==, threshold);
-}
-
-static void test_threshold_multi_set_get(void)
-{
- uint64_t threshold1 = 4 * 1024 * 1024;
- uint64_t threshold2 = 15 * 1024 * 1024;
- uint64_t res;
- BlockDriverState bs;
- memset(&bs, 0, sizeof(bs));
-
- bdrv_write_threshold_set(&bs, threshold1);
- bdrv_write_threshold_set(&bs, threshold2);
- res = bdrv_write_threshold_get(&bs);
- g_assert_cmpint(res, ==, threshold2);
-}
-
static void test_threshold_not_trigger(void)
{
uint64_t threshold = 4 * 1024 * 1024;
@@ -84,12 +47,6 @@ int main(int argc, char **argv)
{
size_t i;
TestStruct tests[] = {
- { "/write-threshold/not-set-on-init",
- test_threshold_not_set_on_init },
- { "/write-threshold/set-get",
- test_threshold_set_get },
- { "/write-threshold/multi-set-get",
- test_threshold_multi_set_get },
{ "/write-threshold/not-trigger",
test_threshold_not_trigger },
{ "/write-threshold/trigger",
--
2.29.2
next prev parent reply other threads:[~2021-05-04 8:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 8:25 [PATCH v2 0/9] block: refactor write threshold Vladimir Sementsov-Ogievskiy
2021-05-04 8:25 ` [PATCH v2 1/9] block/write-threshold: don't use write notifiers Vladimir Sementsov-Ogievskiy
2021-05-05 12:37 ` Max Reitz
2021-05-05 13:27 ` Vladimir Sementsov-Ogievskiy
2021-05-05 13:35 ` Vladimir Sementsov-Ogievskiy
2021-05-05 14:29 ` Max Reitz
2021-05-04 8:25 ` [PATCH v2 2/9] block: drop " Vladimir Sementsov-Ogievskiy
2021-05-05 12:40 ` Max Reitz
2021-05-04 8:25 ` [PATCH v2 3/9] test-write-threshold: rewrite test_threshold_(not_)trigger tests Vladimir Sementsov-Ogievskiy
2021-05-05 14:28 ` Max Reitz
2021-05-05 15:20 ` Vladimir Sementsov-Ogievskiy
2021-05-04 8:25 ` [PATCH v2 4/9] block/write-threshold: drop extra APIs Vladimir Sementsov-Ogievskiy
2021-05-05 14:41 ` Max Reitz
2021-05-04 8:25 ` [PATCH v2 5/9] block/write-threshold: don't use aio context lock Vladimir Sementsov-Ogievskiy
2021-05-05 16:09 ` Max Reitz
2021-05-04 8:25 ` Vladimir Sementsov-Ogievskiy [this message]
2021-05-05 16:11 ` [PATCH v2 6/9] test-write-threshold: drop extra tests Max Reitz
2021-05-04 8:25 ` [PATCH v2 7/9] test-write-threshold: drop extra TestStruct structure Vladimir Sementsov-Ogievskiy
2021-05-05 16:13 ` Max Reitz
2021-05-04 8:25 ` [PATCH v2 8/9] test-write-threshold: drop extra includes Vladimir Sementsov-Ogievskiy
2021-05-05 16:14 ` Max Reitz
2021-05-04 8:25 ` [PATCH v2 9/9] block/write-threshold: " Vladimir Sementsov-Ogievskiy
2021-05-05 16:23 ` Max Reitz
2021-05-05 20:34 ` Vladimir Sementsov-Ogievskiy
2021-05-06 7:41 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504082553.20377-7-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=eesposit@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).