qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: gustavo@noronha.eti.br
To: qemu-devel@nongnu.org
Cc: 'Peter Maydell ' <peter.maydell@linaro.org>,
	'Markus Armbruster ' <armbru@redhat.com>,
	'Gerd Hoffmann ' <kraxel@redhat.com>,
	'Akihiko Odaki ' <akihiko.odaki@gmail.com>,
	Gustavo Noronha Silva <gustavo@noronha.eti.br>
Subject: [PATCH v4 0/2] cocoa: keyboard quality of life
Date: Tue, 11 May 2021 15:55:36 -0300	[thread overview]
Message-ID: <20210511185538.29344-1-gustavo@noronha.eti.br> (raw)

From: Gustavo Noronha Silva <gustavo@noronha.eti.br>

v4 moves the code to add the tap to the set function, which
not only sidesteps the issue pointed out by Akihiko Odaki
but simply makes sense - full-grab is not a runtime toggle
and there is no reason to have the tap set up if it's not
turned on.

It also fixes the commit message for the swap-option-command
option to no longer lie about it being turned on by default,
as pointed out by Gerd.

-----

This series adds two new options to the cocoa display:

 - full-grab causes it to use a global tap to steal system combos
   away from Mac OS X, so they can be handled by the VM

 - swap-option-command does what it says on the tin; while that is
   something you can do at the Mac OS X level or even supported by
   some keyboards, it is much more convenient to have qemu put
   Meta/Super and Alt where they belong if you are running a
   non-Mac VM

Both are off by default. For full-grab in particular, it is off also
because unfortunately it needs accessibility permissions for input
grabbing, so it requires more deliberate action by the user anyway.

Gustavo Noronha Silva (2):
  ui/cocoa: capture all keys and combos when mouse is grabbed
  ui/cocoa: add option to swap Option and Command

 qapi/ui.json    |  22 +++++++++
 qemu-options.hx |   4 ++
 ui/cocoa.m      | 129 ++++++++++++++++++++++++++++++++++++++++++++----
 3 files changed, 146 insertions(+), 9 deletions(-)

-- 
2.30.1 (Apple Git-130)



             reply	other threads:[~2021-05-11 19:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 18:55 gustavo [this message]
2021-05-11 18:55 ` [PATCH v4 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed gustavo
2021-05-18 10:14   ` 'Gerd Hoffmann '
2021-05-26 15:13     ` Gustavo Noronha Silva
2021-06-09 13:27       ` Gustavo Noronha Silva
2021-06-16 14:13   ` Akihiko Odaki
2021-05-11 18:55 ` [PATCH v4 2/2] ui/cocoa: add option to swap Option and Command gustavo
2021-05-12  3:06   ` Akihiko Odaki
2021-05-12 10:22     ` Gustavo Noronha Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511185538.29344-1-gustavo@noronha.eti.br \
    --to=gustavo@noronha.eti.br \
    --cc=akihiko.odaki@gmail.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).