qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH 00/10] Python: delint iotests, machine.py and console_socket.py
Date: Wed, 12 May 2021 17:46:32 -0400	[thread overview]
Message-ID: <20210512214642.2803189-1-jsnow@redhat.com> (raw)

gitlab CI: https://gitlab.com/jsnow/qemu/-/pipelines/301924893
branch: https://gitlab.com/jsnow/qemu/-/commits/python-package-pre-cleanup

This series serves as a pre-requisite for packaging the python series
and getting the linters running via CI. The first patch fixes a linter
error we've had for a while now; the subsequent 9 fix a new warning that
was recently added to pylint 2.8.x.

If there's nobody opposed, I'll take it through my Python queue,
including the iotests bits.

John Snow (10):
  python/console_socket: avoid one-letter variable
  python/machine: use subprocess.DEVNULL instead of
    open(os.path.devnull)
  python/machine: use subprocess.run instead of subprocess.Popen
  python/console_socket: Add a pylint ignore
  python/machine: Disable pylint warning for open() in _pre_launch
  python/machine: disable warning for Popen in _launch()
  iotests: use subprocess.run where possible
  iotests: use 'with open()' where applicable
  iotests: silence spurious consider-using-with warnings
  iotests: ensure that QemuIoInteractive definitely closes

 python/qemu/console_socket.py    | 11 ++++---
 python/qemu/machine.py           | 28 ++++++++++------
 tests/qemu-iotests/iotests.py    | 55 +++++++++++++++++++-------------
 tests/qemu-iotests/testrunner.py |  1 +
 4 files changed, 57 insertions(+), 38 deletions(-)

-- 
2.30.2




             reply	other threads:[~2021-05-12 21:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 21:46 John Snow [this message]
2021-05-12 21:46 ` [PATCH 01/10] python/console_socket: avoid one-letter variable John Snow
2021-05-13  9:39   ` Philippe Mathieu-Daudé
2021-05-12 21:46 ` [PATCH 02/10] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) John Snow
2021-05-13  9:39   ` Philippe Mathieu-Daudé
2021-05-12 21:46 ` [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen John Snow
2021-05-14 14:08   ` Wainer dos Santos Moschetta
2021-05-14 19:00     ` John Snow
2021-05-14 19:13     ` John Snow
2021-05-12 21:46 ` [PATCH 04/10] python/console_socket: Add a pylint ignore John Snow
2021-05-12 21:46 ` [PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch John Snow
2021-05-14 14:42   ` Wainer dos Santos Moschetta
2021-05-14 19:03     ` John Snow
2021-05-12 21:46 ` [PATCH 06/10] python/machine: disable warning for Popen in _launch() John Snow
2021-05-12 21:46 ` [PATCH 07/10] iotests: use subprocess.run where possible John Snow
2021-05-14 19:22   ` John Snow
2021-05-12 21:46 ` [PATCH 08/10] iotests: use 'with open()' where applicable John Snow
2021-05-13  9:40   ` Philippe Mathieu-Daudé
2021-05-12 21:46 ` [PATCH 09/10] iotests: silence spurious consider-using-with warnings John Snow
2021-05-12 21:46 ` [PATCH 10/10] iotests: ensure that QemuIoInteractive definitely closes John Snow
2021-05-17 16:11 ` [PATCH 00/10] Python: delint iotests, machine.py and console_socket.py John Snow
2021-05-17 17:02   ` Emanuele Giuseppe Esposito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512214642.2803189-1-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).