qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: isaku.yamahata@intel.com,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 12/16] checkpatch: Fix use of uninitialized value
Date: Fri, 14 May 2021 12:04:44 -0400	[thread overview]
Message-ID: <20210514160245.91918-13-mst@redhat.com> (raw)
In-Reply-To: <20210514160245.91918-1-mst@redhat.com>

From: Greg Kurz <groug@kaod.org>

checkfilename() doesn't always set $acpi_testexpected. Fix the following
warning:

Use of uninitialized value $acpi_testexpected in string eq at
 ./scripts/checkpatch.pl line 1529.

Fixes: d2f1af0e4120 ("checkpatch: don't emit warning on newly created acpi data files")
Cc: isaku.yamahata@intel.com
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <161786467973.295167.5612704777283969903.stgit@bahia.lan>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 scripts/checkpatch.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 8f7053ec9b..3d185cceac 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1532,6 +1532,7 @@ sub process {
 		     ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
 		      (defined($1) || defined($2)))) &&
                       !(($realfile ne '') &&
+                        defined($acpi_testexpected) &&
                         ($realfile eq $acpi_testexpected))) {
 			$reported_maintainer_file = 1;
 			WARN("added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
-- 
MST



  parent reply	other threads:[~2021-05-14 16:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 16:04 [PULL 00/16] pc,pci,virtio: bugfixes, improvements Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 01/16] amd_iommu: Fix pte_override_page_mask() Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 02/16] x86: acpi: use offset instead of pointer when using build_header() Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 03/16] hw/virtio: Pass virtio_feature_get_config_size() a const argument Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 04/16] virtio-blk: Constify VirtIOFeature feature_sizes[] Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 05/16] virtio-net: " Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 06/16] amd_iommu: fix wrong MMIO operations Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 07/16] pc-dimm: remove unnecessary get_vmstate_memory_region() method Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 08/16] virtio-blk: Fix rollback path in virtio_blk_data_plane_start() Michael S. Tsirkin
2021-07-07 15:02   ` Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 09/16] virtio-blk: Configure all host notifiers in a single MR transaction Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 10/16] virtio-scsi: Set host notifiers and callbacks separately Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 11/16] virtio-scsi: Configure all host notifiers in a single MR transaction Michael S. Tsirkin
2021-05-14 16:04 ` Michael S. Tsirkin [this message]
2021-05-14 16:04 ` [PULL 13/16] hw/smbios: support for type 41 (onboard devices extended information) Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 14/16] hw/virtio: enable ioeventfd configuring for mmio Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 15/16] vhost-vdpa: Make vhost_vdpa_get_device_id() static Michael S. Tsirkin
2021-05-14 16:04 ` [PULL 16/16] Fix build with 64 bits time_t Michael S. Tsirkin
2021-05-16 18:49 ` [PULL 00/16] pc,pci,virtio: bugfixes, improvements Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514160245.91918-13-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=groug@kaod.org \
    --cc=isaku.yamahata@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).