From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
jsnow@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
stefanha@redhat.com
Subject: [PATCH v4 0/9] qapi: untie 'if' conditions from C preprocessor
Date: Mon, 17 May 2021 20:30:31 +0400 [thread overview]
Message-ID: <20210517163040.2308926-1-marcandre.lureau@redhat.com> (raw)
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Hi,
This series makes the 'if' conditions less liberal, by formalizing a simple
expression tree based on bare boolean logic of configure option identifiers.
(this allows to express conditions in Rust in my QAPI-Rust PoC series)
thanks
v4:
- keep gen_if/gen_endif in common.py, reducing C codegen in schema.py
- raise NotImplemented instead of False for unhandled __eq__
- change check_if() to keep the json/raw form, add _make_if() to build a
QAPISchemaIfCond
- improve __repr__ usage
- drop ABC usage
- tweaks here and there
- add various commit tags
v3:
- rebasing on queued pt4 (after waiting for it to land)
- improve documentation generation, to be more human-friendly
- drop typing annotations from schema.py (not yet queued)
- commit message tweaks
v2:
- fix the normalization step to handle recursive expr
- replace IfCond by QAPISchemaIf (JohnS)
- commit message and documentation tweaks
- mypy/flake8/isort
Marc-André Lureau (9):
qapi: replace List[str] by QAPISchemaIfCond
qapi: make gen_if/gen_endif take a simple string
qapi: start building an 'if' predicate tree
qapi: introduce IfPredicateList and IfAny
qapi: add IfNot
qapi: normalize 'if' condition to IfPredicate tree
qapi: convert 'if' C-expressions to the new syntax tree
qapi: make 'if' condition strings simple identifiers
docs: update the documentation about schema configuration
docs/devel/qapi-code-gen.txt | 33 ++---
docs/sphinx/qapidoc.py | 6 +-
qapi/block-core.json | 16 +--
qapi/block-export.json | 6 +-
qapi/char.json | 8 +-
qapi/machine-target.json | 28 +++--
qapi/migration.json | 10 +-
qapi/misc-target.json | 36 ++++--
qapi/qom.json | 10 +-
qapi/sockets.json | 4 +-
qapi/ui.json | 48 ++++----
qga/qapi-schema.json | 8 +-
tests/unit/test-qmp-cmds.c | 1 +
scripts/qapi/commands.py | 4 +-
scripts/qapi/common.py | 116 ++++++++++++++++--
scripts/qapi/events.py | 5 +-
scripts/qapi/expr.py | 53 +++++---
scripts/qapi/gen.py | 14 +--
scripts/qapi/introspect.py | 26 ++--
scripts/qapi/schema.py | 112 +++++++++++++----
scripts/qapi/types.py | 33 ++---
scripts/qapi/visit.py | 23 ++--
.../alternate-branch-if-invalid.err | 2 +-
tests/qapi-schema/bad-if-empty.err | 2 +-
tests/qapi-schema/bad-if-list.err | 2 +-
tests/qapi-schema/bad-if.err | 3 +-
tests/qapi-schema/bad-if.json | 2 +-
tests/qapi-schema/doc-good.json | 6 +-
tests/qapi-schema/doc-good.out | 12 +-
tests/qapi-schema/doc-good.txt | 6 +-
tests/qapi-schema/enum-if-invalid.err | 3 +-
tests/qapi-schema/features-if-invalid.err | 2 +-
tests/qapi-schema/features-missing-name.json | 2 +-
tests/qapi-schema/qapi-schema-test.json | 58 +++++----
tests/qapi-schema/qapi-schema-test.out | 67 +++++-----
.../qapi-schema/struct-member-if-invalid.err | 2 +-
tests/qapi-schema/test-qapi.py | 2 +-
tests/qapi-schema/union-branch-if-invalid.err | 2 +-
38 files changed, 493 insertions(+), 280 deletions(-)
--
2.29.0
next reply other threads:[~2021-05-17 16:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 16:30 marcandre.lureau [this message]
2021-05-17 16:30 ` [PATCH v4 1/9] qapi: replace List[str] by QAPISchemaIfCond marcandre.lureau
2021-06-07 14:18 ` Eric Blake
2021-06-08 11:38 ` Marc-André Lureau
2021-05-17 16:30 ` [PATCH v4 2/9] qapi: make gen_if/gen_endif take a simple string marcandre.lureau
2021-05-17 16:30 ` [PATCH v4 3/9] qapi: start building an 'if' predicate tree marcandre.lureau
2021-05-17 16:30 ` [PATCH v4 4/9] qapi: introduce IfPredicateList and IfAny marcandre.lureau
2021-05-17 16:30 ` [PATCH v4 5/9] qapi: add IfNot marcandre.lureau
2021-05-17 16:30 ` [PATCH v4 6/9] qapi: normalize 'if' condition to IfPredicate tree marcandre.lureau
2021-05-17 16:30 ` [PATCH v4 7/9] qapi: convert 'if' C-expressions to the new syntax tree marcandre.lureau
2021-05-17 16:30 ` [PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers marcandre.lureau
2021-05-21 12:02 ` Markus Armbruster
2021-05-21 12:26 ` Marc-André Lureau
2021-05-21 15:07 ` Markus Armbruster
2021-05-17 16:30 ` [PATCH v4 9/9] docs: update the documentation about schema configuration marcandre.lureau
2021-05-21 11:56 ` Markus Armbruster
2021-05-21 12:29 ` Marc-André Lureau
2021-05-21 15:24 ` [PATCH v4 0/9] qapi: untie 'if' conditions from C preprocessor Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517163040.2308926-1-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).