From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E560CC433B4 for ; Mon, 17 May 2021 16:40:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C8BC60FD9 for ; Mon, 17 May 2021 16:40:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C8BC60FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ligI8-0000xJ-HD for qemu-devel@archiver.kernel.org; Mon, 17 May 2021 12:40:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lig0z-0005XS-VD for qemu-devel@nongnu.org; Mon, 17 May 2021 12:22:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lig0u-00039p-8x for qemu-devel@nongnu.org; Mon, 17 May 2021 12:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621268559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oiS5jVWYWw4oyeA1HDAfN2vXptAW2AGn8HfdVAqeSEI=; b=Rc4leoHOZ1BoL/ttLXYaJo4du1W9pU606BgekzvQaRzhWF2/mClybCbZTsf3WPTlACA9b8 6yLfF4YTlVy+ciPb0knnr5RUXRanPhSweSt2mZb4osUsM0hN9D7fcMhiCMBAeEciWdCYdK mjZsmDt6uZM00YZQ4pZA1W4t11/zm00= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-RIgSIOKCPie17VQLPS4jMw-1; Mon, 17 May 2021 12:22:37 -0400 X-MC-Unique: RIgSIOKCPie17VQLPS4jMw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E937188E3CA; Mon, 17 May 2021 16:22:36 +0000 (UTC) Received: from gondolin.fritz.box (ovpn-115-195.ams2.redhat.com [10.36.115.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id D23902BCCF; Mon, 17 May 2021 16:22:34 +0000 (UTC) Date: Mon, 17 May 2021 18:22:32 +0200 From: Cornelia Huck To: Thomas Huth Subject: Re: [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main() Message-ID: <20210517182232.5ac23867.cohuck@redhat.com> In-Reply-To: <20210512171550.476130-4-thuth@redhat.com> References: <20210512171550.476130-1-thuth@redhat.com> <20210512171550.476130-4-thuth@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Christian Borntraeger , qemu-s390x@nongnu.org, Alex =?UTF-8?B?QmVubsOpZQ==?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 12 May 2021 19:15:50 +0200 Thomas Huth wrote: > Older versions of Clang complain if there is no prototype for main(). > Add one, and while we're at it, make sure that we use the same type > for main.c and netmain.c - since the return value does not matter, > declare the return type of main() as "void". > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/main.c | 3 +-- > pc-bios/s390-ccw/s390-ccw.h | 1 + > 2 files changed, 2 insertions(+), 2 deletions(-) It's probably not strictly needed for both to have the same prototype, but this looks sane to me. Reviewed-by: Cornelia Huck