From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEACBC433ED for ; Mon, 17 May 2021 19:05:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A4A361073 for ; Mon, 17 May 2021 19:05:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A4A361073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liiYW-00039a-Gu for qemu-devel@archiver.kernel.org; Mon, 17 May 2021 15:05:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiAB-0005mj-CJ for qemu-devel@nongnu.org; Mon, 17 May 2021 14:40:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiA1-0001oI-3U for qemu-devel@nongnu.org; Mon, 17 May 2021 14:40:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621276808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wKTvIJltaWyJ3tXssokHbyKTt2E/IQqH3Pybl80dLEU=; b=SdTacydVFveCYVcq9sk2lp+qy0RnwGDzYWf3qdqQZBUaMSvwQiBlEoDjeXZeWuTICKO0FT UipfWUsMWLC6vC5iJTt1+yVz83hf0+k+VpLLK+NL5nqgLBnq4kuIkSX9WjtDZS534GRXdQ JlNI7sEe4a/YHyqMD3hvLe14ntgEYG8= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-8H6i6RrBNNWiAb-9Pfq6LA-1; Mon, 17 May 2021 14:40:07 -0400 X-MC-Unique: 8H6i6RrBNNWiAb-9Pfq6LA-1 Received: by mail-ed1-f69.google.com with SMTP id d8-20020a0564020008b0290387d38e3ce0so4415551edu.1 for ; Mon, 17 May 2021 11:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wKTvIJltaWyJ3tXssokHbyKTt2E/IQqH3Pybl80dLEU=; b=jb6Bv9l8Z5hErGxIhT2hxvzyExVzVTH7vLexVlv5q7cfCcqHZuGdefBBBSvl1DEclN pN7CNoPFEj9zxV6bMwoHU8T+fkb+42LFm3mNPErw+nLalYWLcaTsKcMGaLgrFdVs7K78 hnlwpuhkoAj3nJzj7az8iD/bf1ktM9u1nyFY2HpKC8jkn/RdRryGfKYjeTPTMoGih/Pt 93m63YJQFk2CNPmWmPfH2irtJCPbVFIm+7HZl5jxKtg3GhSH0OYksK8+JgVkNCOb4cH9 5zSWZ5kcIHLsy1Ix/u7WuHI36wLWbNlSLUV6vF50E4jagw7yVPnEq0plYeWTqEndS9J0 9YCw== X-Gm-Message-State: AOAM531YAkqfZjxG46b3/JS1r7bhRtL7B0cGOt5s9UioRn5GewI5ukQe RwbKWOWrSbdHqqpoFL6120AL5KX38O4qk4jT8Rcoy7svc3YzBfxmYn1GgkkDE0cmUOn4BDAJnlL ghjWJI9fVMYoSY0vmT7WvUQBd8fsmcfBK28nPzIbgwKYKzZa32+i42bDSWt+ImlB9 X-Received: by 2002:a05:6402:2802:: with SMTP id h2mr1605999ede.243.1621276805956; Mon, 17 May 2021 11:40:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7jyf8vGOqGKZDXd4Jwn8QOQH9iiemYyUvrD4WA2OL7N4ZpGzz+VuDBv5XjUEDWISnYUSl3w== X-Received: by 2002:a05:6402:2802:: with SMTP id h2mr1605968ede.243.1621276805693; Mon, 17 May 2021 11:40:05 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id q16sm8866603edw.87.2021.05.17.11.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 11:40:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, John Snow Subject: [PATCH v4 2/9] hw/block/fdc: Replace disabled fprintf() by trace event Date: Mon, 17 May 2021 20:39:47 +0200 Message-Id: <20210517183954.1223193-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210517183954.1223193-1-philmd@redhat.com> References: <20210517183954.1223193-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Richard Henderson , Mark Cave-Ayland , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: John Snow Acked-by: Mark Cave-Ayland Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c | 7 +------ hw/block/trace-events | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a825c2acbae..1d3a0473678 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -1242,12 +1242,7 @@ static void fdctrl_external_reset_isa(DeviceState *d) static void fdctrl_handle_tc(void *opaque, int irq, int level) { - //FDCtrl *s = opaque; - - if (level) { - // XXX - FLOPPY_DPRINTF("TC pulsed\n"); - } + trace_fdctrl_tc_pulse(level); } /* Change IRQ state */ diff --git a/hw/block/trace-events b/hw/block/trace-events index fa12e3a67a7..306989c193c 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -3,6 +3,7 @@ # fdc.c fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x" fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x" +fdctrl_tc_pulse(int level) "TC pulse: %u" # pflash_cfi01.c # pflash_cfi02.c -- 2.26.3