From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE50FC433B4 for ; Tue, 18 May 2021 09:50:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B43D7613F7 for ; Tue, 18 May 2021 09:50:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B43D7613F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liwMj-0006Ro-S0 for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 05:50:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liwDy-0002HM-8q for qemu-devel@nongnu.org; Tue, 18 May 2021 05:41:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liwDv-0007tx-CW for qemu-devel@nongnu.org; Tue, 18 May 2021 05:41:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621330870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jfgyIEhnnmbAcUhYULfi8YfeRc/0cLR+h24cPPO1H7I=; b=BJhpozvGDHydcfT+Wx9x0jyLQaprYgg5fU4oH2pyzfndBkwJG/GpJ2K2JTfEEaaygp4TCu OWjiQCitagPuGK/SEXpNC36n5eMmkM5cz4Ba9C0qGknZ62iTakrMouRdsc9DKdVNQHjhzA +/ygZ7bcBKKUwaRvSVM/G+oZnjC/1V8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-IjEf3UW7NVOjFul-hPqPwg-1; Tue, 18 May 2021 05:41:07 -0400 X-MC-Unique: IjEf3UW7NVOjFul-hPqPwg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2DAA180FD64; Tue, 18 May 2021 09:41:06 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-236.ams2.redhat.com [10.36.114.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 322D12ED60; Tue, 18 May 2021 09:40:59 +0000 (UTC) From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Subject: [PATCH v2 0/5] block-copy: make helper APIs thread safe Date: Tue, 18 May 2021 11:40:53 +0200 Message-Id: <20210518094058.25952-1-eesposit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Received-SPF: pass client-ip=170.10.133.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Emanuele Giuseppe Esposito , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This serie of patches bring thread safety to the smaller APIs used by block-copy, namely ratelimit, progressmeter, co-shared-resource and aiotask. The end goal is to reduce the usage of AioContexlock in block-copy, by introducing smaller granularity locks thus on making the block layer thread safe. This serie depends on Paolo's coroutine_sleep API. What's missing for block-copy to be fully thread-safe is fixing the CoSleep API to allow cross-thread sleep and wakeup. Paolo is working on it and will post the patches once his new CoSleep API is accepted. Patches 1-3 work on ratelimit (they are also based on the first ratelimit patch sent by Paolo), 4 covers progressmeter and 5 co-shared-resources. Based-on: <20210503112550.478521-1-pbonzini@redhat.com> Based-on: <20210413125533.217440-1-pbonzini@redhat.com> Signed-off-by: Emanuele Giuseppe Esposito --- v1 -> v2: * Implement progressmeter as a separate .c file (was just an header), but keep the struct public, to avoid heap allocations [Vladimir, Paolo] * Drop for now the Aiopool patches of v2 [Paolo, Stefan] Emanuele Giuseppe Esposito (2): progressmeter: protect with a mutex co-shared-resource: protect with a mutex Paolo Bonzini (3): ratelimit: treat zero speed as unlimited block-copy: let ratelimit handle a speed of 0 blockjob: let ratelimit handle a speed of 0 block/block-copy.c | 28 ++++++-------- block/meson.build | 1 + block/progress_meter.c | 64 +++++++++++++++++++++++++++++++ blockjob.c | 46 +++++++++++++--------- include/qemu/co-shared-resource.h | 4 +- include/qemu/progress_meter.h | 34 ++++++++-------- include/qemu/ratelimit.h | 12 +++++- job-qmp.c | 8 +++- job.c | 3 ++ qemu-img.c | 9 +++-- util/qemu-co-shared-resource.c | 27 ++++++++++--- 11 files changed, 171 insertions(+), 65 deletions(-) create mode 100644 block/progress_meter.c -- 2.30.2