From: Eduardo Habkost <ehabkost@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org,
Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>,
Denis Lunev <den@openvz.org>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v8] qapi: introduce 'query-kvm-cpuid' action
Date: Wed, 2 Jun 2021 17:01:06 -0400 [thread overview]
Message-ID: <20210602210106.aahfqxu7cvxr5otx@habkost.net> (raw)
In-Reply-To: <20210602205102.icdqspki66rwvc3n@redhat.com>
On Wed, Jun 02, 2021 at 03:51:02PM -0500, Eric Blake wrote:
> On Mon, May 31, 2021 at 03:38:06PM +0300, Valeriy Vdovin wrote:
[...]
> > +##
> > +# @CpuidEntry:
> > +#
> > +# A single entry of a CPUID response.
> > +#
> > +# One entry holds full set of information (leaf) returned to the guest in response
> > +# to it calling a CPUID instruction with eax, ecx used as the agruments to that
>
> arguments
>
> > +# instruction. ecx is an optional argument as not all of the leaves support it.
>
> Is there a default value of ecx for when it is not provided by the
> user but needed by the leaf? Or is it an error if ecx is omitted in
> that case? Similarly, is it an error if ecx is provided but not
> needed?
What does "not provided by the user" mean here? This is not
describing the input to a QMP command, but the input to the CPUID
instruction.
--
Eduardo
next prev parent reply other threads:[~2021-06-02 21:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 12:38 [PATCH v8] qapi: introduce 'query-kvm-cpuid' action Valeriy Vdovin
2021-06-02 12:24 ` Vladimir Sementsov-Ogievskiy
2021-06-02 18:17 ` Philippe Mathieu-Daudé
2021-06-02 20:46 ` Eduardo Habkost
2021-06-02 23:24 ` Philippe Mathieu-Daudé
2021-06-02 20:51 ` Eric Blake
2021-06-02 21:01 ` Eduardo Habkost [this message]
2021-06-03 8:21 ` Valeriy Vdovin
2021-06-08 15:14 ` Markus Armbruster
2021-06-08 15:27 ` Valeriy Vdovin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602210106.aahfqxu7cvxr5otx@habkost.net \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=valeriy.vdovin@virtuozzo.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).