From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281E4C48BE8 for ; Tue, 15 Jun 2021 15:47:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A76B6148E for ; Tue, 15 Jun 2021 15:47:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A76B6148E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltBHa-0000QW-G3 for qemu-devel@archiver.kernel.org; Tue, 15 Jun 2021 11:47:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltBEt-0005ou-Rp for qemu-devel@nongnu.org; Tue, 15 Jun 2021 11:44:35 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:38650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltBEa-0000uj-Gm for qemu-devel@nongnu.org; Tue, 15 Jun 2021 11:44:31 -0400 Received: by mail-wr1-x432.google.com with SMTP id c9so18861664wrt.5 for ; Tue, 15 Jun 2021 08:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=2FN+DLCkRaewYYSAAvTveP7CUhTuCt0YRLwdFHpiWrg=; b=SwOZcToum7CpXllqNqZaO2CK3e5CMxqWfw+SGK3oRnN82zGIw6074AOVKYoOAgKgL6 +4gpEkln+B7GbiaBC2dK+7Kt5x+20Sot4jzu37fh3UCA1Z/n1zj8RXTlCn6lh7g0QTv2 YvCOS7wDDwBzaelaLlWaGOqnCpHQSqbSGKEqSQi4z7MRNe1vKzCZ2eUapHlhrIp0Z7ur wfQHP1yeigPJ9OJFbcekIlZxnqROm/a1tbwcBg20VUPISwoR9ytsrEyZTE531rlLGqxr FtooJVo3lD1KIeUWiOyjYk584ngdZu5LDgj5JCjRQleKxG5vqTrME/8pWUvhu3YZSCGV vXFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2FN+DLCkRaewYYSAAvTveP7CUhTuCt0YRLwdFHpiWrg=; b=l1Cecaic3CRKXq47NFLcZlqYSNFoEF22Z9JHOLARvVCmwyWvq4saBsUAqVxxEVcsFy tuhQhLDCt8H9HeonVQ7mJt/X9YFeLyPpNf3YtEGBNGX6zXWAUCky0iMW47IuUCtFStw8 AthqivMJvROTAm8rDgOoohBrCf/aAGj17Nlix5rwpwkQX+2aq1W1WJNiJ1EL9WGO5xEU eQW9th5qwNwlcvKZ5ySnfYbw02gP1h2yOgpyCoNBORl3sraVk9BrIfcTYE0Iz5GHExmc eHU7Fs8FTR2lK1XwYXwyJP2esA1LXfHikJmamHN8+SveDpVpzrzfoY6re9DQlhiw6rXb tbDw== X-Gm-Message-State: AOAM533WWOjatrdHvTa0Q6QWPAhsfUTF42OkkwAHSn7qSf16fjYr6HdQ sV3SuvgtzBk5FrDe5+KuGgG1TNui93JGVg== X-Google-Smtp-Source: ABdhPJx7CQTFmtXejD7c5dXSeogwDWgt9V9SJfGqBpE+EMsCM80AkYGrJlSCiLdh2B5r7hprEuNgMg== X-Received: by 2002:adf:ce90:: with SMTP id r16mr26696426wrn.146.1623771850334; Tue, 15 Jun 2021 08:44:10 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id d15sm18985662wri.58.2021.06.15.08.44.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 08:44:09 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 02/28] target/arm: Diagnose UNALLOCATED in disas_simd_two_reg_misc_fp16 Date: Tue, 15 Jun 2021 16:43:39 +0100 Message-Id: <20210615154405.21399-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210615154405.21399-1-peter.maydell@linaro.org> References: <20210615154405.21399-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson This fprintf+assert has been in place since the beginning. It is prior to the fp_access_check, so we're still good to raise sigill here. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/381 Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210604183506.916654-2-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 8713dfec174..2477b55c53a 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -13234,8 +13234,8 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) case 0x7f: /* FSQRT (vector) */ break; default: - fprintf(stderr, "%s: insn 0x%04x fpop 0x%2x\n", __func__, insn, fpop); - g_assert_not_reached(); + unallocated_encoding(s); + return; } -- 2.20.1