From: Corey Minyard <cminyard@mvista.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Signed-off-by : Frederic Konrad" <frederic.konrad@adacore.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 00/13] hw/i2c: Remove confusing i2c_send_recv() API
Date: Wed, 16 Jun 2021 14:28:58 -0500 [thread overview]
Message-ID: <20210616192858.GG11196@minyard.net> (raw)
In-Reply-To: <20210616161418.2514095-1-f4bug@amsat.org>
On Wed, Jun 16, 2021 at 06:14:05PM +0200, Philippe Mathieu-Daudé wrote:
> This is a respin of Zoltan's patch:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg714711.html
>
> Since v2, tried to address Corey's review comments resulting
> in a i2c_send_recv() removal and code easier to review (to my
> taste at least).
Yes, this is much better. I had a few minor comments, and Richard did,
too, but with those fixed this is a big improvement over the existing
code.
I can give you an:
Acked-by: Corey Minyard <cminyard@mvista.com>
for all of these, or I can take them into my tree. I'm fine either way.
-corey
>
> Supersedes: <20200623063123.20776-1-f4bug@amsat.org>
>
> BALATON Zoltan (1):
> hw/i2c: Make i2c_start_transfer() direction argument a boolean
>
> Philippe Mathieu-Daudé (12):
> hw/input/lm832x: Move lm832x_key_event() declaration to "lm832x.h"
> hw/input/lm832x: Define TYPE_LM8323 in public header
> hw/display/sm501: Simplify sm501_i2c_write() logic
> hw/display/sm501: Replace i2c_send_recv() by i2c_recv() & i2c_send()
> hw/i2c/ppc4xx_i2c: Add reference to datasheet
> hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send()
> hw/misc/auxbus: Fix MOT/classic I2C mode
> hw/misc/auxbus: Explode READ_I2C / WRITE_I2C_MOT cases
> hw/misc/auxbus: Replace 'is_write' boolean by its value
> hw/misc/auxbus: Replace i2c_send_recv() by i2c_recv() & i2c_send()
> hw/i2c: Remove confusing i2c_send_recv()
> hw/i2c: Rename i2c_set_slave_address() -> i2c_slave_set_address()
>
> include/hw/i2c/i2c.h | 21 +++++++++---
> include/hw/input/lm832x.h | 28 ++++++++++++++++
> hw/arm/nseries.c | 3 +-
> hw/arm/pxa2xx.c | 2 +-
> hw/arm/spitz.c | 4 +--
> hw/display/ati.c | 2 +-
> hw/display/sm501.c | 16 +++++----
> hw/display/xlnx_dp.c | 2 +-
> hw/i2c/core.c | 56 ++++++++++++++-----------------
> hw/i2c/imx_i2c.c | 2 +-
> hw/i2c/ppc4xx_i2c.c | 15 ++++++---
> hw/input/lm832x.c | 2 +-
> hw/misc/auxbus.c | 69 +++++++++++++++++++++++++++++----------
> MAINTAINERS | 1 +
> 14 files changed, 149 insertions(+), 74 deletions(-)
> create mode 100644 include/hw/input/lm832x.h
>
> --
> 2.31.1
>
prev parent reply other threads:[~2021-06-16 19:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 16:14 [PATCH v3 00/13] hw/i2c: Remove confusing i2c_send_recv() API Philippe Mathieu-Daudé
2021-06-16 16:14 ` [PATCH v3 01/13] hw/input/lm832x: Move lm832x_key_event() declaration to "lm832x.h" Philippe Mathieu-Daudé
2021-06-16 18:38 ` Richard Henderson
2021-06-16 19:23 ` Philippe Mathieu-Daudé
2021-06-16 16:14 ` [PATCH v3 02/13] hw/input/lm832x: Define TYPE_LM8323 in public header Philippe Mathieu-Daudé
2021-06-16 18:39 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 03/13] hw/display/sm501: Simplify sm501_i2c_write() logic Philippe Mathieu-Daudé
2021-06-16 18:39 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 04/13] hw/display/sm501: Replace i2c_send_recv() by i2c_recv() & i2c_send() Philippe Mathieu-Daudé
2021-06-16 18:40 ` Richard Henderson
2021-06-16 19:14 ` Corey Minyard
2021-06-16 16:14 ` [PATCH v3 05/13] hw/i2c/ppc4xx_i2c: Add reference to datasheet Philippe Mathieu-Daudé
2021-06-16 18:40 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 06/13] hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send() Philippe Mathieu-Daudé
2021-06-16 18:41 ` Richard Henderson
2021-06-16 19:16 ` Corey Minyard
2021-06-16 19:25 ` Philippe Mathieu-Daudé
2021-06-16 20:01 ` BALATON Zoltan
2021-06-16 20:28 ` Philippe Mathieu-Daudé
2021-06-16 23:09 ` BALATON Zoltan
2021-06-16 23:42 ` Corey Minyard
2021-06-17 23:49 ` BALATON Zoltan
2021-06-18 8:54 ` Philippe Mathieu-Daudé
2021-06-16 16:14 ` [PATCH v3 07/13] hw/misc/auxbus: Fix MOT/classic I2C mode Philippe Mathieu-Daudé
2021-06-16 18:41 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 08/13] hw/misc/auxbus: Explode READ_I2C / WRITE_I2C_MOT cases Philippe Mathieu-Daudé
2021-06-16 18:41 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 09/13] hw/misc/auxbus: Replace 'is_write' boolean by its value Philippe Mathieu-Daudé
2021-06-16 18:43 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 10/13] hw/misc/auxbus: Replace i2c_send_recv() by i2c_recv() & i2c_send() Philippe Mathieu-Daudé
2021-06-16 18:46 ` Richard Henderson
2021-06-16 19:28 ` Philippe Mathieu-Daudé
2021-06-16 20:06 ` BALATON Zoltan
2021-06-16 16:14 ` [PATCH v3 11/13] hw/i2c: Remove confusing i2c_send_recv() Philippe Mathieu-Daudé
2021-06-16 18:47 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 12/13] hw/i2c: Rename i2c_set_slave_address() -> i2c_slave_set_address() Philippe Mathieu-Daudé
2021-06-16 18:50 ` Richard Henderson
2021-06-16 16:14 ` [PATCH v3 13/13] hw/i2c: Make i2c_start_transfer() direction argument a boolean Philippe Mathieu-Daudé
2021-06-16 19:02 ` Richard Henderson
2021-06-16 19:28 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616192858.GG11196@minyard.net \
--to=cminyard@mvista.com \
--cc=f4bug@amsat.org \
--cc=frederic.konrad@adacore.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).