From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: edgar.iglesias@gmail.com
Subject: [PATCH 8/9] target/cris: Use movcond for t_gen_cc_jmp
Date: Sat, 19 Jun 2021 21:21:40 -0700 [thread overview]
Message-ID: <20210620042141.1235541-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210620042141.1235541-1-richard.henderson@linaro.org>
This is better than branch around assignment.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/cris/translate.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target/cris/translate.c b/target/cris/translate.c
index 3515c21b7b..e4cbc35ebd 100644
--- a/target/cris/translate.c
+++ b/target/cris/translate.c
@@ -516,13 +516,9 @@ static void t_gen_swapr(TCGv d, TCGv s)
static void t_gen_cc_jmp(TCGv pc_true, TCGv pc_false)
{
- TCGLabel *l1 = gen_new_label();
-
/* Conditional jmp. */
- tcg_gen_mov_tl(env_pc, pc_false);
- tcg_gen_brcondi_tl(TCG_COND_EQ, env_btaken, 0, l1);
- tcg_gen_mov_tl(env_pc, pc_true);
- gen_set_label(l1);
+ tcg_gen_movcond_tl(TCG_COND_NE, env_pc, env_btaken, tcg_constant_tl(0),
+ pc_true, pc_false);
}
static inline bool use_goto_tb(DisasContext *dc, target_ulong dest)
--
2.25.1
next prev parent reply other threads:[~2021-06-20 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 4:21 [PATCH 0/9] target/cris: Convert to TranslatorOps Richard Henderson
2021-06-20 4:21 ` [PATCH 1/9] target/cris: Add DisasContextBase to DisasContext Richard Henderson
2021-06-20 4:21 ` [PATCH 2/9] target/cris: Replace DISAS_TB_JUMP with DISAS_NORETURN Richard Henderson
2021-06-20 4:21 ` [PATCH 3/9] target/cris: Mark exceptions as DISAS_NORETURN Richard Henderson
2021-06-20 4:21 ` [PATCH 4/9] target/cris: Remove DISAS_SWI Richard Henderson
2021-06-20 4:21 ` [PATCH 5/9] target/cris: Convert to TranslatorOps Richard Henderson
2021-06-20 4:21 ` [PATCH 6/9] target/cris: Mark helper_raise_exception noreturn Richard Henderson
2021-06-20 4:21 ` [PATCH 7/9] target/cris: Mark static arrays const Richard Henderson
2021-06-20 4:21 ` Richard Henderson [this message]
2021-06-20 4:21 ` [PATCH 9/9] target/cris: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210620042141.1235541-9-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).