From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5A5C48BC2 for ; Mon, 21 Jun 2021 13:39:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0748760249 for ; Mon, 21 Jun 2021 13:39:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0748760249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvK9R-0007kk-S5 for qemu-devel@archiver.kernel.org; Mon, 21 Jun 2021 09:39:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvIbK-0007mh-VY for qemu-devel@nongnu.org; Mon, 21 Jun 2021 08:00:28 -0400 Received: from mail-mw2nam12on2046.outbound.protection.outlook.com ([40.107.244.46]:43864 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvIbE-0000Wq-39 for qemu-devel@nongnu.org; Mon, 21 Jun 2021 08:00:26 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UamtqBZFxSIAP0O96a3R33RanCFQDCK7hwkA83cL/0H9Qai+8BzP4Ffyowc/jsgabxr0SkcYwbI5fX1SwyHe8AnfY7iDOFkLrpslHpNsnx+xFpvdpyG20j5wPs1BRvBkHOzVPsw8zO7LoCN3L/ZnG/tqlmEVJxB8J07UxL5lpLIVic+tn1AI53AE2uCKEWvGzL8vykiWh5wnulQ8rj8uR2PgVUGbTNjYqcGtdupdyxOB4Cf1pJjSsS/hL4vSuG0cWbLj8P3WlUp2EUplW3basTOCd9iMJyWeKUb3NWrlARgUejnZkBnP9WL7G6QtJ+JgKxNF2HUcZS3UllkqFeWcmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cycjTYasQeoo1+jrhQm75YcxcTZPiIG+4GepVHPZUUU=; b=Fj+BHh5KAlCvjQL8l/7bB4VCY7yhzZ2FErmFRjF0iEQTwGmZNvKEO748tOHcx1SPsviTiKEqWLXrvlRIOi6vaRQX9U0SacOxq7lCE0Dv280ZWE2COPLJAFbbN52lk1Io7KGix279VjnD9WQFdnhEZzTjoBAxiuOdTK5iipNSoKQusc1JZHpftQ1xG9Srrd4xcm8J/Mu2aTMTmBdqCeCLzJKeRFMLrM4e1XLIK0owRk6Ns0YzGuDC7wL5v+nGcx/8H7LlvCHeFhbFPCLJkp8kZ/b1/nshorKEOpRZLAPoDQoORE0KpOlLzRHL6rS/y4Je+UkghSrPemRJCJuooI0uYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cycjTYasQeoo1+jrhQm75YcxcTZPiIG+4GepVHPZUUU=; b=IBN8GbqrwhM1ByVO0A1t0LfCKReullIV5erDi7r9gl6l/adtwpoLXS7PiEGrwhqTYHMNcf3VGSCjxTkir+jUl17+w+Ligyh/zIyvJ7Zr2ZqGIDpCvd/J/TAr2I5AC/aoeCXu2IlQSFZK/867py+U0l9UqJAafTlMjgzSlLwl0GKB6Wp6xw5U1kwVQbMiXRVw2WChEddpN4E+4mNo6PwjWHDAHbhjWQX59eIvWVPQcid40rkwVRTmxy5e14Bf2w0oWVV9u3hAclKz1Fe0Pe3m/ByU05vTwJsjZuVJgi+0pRNwz+eTE2ktrHYSbe6vKvbPyeS2QzgfGe9an5lWYhGkhg== Received: from DM6PR08CA0059.namprd08.prod.outlook.com (2603:10b6:5:1e0::33) by CH2PR12MB3767.namprd12.prod.outlook.com (2603:10b6:610:26::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Mon, 21 Jun 2021 11:45:13 +0000 Received: from DM6NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1e0:cafe::1d) by DM6PR08CA0059.outlook.office365.com (2603:10b6:5:1e0::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15 via Frontend Transport; Mon, 21 Jun 2021 11:45:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT031.mail.protection.outlook.com (10.13.172.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4242.16 via Frontend Transport; Mon, 21 Jun 2021 11:45:13 +0000 Received: from mtl-vdi-166.wap.labs.mlnx (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Jun 2021 11:45:10 +0000 Date: Mon, 21 Jun 2021 14:45:06 +0300 From: Eli Cohen To: Jason Wang Subject: Re: [PATCH 01/18] vhost_net: remove the meaningless assignment in vhost_net_start_one() Message-ID: <20210621114506.GA143139@mtl-vdi-166.wap.labs.mlnx> References: <20210621041650.5826-1-jasowang@redhat.com> <20210621041650.5826-2-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210621041650.5826-2-jasowang@redhat.com> User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13) X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de526ebf-54ea-4ac4-fadb-08d934aa07fd X-MS-TrafficTypeDiagnostic: CH2PR12MB3767: X-Microsoft-Antispam-PRVS: X-MS-Exchange-Transport-Forked: True X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0PT9PaFb2yaB+AU2Oraw4WCze/mVSSf20xl54Ykib8Iwa5BCMf1XgHINKKkeHnu+0EioYaEIE6+vORiSaEELeTO3JyQcVUgNB24eRUMs4chUKQnsZNf0WtLnocVaUNRvOlTidqd9cPRfNljdgu8x/xWGba71Vu86avfDzcshf3AlDnX/MCfi9q76xxYTA/gcN2xFnvQozD5+45t2sAAiKpRks5QRNObV2/fgB9Kx0qsuADyhRRG1TPCHVLj/H07a2svJto75m17HgxM2j2qlzhSJQsfgnHT5jPgs5gd4MElDTQOzDmctNJXHF1kzDKuMIeRVjxFPJtYSENwD3fAZ48LT7MiYPSrxa0DMfu1tYm2QHB9w1CUvGXE0RYNYieB+q699jKRfWOoZZE7gpA7a3pEcVoELJ/bMlIDnm65SFDrWRwzEI3ScYJSqx2+hFZDtZN3WBaIxstcZLFDgCfq/sHQUYFGbiH9gYUU/i82ldLYPqaP7c1rSfxmt5nf9Dsa6rFIrD80ifKMW6YnCtvDJNXFXdCm+NkOsNUC5gPPWFjlYu1AMc7ifcvWzPP0lN1/iiW8NtHFaHzBmf7D1/jYXyv8gRMLXdT2zeJg+cztNnERFGfWBRz1nMnvcLUHGr3XvNa1tY7UgnsMihxfQPkXfEsaQbFwHooPTt99Hv2k92TU= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(376002)(346002)(36840700001)(46966006)(6666004)(2906002)(26005)(83380400001)(70206006)(7696005)(70586007)(47076005)(86362001)(186003)(82310400003)(4326008)(478600001)(16526019)(54906003)(9686003)(55016002)(356005)(82740400003)(426003)(316002)(5660300002)(7636003)(336012)(8676002)(33656002)(1076003)(36906005)(36860700001)(6916009)(4744005)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2021 11:45:13.1806 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de526ebf-54ea-4ac4-fadb-08d934aa07fd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3767 Received-SPF: softfail client-ip=40.107.244.46; envelope-from=elic@nvidia.com; helo=NAM12-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.373, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 21 Jun 2021 09:34:25 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eperezma@redhat.com, lingshan.zhu@intel.com, qemu-devel@nongnu.org, lulu@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 21, 2021 at 12:16:33PM +0800, Jason Wang wrote: > The nvqs and vqs has been initialized during vhost_net_init() and is I suggest "nvqs and vqs have been initialized during vhost_net_init() and are not..." Other than that Reviewed-by: Eli Cohen > not expected to change during the life cycle of vhost_net > structure. So this patch removes the meaningless assignment. > > Signed-off-by: Jason Wang > --- > hw/net/vhost_net.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index 44c1ed92dc..6bd4184f96 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -238,9 +238,6 @@ static int vhost_net_start_one(struct vhost_net *net, > struct vhost_vring_file file = { }; > int r; > > - net->dev.nvqs = 2; > - net->dev.vqs = net->vqs; > - > r = vhost_dev_enable_notifiers(&net->dev, dev); > if (r < 0) { > goto fail_notifiers; > -- > 2.25.1 >