From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH v2 21/29] target/arm: Improve REV32
Date: Mon, 21 Jun 2021 16:18:41 -0700 [thread overview]
Message-ID: <20210621231849.1871164-22-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210621231849.1871164-1-richard.henderson@linaro.org>
For the sf version, we are performing two 32-bit bswaps
in either half of the register. This is equivalent to
performing one 64-bit bswap followed by a rotate.
For the non-sf version, we can remove TCG_BSWAP_IZ
and the preceding zero-extension.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate-a64.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index f2641a37ba..304fd3d370 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -5430,22 +5430,13 @@ static void handle_rev32(DisasContext *s, unsigned int sf,
unsigned int rn, unsigned int rd)
{
TCGv_i64 tcg_rd = cpu_reg(s, rd);
+ TCGv_i64 tcg_rn = cpu_reg(s, rn);
if (sf) {
- TCGv_i64 tcg_tmp = tcg_temp_new_i64();
- TCGv_i64 tcg_rn = read_cpu_reg(s, rn, sf);
-
- /* bswap32_i64 requires zero high word */
- tcg_gen_ext32u_i64(tcg_tmp, tcg_rn);
- tcg_gen_bswap32_i64(tcg_rd, tcg_tmp, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
- tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32);
- tcg_gen_bswap32_i64(tcg_tmp, tcg_tmp, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
- tcg_gen_concat32_i64(tcg_rd, tcg_rd, tcg_tmp);
-
- tcg_temp_free_i64(tcg_tmp);
+ tcg_gen_bswap64_i64(tcg_rd, tcg_rn);
+ tcg_gen_rotri_i64(tcg_rd, tcg_rd, 32);
} else {
- tcg_gen_ext32u_i64(tcg_rd, cpu_reg(s, rn));
- tcg_gen_bswap32_i64(tcg_rd, tcg_rd, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
+ tcg_gen_bswap32_i64(tcg_rd, tcg_rn, TCG_BSWAP_OZ);
}
}
--
2.25.1
next prev parent reply other threads:[~2021-06-21 23:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 23:18 [PATCH v2 00/29] tcg: bswap improvements Richard Henderson
2021-06-21 23:18 ` [PATCH v2 01/29] tcg: Add flags argument to bswap opcodes Richard Henderson
2021-06-21 23:18 ` [PATCH v2 02/29] tcg/i386: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 03/29] tcg/aarch64: Merge tcg_out_rev{16,32,64} Richard Henderson
2021-06-21 23:18 ` [PATCH v2 04/29] tcg/aarch64: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 05/29] tcg/arm: " Richard Henderson
2021-06-21 23:18 ` [PATCH v2 06/29] tcg/ppc: Split out tcg_out_ext{8,16,32}s Richard Henderson
2021-06-21 23:18 ` [PATCH v2 07/29] tcg/ppc: Split out tcg_out_sari{32,64} Richard Henderson
2021-06-21 23:18 ` [PATCH v2 08/29] tcg/ppc: Split out tcg_out_bswap16 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 09/29] tcg/ppc: Split out tcg_out_bswap32 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 10/29] tcg/ppc: Split out tcg_out_bswap64 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 11/29] tcg/ppc: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 12/29] tcg/ppc: Use power10 byte-reverse instructions Richard Henderson
2021-06-21 23:18 ` [PATCH v2 13/29] tcg/s390: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 14/29] tcg/mips: Support bswap flags in tcg_out_bswap16 Richard Henderson
2021-06-22 6:48 ` Philippe Mathieu-Daudé
2021-06-21 23:18 ` [PATCH v2 15/29] tcg/mips: Support bswap flags in tcg_out_bswap32 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 16/29] tcg/tci: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 17/29] tcg: Handle new bswap flags during optimize Richard Henderson
2021-06-21 23:18 ` [PATCH v2 18/29] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 19/29] tcg: Make use of bswap flags in tcg_gen_qemu_ld_* Richard Henderson
2021-06-22 6:46 ` Philippe Mathieu-Daudé
2021-06-21 23:18 ` [PATCH v2 20/29] tcg: Make use of bswap flags in tcg_gen_qemu_st_* Richard Henderson
2021-06-21 23:18 ` Richard Henderson [this message]
2021-06-21 23:18 ` [PATCH v2 22/29] target/arm: Improve vector REV Richard Henderson
2021-06-22 6:47 ` Philippe Mathieu-Daudé
2021-06-21 23:18 ` [PATCH v2 23/29] target/arm: Improve REVSH Richard Henderson
2021-06-21 23:18 ` [PATCH v2 24/29] target/i386: Improve bswap translation Richard Henderson
2021-06-21 23:18 ` [PATCH v2 25/29] target/sh4: Improve swap.b translation Richard Henderson
2021-06-21 23:18 ` [PATCH v2 26/29] target/mips: Fix gen_mxu_s32ldd_s32lddr Richard Henderson
2021-06-21 23:18 ` [PATCH v2 27/29] tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP Richard Henderson
2021-06-21 23:18 ` [PATCH v2 28/29] tcg/aarch64: " Richard Henderson
2021-06-21 23:18 ` [PATCH v2 29/29] tcg/riscv: Remove MO_BSWAP handling Richard Henderson
2021-06-21 23:45 ` [PATCH v2 00/29] tcg: bswap improvements no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621231849.1871164-22-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).