qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Aurelien Jarno" <aurelien@aurel32.net>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 02/15] target/mips: Fix TCG temporary leaks in gen_pool32a5_nanomips_insn()
Date: Fri, 25 Jun 2021 11:23:16 +0200	[thread overview]
Message-ID: <20210625092329.1529100-3-f4bug@amsat.org> (raw)
In-Reply-To: <20210625092329.1529100-1-f4bug@amsat.org>

Fix a pair of TCG temporary leak when translating nanoMIPS SHILO opcode.

Fixes: 3285a3e4445 ("target/mips: Add emulation of DSP ASE for nanoMIPS")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210530094538.1275329-1-f4bug@amsat.org>
---
 target/mips/tcg/translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
index 797eba44347..120484a6c06 100644
--- a/target/mips/tcg/translate.c
+++ b/target/mips/tcg/translate.c
@@ -20182,6 +20182,8 @@ static void gen_pool32a5_nanomips_insn(DisasContext *ctx, int opc,
             tcg_gen_movi_tl(tv0, rd >> 3);
             tcg_gen_movi_tl(tv1, imm);
             gen_helper_shilo(tv0, tv1, cpu_env);
+            tcg_temp_free(tv1);
+            tcg_temp_free(tv0);
         }
         break;
     case NM_MULEQ_S_W_PHL:
-- 
2.31.1



  parent reply	other threads:[~2021-06-25  9:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  9:23 [PULL 00/15] MIPS patches for 2021-06-25 Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 01/15] target/mips: Fix potential integer overflow (CID 1452921) Philippe Mathieu-Daudé
2021-06-25  9:23 ` Philippe Mathieu-Daudé [this message]
2021-06-25  9:23 ` [PULL 03/15] target/mips: Fix more TCG temporary leaks in gen_pool32a5_nanomips_insn Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 04/15] target/mips: Raise exception when DINSV opcode used with DSP disabled Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 05/15] target/mips: Do not abort on invalid instruction Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 06/15] target/mips: Move TCG trace events to tcg/ sub directory Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 07/15] target/mips: Move translate.h " Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 08/15] target/mips: Restrict some system specific declarations to sysemu Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 09/15] target/mips: Remove SmartMIPS / MDMX unuseful comments Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 10/15] target/mips: Remove microMIPS BPOSGE32 / BPOSGE64 unuseful cases Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 11/15] target/mips: fix emulation of nanoMIPS BPOSGE32 instruction Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 12/15] target/mips: Constify host_to_mips_errno[] Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 13/15] target/mips: Optimize regnames[] arrays Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 14/15] target/mips: Remove pointless gen_msa() Philippe Mathieu-Daudé
2021-06-25  9:23 ` [PULL 15/15] target/mips: Merge msa32/msa64 decodetree definitions Philippe Mathieu-Daudé
2021-06-28 13:00 ` [PULL 00/15] MIPS patches for 2021-06-25 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625092329.1529100-3-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).