From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF843C49EA6 for ; Sat, 26 Jun 2021 06:49:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74E3061931 for ; Sat, 26 Jun 2021 06:49:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74E3061931 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lx28I-0000ao-ED for qemu-devel@archiver.kernel.org; Sat, 26 Jun 2021 02:49:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lx1vs-0002GB-LF for qemu-devel@nongnu.org; Sat, 26 Jun 2021 02:36:48 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:39640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lx1vq-0000Og-2y for qemu-devel@nongnu.org; Sat, 26 Jun 2021 02:36:48 -0400 Received: by mail-pj1-x1034.google.com with SMTP id c7-20020a17090ad907b029016faeeab0ccso9275567pjv.4 for ; Fri, 25 Jun 2021 23:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hFW7/uteqhUz14as6VIJ+oMkuxFCaj8xI5hXiJ/YKgI=; b=opJ0aLsfE5Pb7FTPTROT99mqdIBmstNhPgLMr4KLDjIIVbi7dosTml/Ha5+xoGf1Ay YKWSc6eM1nYEzi6mKPKdMQC/uoZvAeA3jDcwHoONI4oUYfDeZGoTcUjRztk5aluBImqI Er5vW/nch8VKWR0oGCScf0Uir+wOkScrCUymve5wP0D/qEXCrIZ4LA2fJRLE2nw8H/e0 vIhs14HtehrW7PbjX4WBlnyL1v7BIH23S3bV+MtqWdiRMiZYzJkPZfKHvDum7D+cJJU/ OD5uETUlsr2wQgSHPcx/CTQ8RDO6Xt5kF4UMzY4qPQtfQFwlK9fzFq5+xN/JZ3RaWWdI Xdsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hFW7/uteqhUz14as6VIJ+oMkuxFCaj8xI5hXiJ/YKgI=; b=eRPO+zOfJliK/Y3h6rBXZvSPiEMbmYGkswXJBGhsI/+6Ep9iLixVKexj1u02yK3n0o b55Td9J2iVLm/IjDmKBT5FTpok2PmzA/QVu/T+hs+jLcfb/8n5GsfPIEJQfjjB5ifaSf Fe5cQhqElbogwQzrQmfr1GF/LQEp6KG0T4Ne+nHCapiL/HERY0TLmDaBfMJCOADngsNE 7dx8l2hFYCHoC4WX61RybCxoaqiHwUc805DWFJEOTWje8HW28TmrypBx8R+Jl+QomQot 0FMWzwvCPJ2/LfZDvO38hr2bAtvOj+51JVvmC1LhutcJoemKkatCtDB51CUrJvOj158A uC0g== X-Gm-Message-State: AOAM530EAKwGDTYB6kSg1zndFVztqSpLe+A5qYhwW9Xn3VdqekO7vPan cCze/3lfCDkLX9fgSYy/mMpA6Q7q3rv8JQ== X-Google-Smtp-Source: ABdhPJxPVrqT7O0+5ngmsuSU+0T0nvYK0pmJMZm2g4ditzjn8R3x5/cSV+RMcqBXSRZ4S3W+n/6VgA== X-Received: by 2002:a17:90a:3d47:: with SMTP id o7mr25364776pjf.68.1624689404700; Fri, 25 Jun 2021 23:36:44 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id v9sm7724201pgq.54.2021.06.25.23.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 23:36:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 20/29] tcg: Make use of bswap flags in tcg_gen_qemu_st_* Date: Fri, 25 Jun 2021 23:36:22 -0700 Message-Id: <20210626063631.2411938-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210626063631.2411938-1-richard.henderson@linaro.org> References: <20210626063631.2411938-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" By removing TCG_BSWAP_IZ we indicate that the input is not zero-extended, and thus can remove an explicit extend. By removing TCG_BSWAP_OZ, we allow the implementation to leave high bits set, which will be ignored by the store. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 0eac2d1969..44d711c0fc 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -2915,8 +2915,7 @@ void tcg_gen_qemu_st_i32(TCGv_i32 val, TCGv addr, TCGArg idx, MemOp memop) swap = tcg_temp_new_i32(); switch (memop & MO_SIZE) { case MO_16: - tcg_gen_ext16u_i32(swap, val); - tcg_gen_bswap16_i32(swap, swap, TCG_BSWAP_IZ | TCG_BSWAP_OZ); + tcg_gen_bswap16_i32(swap, val, 0); break; case MO_32: tcg_gen_bswap32_i32(swap, val); @@ -3013,12 +3012,10 @@ void tcg_gen_qemu_st_i64(TCGv_i64 val, TCGv addr, TCGArg idx, MemOp memop) swap = tcg_temp_new_i64(); switch (memop & MO_SIZE) { case MO_16: - tcg_gen_ext16u_i64(swap, val); - tcg_gen_bswap16_i64(swap, swap, TCG_BSWAP_IZ | TCG_BSWAP_OZ); + tcg_gen_bswap16_i64(swap, val, 0); break; case MO_32: - tcg_gen_ext32u_i64(swap, val); - tcg_gen_bswap32_i64(swap, swap, TCG_BSWAP_IZ | TCG_BSWAP_OZ); + tcg_gen_bswap32_i64(swap, val, 0); break; case MO_64: tcg_gen_bswap64_i64(swap, val); -- 2.25.1