qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>
Subject: [PULL 09/15] python: Fix .PHONY Make specifiers
Date: Wed, 30 Jun 2021 22:09:15 -0400	[thread overview]
Message-ID: <20210701020921.1679468-10-jsnow@redhat.com> (raw)
In-Reply-To: <20210701020921.1679468-1-jsnow@redhat.com>

I missed the 'check-tox' target. Add that, but split the large .PHONY
specifier at the top into its component pieces and move them near the
targets they describe so that they're much harder to forget to update.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-id: 20210629214323.1329806-10-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/Makefile | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/python/Makefile b/python/Makefile
index d2cfa6ad8f..d34c4e35d9 100644
--- a/python/Makefile
+++ b/python/Makefile
@@ -1,5 +1,4 @@
-.PHONY: help pipenv check-pipenv check clean distclean develop
-
+.PHONY: help
 help:
 	@echo "python packaging help:"
 	@echo ""
@@ -29,25 +28,32 @@ help:
 	@echo "                 built distribution files, and everything"
 	@echo "                 from 'make clean'."
 
+.PHONY: pipenv
 pipenv: .venv
 .venv: Pipfile.lock
 	@PIPENV_VENV_IN_PROJECT=1 pipenv sync --dev --keep-outdated
 	@touch .venv
 
+.PHONY: check-pipenv
 check-pipenv: pipenv
 	@pipenv run make check
 
+.PHONY: develop
 develop:
 	pip3 install -e .[devel]
 
+.PHONY: check
 check:
 	@avocado --config avocado.cfg run tests/
 
+.PHONY: check-tox
 check-tox:
 	@tox
 
+.PHONY: clean
 clean:
 	python3 setup.py clean --all
 
+.PHONY: distclean
 distclean: clean
 	rm -rf qemu.egg-info/ .venv/ .tox/ dist/
-- 
2.31.1



  parent reply	other threads:[~2021-07-01  2:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  2:09 [PULL 00/15] Python patches John Snow
2021-07-01  2:09 ` [PULL 01/15] python/qom: Do not use 'err' name at module scope John Snow
2021-07-01  2:09 ` [PULL 02/15] python: expose typing information via PEP 561 John Snow
2021-07-01  2:09 ` [PULL 03/15] python: Remove global pylint suppressions John Snow
2021-07-01  2:09 ` [PULL 04/15] python: Re-lock pipenv at *oldest* supported versions John Snow
2021-07-01  2:09 ` [PULL 05/15] python: README.rst touchups John Snow
2021-07-01  2:09 ` [PULL 06/15] python: Add no-install usage instructions John Snow
2021-07-01  2:09 ` [PULL 07/15] python: rename 'venv-check' target to 'check-pipenv' John Snow
2021-07-01  2:09 ` [PULL 08/15] python: update help text for check-tox John Snow
2021-07-01  2:09 ` John Snow [this message]
2021-07-01  2:09 ` [PULL 10/15] python: only check qemu/ subdir with flake8 John Snow
2021-07-01  2:09 ` [PULL 11/15] python: add 'make check-dev' invocation John Snow
2021-07-01  2:09 ` [PULL 12/15] python: Update help text on 'make check', 'make develop' John Snow
2021-07-01  2:09 ` [PULL 13/15] python: Update help text on 'make clean', 'make distclean' John Snow
2021-07-01  2:09 ` [PULL 14/15] python: remove auto-generated pyproject.toml file John Snow
2021-07-01  2:09 ` [PULL 15/15] python: Fix broken ReST docstrings John Snow
2021-07-01 19:28 ` [PULL 00/15] Python patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210701020921.1679468-10-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).