From: Alessandro Di Federico via <qemu-devel@nongnu.org>
To: Taylor Simpson <tsimpson@quicinc.com>
Cc: Alessandro Di Federico <ale.qemu@rev.ng>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Brian Cain <bcain@quicinc.com>, "babush@rev.ng" <babush@rev.ng>,
"nizzo@rev.ng" <nizzo@rev.ng>,
"philmd@redhat.com" <philmd@redhat.com>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>
Subject: Re: [PATCH v5 10/14] target/hexagon: import parser for idef-parser
Date: Mon, 5 Jul 2021 18:47:41 +0200 [thread overview]
Message-ID: <20210705184741.5b2aae78@orange> (raw)
In-Reply-To: <BYAPR02MB488679E9F94D484852DD2398DE079@BYAPR02MB4886.namprd02.prod.outlook.com>
On Thu, 24 Jun 2021 03:55:35 +0000
Taylor Simpson <tsimpson@quicinc.com> wrote:
> > +void gen_deposit_op(Context *c,
> > + YYLTYPE *locp,
> > + HexValue *dest,
> > + HexValue *value,
> > + HexValue *index,
> > + HexCast *cast)
>
> What's the difference between this and the gen_rdeposit_op above?
`gen_deposit_op` expects index and width (cast) to be immediates, while
`gen_rdeposit_op` does not.
We could merge them together, but it would just be a big "if" over the
whole function.
> > +HexValue gen_rextract_op(Context *c,
> > + YYLTYPE *locp,
> > + HexValue *source,
> > + int begin,
> > + int width) {
> > +
> > +HexValue gen_extract_op(Context *c,
> > + YYLTYPE *locp,
> > + HexValue *source,
> > + HexValue *index,
> > + HexExtract *extract) {
>
> What's the difference between this ant the gen_rextract_op above?
As before.
--
Alessandro Di Federico
rev.ng
next prev parent reply other threads:[~2021-07-05 16:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 9:36 [PATCH v5 00/14] target/hexagon: introduce idef-parser Alessandro Di Federico via
2021-06-19 9:37 ` [PATCH v5 01/14] tcg: expose TCGCond manipulation routines Alessandro Di Federico via
2021-06-19 13:51 ` Richard Henderson
2021-06-19 9:37 ` [PATCH v5 02/14] target/hexagon: update MAINTAINERS for idef-parser Alessandro Di Federico via
2021-06-19 9:37 ` [PATCH v5 03/14] target/hexagon: import README " Alessandro Di Federico via
2021-06-23 15:46 ` Taylor Simpson
2021-06-24 13:51 ` Alessandro Di Federico via
2021-06-19 9:37 ` [PATCH v5 04/14] target/hexagon: make slot number an unsigned Alessandro Di Federico via
2021-06-23 15:58 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 05/14] target/hexagon: make helper functions non-static Alessandro Di Federico via
2021-06-23 18:29 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 06/14] target/hexagon: introduce new helper functions Alessandro Di Federico via
2021-06-23 12:05 ` Taylor Simpson
2021-06-23 18:49 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 07/14] target/hexagon: expose next PC in DisasContext Alessandro Di Federico via
2021-06-23 18:54 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 08/14] target/hexagon: prepare input for the idef-parser Alessandro Di Federico via
2021-06-23 19:37 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 09/14] target/hexagon: import lexer for idef-parser Alessandro Di Federico via
2021-06-23 20:05 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 10/14] target/hexagon: import parser " Alessandro Di Federico via
2021-06-22 22:35 ` Taylor Simpson
2021-06-24 3:55 ` Taylor Simpson
2021-06-29 14:26 ` Alessandro Di Federico via
2021-06-30 16:51 ` Paolo Montesel
2021-07-05 16:47 ` Alessandro Di Federico via [this message]
2021-06-19 9:37 ` [PATCH v5 11/14] target/hexagon: call idef-parser functions Alessandro Di Federico via
2021-06-25 22:00 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 12/14] target/hexagon: remove unused macros and functions Alessandro Di Federico via
2021-06-25 22:02 ` Taylor Simpson
2021-06-19 9:37 ` [PATCH v5 13/14] target/hexagon: import additional tests Alessandro Di Federico via
2021-06-25 23:56 ` Taylor Simpson
2021-06-28 22:39 ` Taylor Simpson
2021-07-05 16:50 ` Alessandro Di Federico via
2021-06-19 9:37 ` [PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry Alessandro Di Federico via
2021-06-29 14:26 ` Alessandro Di Federico via
2021-06-29 14:37 ` Daniel P. Berrangé
2021-07-08 16:00 ` Alessandro Di Federico via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705184741.5b2aae78@orange \
--to=qemu-devel@nongnu.org \
--cc=ale.qemu@rev.ng \
--cc=ale@rev.ng \
--cc=babush@rev.ng \
--cc=bcain@quicinc.com \
--cc=nizzo@rev.ng \
--cc=philmd@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).