From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: [PATCH v2 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables
Date: Thu, 8 Jul 2021 11:45:42 -0400 [thread overview]
Message-ID: <20210708154617.1538485-1-imammedo@redhat.com> (raw)
v2:
- drop test related patches, they will be sent as a separate series
- fix bios_loader pointer initialization ordering when using TPM1.2
- extend commit message of [1/35] and add extra comment about
table length patching
Highlights:
* drop pointer arithmetic in ACPI tables code
* use endian agnostic API
* simplifies review of tables. /in most cases just line by line comparision with spec/
Series replaces build_header() with acpi_init_table()/acpi_table_composed()
API that hides pointer/offset arithmetic from user, to prevent
errors caused by it [1].
While doing above, it was necessary to split table header from
packed structure that was describing the table, which is
counter-productive since it still leaves packed structure drawbacks.
So that sort of forced me to rewrite tables that were composed with
help of packed structures to preferred build_append_int_noprefix() API.
In cases where refactoring to build_append_int_noprefix() was small,
it was squashed with acpi_init_table()/acpi_table_composed() patch.
Conversion reduced code size quite a bit despite me adding doc comments
for every table row.
1) commits
bb9feea43179 x86: acpi: use offset instead of pointer when using build_header()
4d027afeb3a9 Virt: ACPI: fix qemu assert due to re-assigned table data address
Link to repo:
https://gitlab.com/imammedo/qemu/-/commits/acpi_build_header_refactoring_v2
CC: mst@redhat.com
Igor Mammedov (35):
acpi: add helper routines to initialize ACPI tables
acpi: build_rsdt: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: build_xsdt: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: build_slit: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: build_fadt: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: build_tpm2: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: acpi_build_hest: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: build_mcfg: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: build_hmat: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: nvdimm_build_nfit: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: nvdimm_build_ssdt: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: vmgenid_build_acpi: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: x86: build_dsdt: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: build_hpet: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: build_tpm_tcpa: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: arm/x86: build_srat: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: use build_append_int_noprefix() API to compose SRAT table
acpi: build_dmar_q35: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: build_waet: use acpi_init_table()/acpi_table_composed() instead
of build_header()
acpi: build_amd_iommu: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: madt: arm/x86: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: x86: remove dead code
acpi: x86: set enabled when composing _MAT entries
acpi: x86: madt: use build_append_int_noprefix() API to compose MADT
table
acpi: arm/virt: madt: use build_append_int_noprefix() API to compose
MADT table
acpi: build_dsdt_microvm: use acpi_init_table()/acpi_table_composed()
instead of build_header()
acpi: arm: virt: build_dsdt: use
acpi_init_table()/acpi_table_composed() instead of build_header()
acpi: arm: virt: build_iort: use
acpi_init_table()/acpi_table_composed() instead of build_header()
acpi: arm/virt: convert build_iort() to endian agnostic
build_append_FOO() API
acpi: arm/virt: build_spcr: fix invalid cast
acpi: arm/virt: build_spcr: use
acpi_init_table()/acpi_table_composed() instead of build_header()
acpi: arm/virt: build_gtdt: use
acpi_init_table()/acpi_table_composed() instead of build_header()
acpi: build_facs: use build_append_int_noprefix() API to compose table
acpi: remove no longer used build_header()
acpi: AcpiGenericAddress no longer used to map/access fields of MMIO,
drop packed attribute
include/hw/acpi/acpi-defs.h | 528 +------------------------
include/hw/acpi/acpi_dev_interface.h | 3 +-
include/hw/acpi/aml-build.h | 21 +-
include/hw/i386/pc.h | 7 +-
hw/acpi/acpi-x86-stub.c | 3 +-
hw/acpi/aml-build.c | 193 ++++++----
hw/acpi/cpu.c | 17 +-
hw/acpi/ghes.c | 10 +-
hw/acpi/hmat.c | 14 +-
hw/acpi/nvdimm.c | 64 ++--
hw/acpi/pci.c | 18 +-
hw/acpi/vmgenid.c | 16 +-
hw/arm/virt-acpi-build.c | 550 +++++++++++++++------------
hw/i386/acpi-build.c | 284 ++++++++------
hw/i386/acpi-common.c | 158 ++++----
hw/i386/acpi-microvm.c | 13 +-
16 files changed, 750 insertions(+), 1149 deletions(-)
--
2.27.0
next reply other threads:[~2021-07-08 16:24 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 15:45 Igor Mammedov [this message]
2021-07-08 15:45 ` [PATCH v2 01/35] acpi: add helper routines to initialize ACPI tables Igor Mammedov
2021-09-02 12:56 ` Eric Auger
2021-09-03 7:12 ` Igor Mammedov
2021-09-03 7:22 ` Eric Auger
2021-09-06 12:17 ` Igor Mammedov
2021-09-04 19:57 ` Michael S. Tsirkin
2021-09-06 12:14 ` Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 02/35] acpi: build_rsdt: use acpi_init_table()/acpi_table_composed() instead of build_header() Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 03/35] acpi: build_xsdt: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 04/35] acpi: build_slit: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 05/35] acpi: build_fadt: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 06/35] acpi: build_tpm2: " Igor Mammedov
2021-09-02 12:59 ` Eric Auger
2021-07-08 15:45 ` [PATCH v2 07/35] acpi: acpi_build_hest: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 08/35] acpi: build_mcfg: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 09/35] acpi: build_hmat: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 10/35] acpi: nvdimm_build_nfit: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 11/35] acpi: nvdimm_build_ssdt: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 12/35] acpi: vmgenid_build_acpi: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 13/35] acpi: x86: build_dsdt: " Igor Mammedov
2021-09-02 15:35 ` Eric Auger
2021-07-08 15:45 ` [PATCH v2 14/35] acpi: build_hpet: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 15/35] acpi: build_tpm_tcpa: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 16/35] acpi: arm/x86: build_srat: " Igor Mammedov
2021-07-08 15:45 ` [PATCH v2 17/35] acpi: use build_append_int_noprefix() API to compose SRAT table Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 18/35] acpi: build_dmar_q35: use acpi_init_table()/acpi_table_composed() instead of build_header() Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 19/35] acpi: build_waet: " Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 20/35] acpi: build_amd_iommu: " Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 21/35] acpi: madt: arm/x86: " Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 22/35] acpi: x86: remove dead code Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 23/35] acpi: x86: set enabled when composing _MAT entries Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 24/35] acpi: x86: madt: use build_append_int_noprefix() API to compose MADT table Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 25/35] acpi: arm/virt: " Igor Mammedov
2021-09-03 13:45 ` Eric Auger
2021-09-06 12:40 ` Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 26/35] acpi: build_dsdt_microvm: use acpi_init_table()/acpi_table_composed() instead of build_header() Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 27/35] acpi: arm: virt: build_dsdt: " Igor Mammedov
2021-09-02 15:34 ` Eric Auger
2021-07-08 15:46 ` [PATCH v2 28/35] acpi: arm: virt: build_iort: " Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 29/35] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API Igor Mammedov
2021-07-09 7:11 ` Michael S. Tsirkin
2021-07-09 8:59 ` Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 30/35] acpi: arm/virt: build_spcr: fix invalid cast Igor Mammedov
2021-09-02 15:51 ` Eric Auger
2021-07-08 15:46 ` [PATCH v2 31/35] acpi: arm/virt: build_spcr: use acpi_init_table()/acpi_table_composed() instead of build_header() Igor Mammedov
2021-09-02 15:49 ` Eric Auger
2021-09-03 7:52 ` Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 32/35] acpi: arm/virt: build_gtdt: " Igor Mammedov
2021-09-02 16:07 ` Eric Auger
2021-07-08 15:46 ` [PATCH v2 33/35] acpi: build_facs: use build_append_int_noprefix() API to compose table Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 34/35] acpi: remove no longer used build_header() Igor Mammedov
2021-07-08 15:46 ` [PATCH v2 35/35] acpi: AcpiGenericAddress no longer used to map/access fields of MMIO, drop packed attribute Igor Mammedov
2021-07-13 15:45 ` [PATCH v2 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables Michael S. Tsirkin
2021-07-14 8:53 ` Igor Mammedov
2021-07-14 10:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708154617.1538485-1-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).