Re: [PATCH v4 7/8] hw/arm/sbsa-ref: add ITS support in SBSA GIC

From: Leif Lindholm <leif@nuviainc.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Shashi Mallela <shashi.mallela@linaro.org>,
	Radoslaw Biernacki <rad@semihalf.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [PATCH v4 7/8] hw/arm/sbsa-ref: add ITS support in SBSA GIC
Date: Thu, 8 Jul 2021 23:05:46 +0100	[thread overview]
Message-ID: <20210708220546.rd7yqpsh6l7dmltu@leviathan> (raw)
In-Reply-To: <CAFEAcA-9XnY=4qsD9RGVy1sTW-d=B6MGPLd-Qqs7HWMRC-dfeQ@mail.gmail.com>

On Thu, Jul 08, 2021 at 21:05:02 +0100, Peter Maydell wrote:
> On Thu, 8 Jul 2021 at 20:40, Leif Lindholm <leif@nuviainc.com> wrote:
> > I think my summary-summary would be:
> > - I think we will need to introduce a compatiblity-breaking change to
> >   sbsa-ref.
> > - I think we will need to have support for more than one ITS if we're
> >   going to be able to use QEMU to prototype real systems.
> > - I think we should then start versioning sbsa-ref (like many other
> >   platforms already are). And there are other reasons why I would want
> >   to do this.
> > - But I think it would be unfair to hold this set back for it.
> 
> FWIW, I do not currently expect this series to make 6.1, so we
> have some time to get things right.

Ah, ok.

Then I would ideally like to see this patch add the ITS block between
Distributor and Redistributors regions. I think it makes the most sense
for this version to match the GIC-600 layout.

I am also going to rework those two remaining gicv4-ish patches based
on my acquired understanding, to be sent out post v6.1.

And, I would like to switch the default CPU of sbsa-ref to "max" as
part of that platform versioning, now that is supported in TF-A
(from v2.5).

/
    Leif