From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3DA2C12002 for ; Fri, 16 Jul 2021 15:10:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2755160FF3 for ; Fri, 16 Jul 2021 15:10:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2755160FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4PTy-00069J-2B for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 11:10:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4PTE-0005Ug-47 for qemu-devel@nongnu.org; Fri, 16 Jul 2021 11:09:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4PTA-00008m-DU for qemu-devel@nongnu.org; Fri, 16 Jul 2021 11:09:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626448178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iu0KOHj+7naskYSaGn4sdJRO/QFbUfgY5P60NUOokIY=; b=U9VH6lpt87hEvtGRZutnkAZbv+tWgiLI7zyPJxbfETt8fmJj/Z0YpxnwXRupJMZt5dNhNQ LavqI1wSKNdw8VRpkEct4G3ChozUiwsip4nCTxhqFSl9BAtVT20d4ucmUr4k7y9kQmfjUk aP94mczlq7f9sTKtjL4YwL28u+PihSE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-p-QiaPkUNOKJN69eJ7NTJg-1; Fri, 16 Jul 2021 11:09:37 -0400 X-MC-Unique: p-QiaPkUNOKJN69eJ7NTJg-1 Received: by mail-wm1-f70.google.com with SMTP id j141-20020a1c23930000b0290212502cb19aso3286014wmj.0 for ; Fri, 16 Jul 2021 08:09:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iu0KOHj+7naskYSaGn4sdJRO/QFbUfgY5P60NUOokIY=; b=Y5bV2SPz0/N3IlMg1wX4gqjNUTkO0Usy1K2VW9df/kMaerZlSZ9EAycTy0LpaTkj28 mUyV1CU/PjDg3OoNOc44jGOM4dkppUu3vSqSp3bFH1NAeB97pLJad+9cOh7kKdIDkWuA BN2ayRSd/Ffo5NPpQMNNNy6AKSsX2XVkjOhVEHbgNZP8Mlyb+9pEiqm/CZ1X+nV3NV6l HCAAeN0+X/QoexqLgsMKSWolAimxp7MJ8yLPOerE1qBXZMqecpwWnHNAvFU1YJ53nBkq GZJ5f46UeQp6dc3OvlFXLlQnbdEgDEK9eXc74uBsVBBBhT02km2bcX2lXbrlv7OPTX0d sdXQ== X-Gm-Message-State: AOAM530fi0XwYt9jeBNY+pN/Tk4UCvprdguGHrMeaCQXY/sodFUuH819 icvN8f8ggelmDL6W3z1FAen2Q+E2XOtorHLYCsc81LHRg0yQBE1kOzHjlg+qzHuYb+lYEBku/Bh gyG88KfHwG962uCY= X-Received: by 2002:a7b:c150:: with SMTP id z16mr17010782wmi.104.1626448176028; Fri, 16 Jul 2021 08:09:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoYjdhMbcnIx16UUoqxZCNbAyHV0Bt/gORwgRxgQqNjJyPK3Hswlf2/NGgg9R8L1/rBOH3bA== X-Received: by 2002:a7b:c150:: with SMTP id z16mr17010752wmi.104.1626448175722; Fri, 16 Jul 2021 08:09:35 -0700 (PDT) Received: from redhat.com ([2a10:8004:6ff2:0:a1b1:b3d8:4c4e:4825]) by smtp.gmail.com with ESMTPSA id n5sm9990453wri.31.2021.07.16.08.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 08:09:35 -0700 (PDT) Date: Fri, 16 Jul 2021 11:09:32 -0400 From: "Michael S. Tsirkin" To: Peter Maydell Subject: Re: [PULL 00/23] pc,pci,virtio: lots of new features Message-ID: <20210716103152-mutt-send-email-mst@kernel.org> References: <20210713220946.212562-1-mst@redhat.com> <20210715172049-mutt-send-email-mst@kernel.org> <20210716043525-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 16, 2021 at 03:12:53PM +0100, Peter Maydell wrote: > On Fri, 16 Jul 2021 at 09:41, Michael S. Tsirkin wrote: > > > > On Fri, Jul 16, 2021 at 07:41:16AM +0100, Peter Maydell wrote: > > > On Thu, 15 Jul 2021 at 22:21, Michael S. Tsirkin wrote: > > > > > > > > On Wed, Jul 14, 2021 at 09:31:21PM +0100, Peter Maydell wrote: > > > > > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote: > > > > > > > > > > > > The following changes since commit 708f50199b59476ec4b45ebcdf171550086d6292: > > > > > > > > > > > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' into staging (2021-07-13 14:32:20 +0100) > > > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > > > > > > > > > for you to fetch changes up to cf171f90d5e41730ad3e0ce23f1990f34b7e63ef: > > > > > > > > > > > > vhost-vsock: SOCK_SEQPACKET feature bit support (2021-07-13 16:59:12 -0400) > > > > > > > > > > > > ---------------------------------------------------------------- > > > > > > pc,pci,virtio: lots of new features > > > > > > > > > > > > Lots of last minute stuff. > > > > > > > > > > > > vhost-user-rng. > > > > > > vhost-user-i2c. > > > > > > vhost-vsock SOCK_SEQPACKET support. > > > > > > IOMMU bypass. > > > > > > ACPI based pci hotplug. > > > > > > > > > > > > Signed-off-by: Michael S. Tsirkin > > > > > > > > > > This seems to produce a new meson warning: > > > > > > > > > > Configuring 50-qemu-gpu.json using configuration > > > > > Configuring 50-qemu-virtiofsd.json using configuration > > > > > Configuring 50-qemu-rng.json using configuration > > > > > ../../tools/vhost-user-rng/meson.build:7: WARNING: The variable(s) > > > > > 'libexecdir' in the input file > > > > > 'tools/vhost-user-rng/50-qemu-rng.json.in' are not present in the > > > > > given configuration data. > > > > > Configuring 50-edk2-i386-secure.json using configuration > > > > > Configuring 50-edk2-x86_64-secure.json using configuration > > > > > Configuring 60-edk2-aarch64.json using configuration > > > > > > > > > > (the build then seems to go on to complete OK). > > > > > > > > > > -- PMM > > > > > > > > > > > > I sent an email about a fix. Do you prefer PULLv2 then? > > > > > > Same tag, right? I've put this back on my list, but I'm still > > > working through a backlog of other pullreqs before I get back > > > to this one. > > > > > > -- PMM > > > > Yes. If you merge it there's a trivial conflict. > > > > If you'd rather see it rebased here it is: for_upstream2 > > I tried the for_upstream2 tag, but it fails to compile on > some of the gitlab jobs: > https://gitlab.com/qemu-project/qemu/-/jobs/1430322920 > https://gitlab.com/qemu-project/qemu/-/jobs/1430323102 > > /usr/bin/ld: tools/vhost-user-rng/vhost-user-rng.p/main.c.o: in > function `vu_rng_queue_set_started': > /builds/qemu-project/qemu/build/../tools/vhost-user-rng/main.c:198: > undefined reference to `vu_get_queue' > > and various other missing symbols at link time. > > thanks > -- PMM Clearly some meson/config related issues. I don't understand why it links fine on my box yet, but that is a puzzle for another day. I've dropped vhost-user-rng for now. We'll work to include it in the next release. -- MST