From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EDBC07E95 for ; Tue, 20 Jul 2021 13:44:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A59D061164 for ; Tue, 20 Jul 2021 13:44:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A59D061164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5q2Y-0003hT-Pt for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 09:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5q1D-0001I7-Hc for qemu-devel@nongnu.org; Tue, 20 Jul 2021 09:42:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5q1B-0004ti-VZ for qemu-devel@nongnu.org; Tue, 20 Jul 2021 09:42:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626788561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pbgQ4koNjwN8N2l8r6v0wHs4DYn7ekng7boW6EzueSE=; b=fiuI2G2uDiGohDgsPiuk9FH3hbXJKSooN+ULtV0pyLLSb9uakCKvnd5Bxk8ru0FYznkDfo wmaN7Q5bwG2zwiydgPTQpjFt5GK/tS0F4TbgRXGCXy8qEtQphKTEwpqYMlEy3+gh41ZprG EYoLiCH7U5RVmijlEqNHt0UBemWFQHc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-MvSM5aznOuKqMkqRpC6THA-1; Tue, 20 Jul 2021 09:42:38 -0400 X-MC-Unique: MvSM5aznOuKqMkqRpC6THA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33B5E800C78; Tue, 20 Jul 2021 13:42:37 +0000 (UTC) Received: from redhat.com (ovpn-112-216.phx2.redhat.com [10.3.112.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B79575D6A1; Tue, 20 Jul 2021 13:42:21 +0000 (UTC) Date: Tue, 20 Jul 2021 08:42:20 -0500 From: Eric Blake To: Markus Armbruster Subject: Re: [PATCH 01/16] error: Use error_fatal to simplify obvious fatal errors (again) Message-ID: <20210720134220.vokqvfa6pjcdsj2l@redhat.com> References: <20210720125408.387910-1-armbru@redhat.com> <20210720125408.387910-2-armbru@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210720125408.387910-2-armbru@redhat.com> User-Agent: NeoMutt/20210205-614-b535a5 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.474, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Juan Quintela , qemu-devel@nongnu.org, Peter Xu , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , Cornelia Huck , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 20, 2021 at 02:53:53PM +0200, Markus Armbruster wrote: > We did this with scripts/coccinelle/use-error_fatal.cocci before, in > commit 50beeb68094 and 007b06578ab. This commit cleans up rarer > variations that don't seem worth matching with Coccinelle. > > Cc: Thomas Huth > Cc: Cornelia Huck > Cc: Peter Xu > Cc: Juan Quintela > Cc: Stefan Hajnoczi > Cc: Paolo Bonzini > Cc: Marc-André Lureau > Cc: Gerd Hoffmann > Cc: Daniel P. Berrangé > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake I agree with your assessment that this is not bug-fix material needed in 6.1. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org