From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97E1C12002 for ; Wed, 21 Jul 2021 10:06:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D4DB61029 for ; Wed, 21 Jul 2021 10:06:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D4DB61029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m697X-0006Hp-IC for qemu-devel@archiver.kernel.org; Wed, 21 Jul 2021 06:06:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m68wF-0005kF-Pc for qemu-devel@nongnu.org; Wed, 21 Jul 2021 05:54:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m68wE-0002wX-58 for qemu-devel@nongnu.org; Wed, 21 Jul 2021 05:54:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626861289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mkTwhICeX1bzL5yyzwF3/giRIodxXPU4ANQn2RnUfyI=; b=d8nCIFwVxKAIVFXGbKwl87y6+RyLu+oC97Xx2ZW9UKv4buodAerVijueIoDxyYcsrLARZE Kx/rWLWTa+f7RwiyYATpklS3LRWXc+MyurBKnO4uPs6FyMjr6T2evXowx8A7pLMFEaXCGw V+VJtlAvUwF77Nn5sFkc9VJCt0r25os= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-2UHqFTHEMGizLu_69G48FA-1; Wed, 21 Jul 2021 05:54:48 -0400 X-MC-Unique: 2UHqFTHEMGizLu_69G48FA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55A898026BB; Wed, 21 Jul 2021 09:54:47 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-106.ams2.redhat.com [10.36.114.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E2F260854; Wed, 21 Jul 2021 09:54:47 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8152F18000B2; Wed, 21 Jul 2021 11:54:45 +0200 (CEST) Date: Wed, 21 Jul 2021 11:54:45 +0200 From: Gerd Hoffmann To: "Jose R. Ziviani" Subject: Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name() Message-ID: <20210721095445.be2ftvxygi6utoj4@sirius.home.kraxel.org> References: <20210630232749.21873-1-jziviani@suse.de> <20210630232749.21873-4-jziviani@suse.de> MIME-Version: 1.0 In-Reply-To: <20210630232749.21873-4-jziviani@suse.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.474, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, cfontana@suse.de Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > ObjectClass *module_object_class_by_name(const char *typename) > { > ObjectClass *oc; > @@ -1031,8 +1049,20 @@ ObjectClass *module_object_class_by_name(const char *typename) > oc = object_class_by_name(typename); > #ifdef CONFIG_MODULES > if (!oc) { > + char *module_name; > module_load_qom_one(typename); > oc = object_class_by_name(typename); > + module_name = get_accel_module_name(typename); > + if (module_name) { > + if (!module_is_loaded(module_name)) { > + fprintf(stderr, "%s module is missing, install the " > + "package or config the library path " > + "correctly.\n", module_name); > + g_free(module_name); > + exit(1); > + } > + g_free(module_name); > + } This error logging should IMHO be moved to util/module.c. Either have a helper function to print the error message, or have module_load_qom_one() print it. There is also no need to hard-code the module names. We have the module database and module_load_qom_one() uses it to figure which module must be loaded for a specific qom object. We can likewise use the database for printing the error message. take care, Gerd