From: Mahmoud Mandour <ma.mandourr@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Mahmoud Mandour" <ma.mandourr@gmail.com>,
cota@braap.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v3 07/13] plugins/howvec: Adapting to the new argument passing scheme.
Date: Thu, 22 Jul 2021 09:12:30 +0200 [thread overview]
Message-ID: <20210722071236.139520-8-ma.mandourr@gmail.com> (raw)
In-Reply-To: <20210722071236.139520-1-ma.mandourr@gmail.com>
Correctly parsing plugin argument since they now must be provided as
full-form boolean parameters, e.g.:
-plugin ./contrib/plugins/libhowvec.so,verbose=on,inline=on
Also, introduced the argument "count" that accepts one opt to count
individually at a time.
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
---
contrib/plugins/howvec.c | 27 +++++++++++++++++++--------
docs/devel/tcg-plugins.rst | 10 +++++-----
2 files changed, 24 insertions(+), 13 deletions(-)
diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c
index 600f7facc1..4a5ec3d936 100644
--- a/contrib/plugins/howvec.c
+++ b/contrib/plugins/howvec.c
@@ -333,23 +333,34 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id,
for (i = 0; i < argc; i++) {
char *p = argv[i];
- if (strcmp(p, "inline") == 0) {
- do_inline = true;
- } else if (strcmp(p, "verbose") == 0) {
- verbose = true;
- } else {
+ g_autofree char **tokens = g_strsplit(p, "=", -1);
+ if (g_strcmp0(tokens[0], "inline") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_inline)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", p);
+ return -1;
+ }
+ } else if (g_strcmp0(tokens[0], "verbose") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &verbose)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", p);
+ return -1;
+ }
+ } else if (g_strcmp0(tokens[0], "count") == 0) {
+ char *value = tokens[1];
int j;
CountType type = COUNT_INDIVIDUAL;
- if (*p == '!') {
+ if (*value == '!') {
type = COUNT_NONE;
- p++;
+ value++;
}
for (j = 0; j < class_table_sz; j++) {
- if (strcmp(p, class_table[j].opt) == 0) {
+ if (strcmp(value, class_table[j].opt) == 0) {
class_table[j].what = type;
break;
}
}
+ } else {
+ fprintf(stderr, "option parsing failed: %s\n", p);
+ return -1;
}
}
diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index b7148abef5..9377bc51d8 100644
--- a/docs/devel/tcg-plugins.rst
+++ b/docs/devel/tcg-plugins.rst
@@ -79,7 +79,7 @@ Once built a program can be run with multiple plugins loaded each with
their own arguments::
$QEMU $OTHER_QEMU_ARGS \
- -plugin tests/plugin/libhowvec.so,arg=inline,arg=hint \
+ -plugin tests/plugin/libhowvec.so,inline=on,count=hint \
-plugin tests/plugin/libhotblocks.so
Arguments are plugin specific and can be used to modify their
@@ -211,13 +211,13 @@ The hotpages plugin can be configured using the following arguments:
This is an instruction classifier so can be used to count different
types of instructions. It has a number of options to refine which get
-counted. You can give an argument for a class of instructions to break
-it down fully, so for example to see all the system registers
-accesses::
+counted. You can give a value to the `count` argument for a class of
+instructions to break it down fully, so for example to see all the system
+registers accesses::
./aarch64-softmmu/qemu-system-aarch64 $(QEMU_ARGS) \
-append "root=/dev/sda2 systemd.unit=benchmark.service" \
- -smp 4 -plugin ./contrib/plugins/libhowvec.so,arg=sreg -d plugin
+ -smp 4 -plugin ./contrib/plugins/libhowvec.so,count=sreg -d plugin
which will lead to a sorted list after the class breakdown::
--
2.25.1
next prev parent reply other threads:[~2021-07-22 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 7:12 [PATCH v3 00/13] new plugin argument passing scheme Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 01/13] plugins: allow plugin arguments to be passed directly Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 02/13] plugins/api: added a boolean parsing plugin api Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 03/13] plugins/hotpages: introduce sortby arg and parsed bool args correctly Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 04/13] plugins/hotblocks: Added correct boolean argument parsing Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 05/13] plugins/lockstep: make socket path not positional & parse bool arg Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 06/13] plugins/hwprofile: adapt to the new plugin arguments scheme Mahmoud Mandour
2021-07-22 7:12 ` Mahmoud Mandour [this message]
2021-07-22 7:12 ` [PATCH v3 08/13] docs/tcg-plugins: new passing parameters scheme for cache docs Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 09/13] tests/plugins/bb: adapt to the new arg passing scheme Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 11/13] tests/plugins/mem: introduce "track" arg and make args not positional Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme Mahmoud Mandour
2021-07-22 7:12 ` [PATCH v3 13/13] docs/deprecated: deprecate passing plugin args through `arg=` Mahmoud Mandour
2021-07-23 8:57 ` [PATCH v3 00/13] new plugin argument passing scheme Mahmoud Mandour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722071236.139520-8-ma.mandourr@gmail.com \
--to=ma.mandourr@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).