From: Gerd Hoffmann <kraxel@redhat.com>
To: "Jose R. Ziviani" <jziviani@suse.de>
Cc: pbonzini@redhat.com, richard.henderson@linaro.org,
qemu-devel@nongnu.org, cfontana@suse.de
Subject: Re: [PATCH v2 1/1] modules: Improve error message when module is not found
Date: Fri, 23 Jul 2021 08:25:20 +0200 [thread overview]
Message-ID: <20210723062520.hp6qux5enrwyw56u@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210722220952.17444-2-jziviani@suse.de>
Hi,
> --- a/accel/accel-softmmu.c
> +++ b/accel/accel-softmmu.c
> @@ -79,7 +79,10 @@ void accel_init_ops_interfaces(AccelClass *ac)
> * all accelerators need to define ops, providing at least a mandatory
> * non-NULL create_vcpu_thread operation.
> */
> - g_assert(ops != NULL);
> + if (ops == NULL) {
Error message here?
Also split accel bits into a separate patch?
> g_hash_table_remove(loaded_modules, module_name);
> + fprintf(stderr, "%s module is missing, install the "
> + "package or config the library path "
> + "correctly.\n", module_name);
This should be error_report(), or maybe warn_report() as this
isn't a fatal error in all cases. Otherwise looks good to me.
take care,
Gerd
next prev parent reply other threads:[~2021-07-23 6:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 22:09 [PATCH v2 0/1] Improve module accelerator error message Jose R. Ziviani
2021-07-22 22:09 ` [PATCH v2 1/1] modules: Improve error message when module is not found Jose R. Ziviani
2021-07-23 6:25 ` Gerd Hoffmann [this message]
2021-07-23 8:04 ` Claudio Fontana
2021-07-23 8:28 ` Markus Armbruster
2021-07-23 8:32 ` Claudio Fontana
2021-07-23 9:41 ` Claudio Fontana
2021-07-23 9:52 ` Gerd Hoffmann
2021-07-23 11:20 ` Claudio Fontana
2021-07-23 12:20 ` Claudio Fontana
2021-07-23 12:48 ` Gerd Hoffmann
2021-07-29 9:14 ` modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found Gerd Hoffmann
2021-07-29 9:40 ` modular tcg Claudio Fontana
2021-07-29 10:26 ` Gerd Hoffmann
2021-07-29 10:42 ` Claudio Fontana
2021-07-29 9:42 ` Claudio Fontana
2021-07-29 10:29 ` Gerd Hoffmann
2021-07-29 10:44 ` Claudio Fontana
2021-07-29 11:34 ` Philippe Mathieu-Daudé
2021-07-29 11:39 ` Claudio Fontana
2021-07-29 14:22 ` Claudio Fontana
2021-07-29 14:59 ` Philippe Mathieu-Daudé
2021-07-29 16:35 ` Claudio Fontana
2021-07-29 16:40 ` modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found Paolo Bonzini
2021-07-30 9:05 ` modular tcg Gerd Hoffmann
2021-07-30 10:02 ` Claudio Fontana
2022-09-02 9:50 ` modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found Claudio Fontana
2021-07-23 13:50 ` [PATCH v2 1/1] modules: Improve error message when module is not found Jose R. Ziviani
2021-07-23 14:02 ` Claudio Fontana
2021-07-23 14:14 ` Philippe Mathieu-Daudé
2021-07-23 14:36 ` Jose R. Ziviani
2021-07-23 15:27 ` Claudio Fontana
2021-07-23 15:46 ` Jose R. Ziviani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723062520.hp6qux5enrwyw56u@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=cfontana@suse.de \
--cc=jziviani@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).