qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: [PATCH for-6.1? v2 8/9] linux-user/syscall: Remove unused variable from execve
Date: Sun, 25 Jul 2021 02:24:15 -1000	[thread overview]
Message-ID: <20210725122416.1391332-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210725122416.1391332-1-richard.henderson@linaro.org>

From clang-13:
linux-user/syscall.c:8503:17: error: variable 'total_size' set but not used \
    [-Werror,-Wunused-but-set-variable]

Acked-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/syscall.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 376629c689..ccd3892b2d 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8364,7 +8364,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
             abi_ulong guest_envp;
             abi_ulong addr;
             char **q;
-            int total_size = 0;
 
             argc = 0;
             guest_argp = arg2;
@@ -8396,7 +8395,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
                     break;
                 if (!(*q = lock_user_string(addr)))
                     goto execve_efault;
-                total_size += strlen(*q) + 1;
             }
             *q = NULL;
 
@@ -8408,7 +8406,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
                     break;
                 if (!(*q = lock_user_string(addr)))
                     goto execve_efault;
-                total_size += strlen(*q) + 1;
             }
             *q = NULL;
 
-- 
2.25.1



  parent reply	other threads:[~2021-07-25 12:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25 12:24 [PATCH for-6.1? v2 0/9] Fixes for clang-13 Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 1/9] nbd/server: Mark variable unused in nbd_negotiate_meta_queries Richard Henderson
2021-07-26 10:16   ` Vladimir Sementsov-Ogievskiy
2021-07-26 14:53   ` Eric Blake
2021-07-25 12:24 ` [PATCH for-6.1? v2 2/9] accel/tcg: Remove unused variable in cpu_exec Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 3/9] util/selfmap: Discard mapping on error Richard Henderson
2021-07-26 15:37   ` Eric Blake
2021-07-25 12:24 ` [PATCH for-6.1? v2 4/9] net/checksum: Remove unused variable in net_checksum_add_iov Richard Henderson
2021-07-26 15:38   ` Eric Blake
2021-07-25 12:24 ` [PATCH for-6.1? v2 5/9] hw/audio/adlib: Remove unused variable in adlib_callback Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 6/9] hw/ppc/spapr_events: Remove unused variable from check_exception Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 7/9] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write Richard Henderson
2021-07-25 21:27   ` Philippe Mathieu-Daudé
2021-07-26  4:58     ` Benjamin Herrenschmidt
2021-07-26  6:58     ` Cédric Le Goater
2021-07-25 12:24 ` Richard Henderson [this message]
2021-07-25 12:24 ` [PATCH for-6.1? v2 9/9] tests/unit: Remove unused variable from test_io Richard Henderson
2021-07-26 17:10 ` [PATCH for-6.1? v2 0/9] Fixes for clang-13 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210725122416.1391332-9-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).