qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, wei.w.wang@intel.com, peterx@redhat.com
Cc: berrange@redhat.com, leobras@redhat.com, david@redhat.com,
	quintela@redhat.com
Subject: [PULL 1/7] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
Date: Mon, 26 Jul 2021 13:43:25 +0100	[thread overview]
Message-ID: <20210726124331.124710-2-dgilbert@redhat.com> (raw)
In-Reply-To: <20210726124331.124710-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
in baddest; it's really testing the :0 port number that isn't allowed
on anything.

(The test doesn't currently run anyway because of the userfault
problem that Peter noticed, but this gets us closer to being able to
reenable it)

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20210719185217.122105-1-dgilbert@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tests/qtest/migration-test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 328d6dbe97..1e8b7784ef 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -787,10 +787,10 @@ static void test_baddest(void)
 
     args->hide_stderr = true;
 
-    if (test_migrate_start(&from, &to, "tcp:0:0", args)) {
+    if (test_migrate_start(&from, &to, "tcp:127.0.0.1:0", args)) {
         return;
     }
-    migrate_qmp(from, "tcp:0:0", "{}");
+    migrate_qmp(from, "tcp:127.0.0.1:0", "{}");
     wait_for_migration_fail(from, false);
     test_migrate_end(from, to, false);
 }
-- 
2.31.1



  reply	other threads:[~2021-07-26 12:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 12:43 [PULL 0/7] migration queue Dr. David Alan Gilbert (git)
2021-07-26 12:43 ` Dr. David Alan Gilbert (git) [this message]
2021-07-26 12:43 ` [PULL 2/7] migration: Fix missing join() of rp_thread Dr. David Alan Gilbert (git)
2021-07-26 12:43 ` [PULL 3/7] migration: Make from_dst_file accesses thread-safe Dr. David Alan Gilbert (git)
2021-07-26 12:43 ` [PULL 4/7] migration: Introduce migration_ioc_[un]register_yank() Dr. David Alan Gilbert (git)
2021-07-26 12:43 ` [PULL 5/7] migration: Teach QEMUFile to be QIOChannel-aware Dr. David Alan Gilbert (git)
2021-07-26 12:43 ` [PULL 6/7] migration: Move the yank unregister of channel_close out Dr. David Alan Gilbert (git)
2021-07-26 12:43 ` [PULL 7/7] migration: clear the memory region dirty bitmap when skipping free pages Dr. David Alan Gilbert (git)
2021-07-27 12:24 ` [PULL 0/7] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726124331.124710-2-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@redhat.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).